mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: lgirdwood@gmail.com, iskren.chernev@gmail.com
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
	Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Subject: [PATCH 0/2] regulator: max77826: Constify and simplify
Date: Sun,  8 Sep 2024 13:40:43 +0200	[thread overview]
Message-ID: <cover.1725791361.git.christophe.jaillet@wanadoo.fr> (raw)

Patch 1 is just a constification path. It should be straighforward.


Patch 2 is COMPLETELY SPECULATIVE. Some code and memory allocation
*LOOK* useless. So review with care!
Looking are lore does not give any information about this code to me.
v1: https://lore.kernel.org/all/20200413164440.1138178-1-iskren.chernev@gmail.com/
v2: https://lore.kernel.org/all/20200414172250.2363235-1-iskren.chernev@gmail.com/

It *looks* like code written to release some resources in a .remove()
function, maybe used before switchwing to devm_ function.

Christophe JAILLET (2):
  regulator: max77826: Constify struct regulator_desc
  regulator: max77826: Simplify max77826_i2c_probe()

 drivers/regulator/max77826-regulator.c | 20 +-------------------
 1 file changed, 1 insertion(+), 19 deletions(-)

-- 
2.46.0


             reply	other threads:[~2024-09-08 11:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-08 11:40 Christophe JAILLET [this message]
2024-09-08 11:40 ` [PATCH 1/2] regulator: max77826: Constify struct regulator_desc Christophe JAILLET
2024-09-09  7:48   ` Iskren Chernev
2024-09-08 11:40 ` [PATCH 2/2] regulator: max77826: Simplify max77826_i2c_probe() Christophe JAILLET
2024-09-09  7:50   ` Iskren Chernev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1725791361.git.christophe.jaillet@wanadoo.fr \
    --to=christophe.jaillet@wanadoo.fr \
    --cc=iskren.chernev@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®