From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F1C6732826F for ; Fri, 19 Dec 2025 12:46:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.176.79.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766148421; cv=none; b=QdtIfIyf/nkAUcfyCMQDhvXzmgM2lQiRzO0HCUCRzEwgJoWf2SzuH4wKbaclzeYcak9wkDiw4lOj0ErCK6ji6/kWQhEtX4HkIQxsVPHmNudz5MymMF0L3viwKDWN85j/z0fSB0QMr5ocR7Oq8BrOQvbKVGYNgi2gVIQtxLNjbXc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766148421; c=relaxed/simple; bh=U3vDf1TjO9SWyRc4v5lAO975DozRWSWRWoN2gk7DfSk=; h=From:To:CC:Subject:Date:Message-ID:MIME-Version:Content-Type; b=vAV4VyyFn9mnBll6HIXYEpo80HvW1sx3OxITsyGURp/4jtsla4nsMjKWa8cAA+VYgwQpOCcsoAiYrGPpkL8jLOT2PuPqp8lTYUVshiMWlWj7kr4elrK3ARNmrMSUA4Wo5ubbCNN70c7HTdfscuLHRVbVvhb7VltdTDG8M/zACbA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=h-partners.com; spf=pass smtp.mailfrom=h-partners.com; arc=none smtp.client-ip=185.176.79.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=h-partners.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=h-partners.com Received: from mail.maildlp.com (unknown [172.18.224.107]) by frasgout.his.huawei.com (SkyGuard) with ESMTPS id 4dXnN0384pzJ46cx; Fri, 19 Dec 2025 20:46:24 +0800 (CST) Received: from mscpeml500003.china.huawei.com (unknown [7.188.49.51]) by mail.maildlp.com (Postfix) with ESMTPS id 0C5C240576; Fri, 19 Dec 2025 20:46:57 +0800 (CST) Received: from mscphis00972.huawei.com (10.123.68.107) by mscpeml500003.china.huawei.com (7.188.49.51) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Fri, 19 Dec 2025 15:46:56 +0300 From: Gladyshev Ilya To: CC: , , , , , , , , , , , , , , , , , , , , , , , , , Subject: [RFC PATCH 0/2] mm: improve folio refcount scalability Date: Fri, 19 Dec 2025 12:46:37 +0000 Message-ID: X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: mscpeml500004.china.huawei.com (7.188.26.250) To mscpeml500003.china.huawei.com (7.188.49.51) Intro ===== This patch optimizes small file read performance and overall folio refcount scalability by refactoring page_ref_add_unless [core of folio_try_get]. This is alternative approach to previous attempts to fix small read performance by avoiding refcount bumps [1][2]. Overview ======== Current refcount implementation is using zero counter as locked (dead/frozen) state, which required CAS loop for increments to avoid temporary unlocks in try_get functions. These CAS loops became a serialization point for otherwise scalable and fast read side. Proposed implementation separates "locked" logic from the counting, allowing the use of optimistic fetch_add() instead of CAS. For more details, please refer to the commit message of the patch itself. Proposed logic maintains the same public API as before, including all existing memory barrier guarantees. Drawbacks ========= In theory, an optimistic fetch_add can overflow the atomic_t and reset the locked state. Currently, this is mitigated via a single CAS operation after the "failed" fetch_add, which tries to reset the counter to a locked zero. While this best-effort approach doesn't have any strong guarantees, it's unrealistic that there will be 2^31 highly contended try_get calls on a locked folio, and in each of these calls, the CAS operation will fail. If this guarantee isn't sufficient, it can be improved by performing a full CAS loop when the counter is approaching overflow. Performance =========== Performance was measured using a simple custom benchmark based on will-it-scale[3]. This benchmark spawns N pinned threads/processes that execute the following loop: `` char buf[] fd = open(/* same file in tmpfs */); while (true) { pread(fd, buf, /* read size = */ 64, /* offset = */0) } `` While this is a synthetic load, it does highlight existing issue and doesn't differ a lot from benchmarking in [2] patch. This benchmark measures operations per second in the inner loop and the results across all workers. Performance was tested on top of v6.15 kernel[4] on two platforms. Since threads and processes showed similar performance on both systems, only the thread results are provided below. The performance improvement scales linearly between the CPU counts shown. Platform 1: 2 x E5-2690 v3, 12C/12T each [disabled SMT] #threads | vanilla | patched | boost (%) 1 | 1343381 | 1344401 | +0.1 2 | 2186160 | 2455837 | +12.3 5 | 5277092 | 6108030 | +15.7 10 | 5858123 | 7506328 | +28.1 12 | 6484445 | 8137706 | +25.5 /* Cross socket NUMA */ 14 | 3145860 | 4247391 | +35.0 16 | 2350840 | 4262707 | +81.3 18 | 2378825 | 4121415 | +73.2 20 | 2438475 | 4683548 | +92.1 24 | 2325998 | 4529737 | +94.7 Platform 2: 2 x AMD EPYC 9654, 96C/192T each [enabled SMT] #threads | vanilla | patched | boost (%) 1 | 1077276 | 1081653 | +0.4 5 | 4286838 | 4682513 | +9.2 10 | 1698095 | 1902753 | +12.1 20 | 1662266 | 1921603 | +15.6 49 | 1486745 | 1828926 | +23.0 97 | 1617365 | 2052635 | +26.9 /* Cross socket NUMA */ 105 | 1368319 | 1798862 | +31.5 136 | 1008071 | 1393055 | +38.2 168 | 879332 | 1245210 | +41.6 /* SMT */ 193 | 905432 | 1294833 | +43.0 289 | 851988 | 1313110 | +54.1 353 | 771288 | 1347165 | +74.7 [1] https://lore.kernel.org/linux-mm/CAHk-=wj00-nGmXEkxY=-=Z_qP6kiGUziSFvxHJ9N-cLWry5zpA@mail.gmail.com/ [2] https://lore.kernel.org/linux-mm/20251017141536.577466-1-kirill@shutemov.name/ [3] https://github.com/antonblanchard/will-it-scale [4] There were no changes to page_ref.h between v6.15 and v6.18 or any significant performance changes on the read side in mm/filemap.c Gladyshev Ilya (2): mm: make ref_unless functions unless_zero only mm: implement page refcount locking via dedicated bit include/linux/mm.h | 2 +- include/linux/page-flags.h | 9 ++++++--- include/linux/page_ref.h | 35 ++++++++++++++++++++++++++--------- 3 files changed, 33 insertions(+), 13 deletions(-) -- 2.43.0