From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from MW6PR02CU001.outbound.protection.outlook.com (mail-westus2azon11012048.outbound.protection.outlook.com [52.101.48.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F14B3CBE6B for ; Tue, 26 May 2026 07:40:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.48.48 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779781246; cv=fail; b=Qjf9R3PmlfzEKOUJTM1u5munVybdj9zYfEhUPaoOFlsqxzh3a0TEAOC/D+KbFCq2G9KUxDdMsDDiSaUxh79gXV3xtLhqsZsX7/ge+tSfiI3mI5iClX3uwoYKjAGiu/ibssWXStuahrlxmfhQd9kHMk5thIY3+l8frXBjVvT/DMs= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779781246; c=relaxed/simple; bh=XbH8SEI0Mlvi2gw/bO+wwjZzYSOwep1oJaTQhBc4jLM=; h=From:To:Cc:Subject:Date:Message-ID:Content-Type:MIME-Version; b=ZsROqseEruVFnmYmEZ1AwTOK1r7j1mxd5A047g3Tz3/xN6QSGWIGFb6onGIJgef6WtJu+umrZ8RAzkcozPyYMizk7eRmeJkpovtN+75YYXYaXBXUEzsZiNqCBdpFRJE5DLf9CuxyJEXAnid7RF9BjtGnUEQLN/urxdACcgkOD30= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=altera.com; spf=pass smtp.mailfrom=altera.com; dkim=pass (2048-bit key) header.d=altera.com header.i=@altera.com header.b=oTOrzHVd; arc=fail smtp.client-ip=52.101.48.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=altera.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=altera.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=altera.com header.i=@altera.com header.b="oTOrzHVd" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=lG026PHM2dB5p3+GHSTQDxrAuugpZFlUQfLM0yg2gUcWJjQk1twzuRclqJszIQmT2ZbdirW5mlrIFc/lqxP4hGhdDUf9Pjm3vbnkK3kLyXz5pt6jS8dV3cXRE4GYIBe+XNn/hmlJCh4snSW5MKf1JE1FptehJ9g9vc+ApHnlMmEuTcZcq40TCPEGTswdhxDwLhc6PI3HCwo9j0Lw902fdn2cQDVXuK80+/w9qSf1e2fslBTQNBtufQSrrBHy6VySnRt5pIY/FLPt96wNuodKp/Y5ytgLjVpRuLF3UZAsnIo3U97HVJyi6rNG+kQhpL7xCh+SiKwRdRsxx20wyypo1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=j7nfZ7CJg53dlrsO3LNwvBwVpZWBNN8CQM9afyhbmIk=; b=G/oPOjmEg9bwDfB0ej34nlSvwmRJXGXE9QZVA10XAnKy7vzLO7E219yqhAbVeQBuCf52StyTuKGbHkoEsJCIXce4qpf0yEVFVSkx0ycQrxLnw78R48BqdCKtfibb5/Wuodj0df+EpAKCUua3JXFqTQClB1joeTruzhNiq7iq/0W4kExHdO2RG8kIEQ7BHd4j/WfRP91qCHmvndR5ZoyNfZz63QNM23TYsFR2aeZThmpWAxd9NF8FcWgfKONEriNHZ7L4J/ehmXxLJUiRGBgItE15h+bG5+rE+y7uCKwxd1aq7Lcs3PpEAIQ+GASX/pEZollYPR8umWBNVkSZtkZlkg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=altera.com; dmarc=pass action=none header.from=altera.com; dkim=pass header.d=altera.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=altera.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=j7nfZ7CJg53dlrsO3LNwvBwVpZWBNN8CQM9afyhbmIk=; b=oTOrzHVdUjMnmIPi4ZBzQy9dLC8HW58tt04+7SkRCeofA/u1TYqWNrF8GR1QJJPBOjqi538i3LQoIK/yGD8ci1NUkD5LBiQD4Gmy0dHWemhK1ua8MsUuJPJ4OT6y7T5mbi4un+mz+KKTmsyQw2G0rNEdMZUMH/6zpkdTylbIVaj+f8KuY5sCaXVNzuSOkMxwgD/vjRKY4qQ4EY5GlX6gcvw6pfqKHeonOYheyYCwvyyZdlJi8avhPeOpaKE6JbNrTtM7RTiwldRz7MsRSA8eWQhG420Bnyy/sS+SrYyHWdOZ77W4J4iHLeopmJCeTk61nznb3sJlhTgryLB9PK+YQg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=altera.com; Received: from DM8PR03MB6230.namprd03.prod.outlook.com (2603:10b6:8:3c::13) by PH7PR03MB6861.namprd03.prod.outlook.com (2603:10b6:510:15e::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.71.11; Tue, 26 May 2026 07:40:42 +0000 Received: from DM8PR03MB6230.namprd03.prod.outlook.com ([fe80::abad:9d80:7a13:9542]) by DM8PR03MB6230.namprd03.prod.outlook.com ([fe80::abad:9d80:7a13:9542%4]) with mapi id 15.21.0048.016; Tue, 26 May 2026 07:40:41 +0000 From: Adrian Ng Ho Yin To: Dinh Nguyen , linux-kernel@vger.kernel.org Cc: Adrian Ng Ho Yin Subject: [PATCH 0/2] firmware: stratix10-svc: fix kaddr dangling pointers and populate kaddr1 Date: Tue, 26 May 2026 15:35:11 +0800 Message-ID: X-Mailer: git-send-email 2.49.GIT Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: SJ0PR03CA0181.namprd03.prod.outlook.com (2603:10b6:a03:2ef::6) To DM8PR03MB6230.namprd03.prod.outlook.com (2603:10b6:8:3c::13) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM8PR03MB6230:EE_|PH7PR03MB6861:EE_ X-MS-Office365-Filtering-Correlation-Id: 771ab121-56a5-4ab5-8d3d-08debafa156c X-MS-Exchange-AtpMessageProperties: SA X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|55112099003|11063799006|18002099003|56012099003; X-Microsoft-Antispam-Message-Info: 26MsSL0LFcxejIDSlMndRIglvhYxDQBxEoXb+TNyAyHVvzGtys42T+iwvsl9oOtZcAkM8CcRNXBF+P7T+T27UzJkjglr9FwuPyLAK3g2EAtk/ic52+Xr4spz9g0jenTxCu/kmTJSGpQpDR77q7zdNTaXZ3ArHUN01L/8qt7bjU9TPbUsRKA77Y/AduX/VJCgt2ZFpG7RnuYYslc8SXWLv2bdiTLhJsoheFtkJy5Z4nDMqzgLGEpXibpELpg58dpfr0CcMZFn5gG9RZPpwyVzyXIfPqWWH1KLmqCZo0gg3VD50KU6tcIpryOHMnicbrtla9w/jrcZBykpgBhjWDpFfVDqGm5zmrz3qmtJnTmgVqc1VVwyn2xj6CUkPkFxpnNFAyvOyrjy21NEW9vGmQZICpoS87PiVBs//acHRh3OprDfWYH+V+p0qd1nODNHqzT+cy/NxyY5BNOdnblJcKMTGbnm6O/4v+TyvkRWxhtVpiVGhvyJogsSSvUcOuuT+xCJNL9Ww3kutShqdPXxfqQ6l2t9TASvBwxsLOe5cqvx+qYXi25QTtqHxY8VRoSUAGyvF2VHrpy98H6Y91YrXw2eBfyoltTXCMomgIm7taRIEiMULG6Uu9JYKPeY3on4B23k47x6TPUWte50B/GAEpxceY7NNEmBnzfJsOYvrF6uEcbXZN2SI3QtKa8f4HRFQbsq X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM8PR03MB6230.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(55112099003)(11063799006)(18002099003)(56012099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?vjz6aa4hMk927IFzeBctLl3ULdETVzZee4L0qQjOH07RG7WBgYgz5afhOdFX?= =?us-ascii?Q?Y+gjG+fPiN/JVxIxGdAXn2KOeYJaqmXvlhi4meb7ppJOp537qKTwsSJGEO3c?= =?us-ascii?Q?1Gd6levv08vpy+alTLmxDJUAK5QI9tKYHi7m9F328TYf/9GWouPOSPXfmTSB?= =?us-ascii?Q?m8KdaBhrf6kDxi+UGqQgbdPS50EmQDGYNcnkFvXl2IUPKXJj1Ue20i1gNus3?= =?us-ascii?Q?zKthiPBgOZ/clGkRVBNSKfWdL0VwodoahTtAdYo7qJ03TMr0LuEKXDMT15Hp?= =?us-ascii?Q?0Yn5TzIHb78ARf0EtJzBlkLb8INx7XtqQ6OH8aJWvp6cdJHIz5T085Pa4WAb?= =?us-ascii?Q?UIi9r6xe+6xX1oUKoqA7Y6v1qAlUn06kn2wd1f9oFqO+xgTIFv190N1oAkB7?= =?us-ascii?Q?2ioD53/h78T8lAjeCRBHJ8wJk9ILQ9HH9BqWgq0D2Vee4gXyc2kLJC8cKD7G?= =?us-ascii?Q?CBRzib+d51tEghhoO5jxfiRvtRavK54BGGSeXIqMGihc6G45ilb5eMhba7os?= =?us-ascii?Q?DvY4J82A76k+a/Ru8ubWZH1S78oesidCyXZcILhlybr8pEIXZC04OBt5ANfi?= =?us-ascii?Q?IedVAPJpoVX9XgDWmsYY4fYEcFBMyhAnxeX9hd4dokOp/rYrjQbqhTAqyzEa?= =?us-ascii?Q?3usChBFPVwymQBMwCj7mFKDVQ+sSt8WXOWvNuBuPanwujcOY5UdC1thxyPaC?= =?us-ascii?Q?G9Rl6EiIGb4v8tYs+bcjC7suSZVUkWFJgE9m0Qpvt2gO+BdmbsZP1TzsFNu8?= =?us-ascii?Q?kwPm4mctum1pugKHiXhBgrgFLz53GDmdyofLg0i2Qr9U/OvlcvXgiCEcFOWE?= =?us-ascii?Q?tuUi87xvW0uNJaOef6LG2Ni4fxWdBWZZMKImI+oCoIO5+ryhLOTHpQw/Gp1M?= =?us-ascii?Q?MBbEyi2q7MYgqt4CG/nWpL9IvhHEfrTZ8YNasrGqrMM6ob17KFJ9Wqpz9Duq?= =?us-ascii?Q?yxf7lVT//PwOU1cdqB1c7jHgRHjJ87le9NyU/3bStAXQcSQdDFr446DWQrzU?= =?us-ascii?Q?FATUc3hYUrdfnY8YuY8MhftsNTQVZl4Odu2O6nA4cVOWIGOg24F3FrzQ7ben?= =?us-ascii?Q?FC2D2BsBPf6cqofaJX240be0TAZdpFb/U+zvLpKl36XA/2Ix+TGXYYMpUsdl?= =?us-ascii?Q?lbpdSvTXjgPL+/I11R3FK5a3nqSe1WBXWytoXNIh6K4S/mOZbY2u2zTO0bfM?= =?us-ascii?Q?n3bzobiSVuii6LCYmbSCoUuKs3eE08+HhRSDPZwF4xcj4PRN5lsYZc76SQGk?= =?us-ascii?Q?xR7dqmF3uPPKbgL2APQ/stxNFj0qPaRnn4kETN5/aSFrCXonK6HRquBh32Ct?= =?us-ascii?Q?IClUhjCsmrkVetWul5Nvxl5Lu4n2+dCFZJ/JRqTjtW8oGu1szRNiVSJA9IJ0?= =?us-ascii?Q?Q85Z1gdmQwSbbk+ZJwnopgnJ9Vj6E3C6N2PSBBrp8wsojoVRo8xfB1fNSc32?= =?us-ascii?Q?FlgIkWsbuoNIaI5cnyVcfwJhxzFj1opk8iLn4vXRxyZFCF49vdQAVwbT937b?= =?us-ascii?Q?vCuLJ0qT0D4nDdNnY7Q8zlqyI2IJQg2xSeNMUBANCCCM+2rnATOeAM0PaRO+?= =?us-ascii?Q?iw04nc299KbpEiJRzzsSmqJThoe25ScsJrn1X4ngyglwG+xwnpRJw49b1RVQ?= =?us-ascii?Q?Ju8UtyKw+wrUlxvxrtkQ6+83XTfeealS4GyVATXtZ3tb36uiMK8mOrM+CnBs?= =?us-ascii?Q?E+5RK01po1YV1C+bB2V5YOu2y1kINGTgf4VmmI+wT+jlFCmheDDqQc8dxwlM?= =?us-ascii?Q?6y6ZxCz+6VedkCIJTLwnbMXwkUYfhyw=3D?= X-OriginatorOrg: altera.com X-MS-Exchange-CrossTenant-Network-Message-Id: 771ab121-56a5-4ab5-8d3d-08debafa156c X-MS-Exchange-CrossTenant-AuthSource: DM8PR03MB6230.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 May 2026 07:40:41.8147 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fbd72e03-d4a5-4110-adce-614d51f2077a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QlfZBnrsGKbc6gy1PQ59f+zu+nK3fJlk9znEmOJt12IiumivkHWpK9eg76KIODwOz1ShV9mAa2IkzG+csa3345F+3kLWjw0KCNSKZLGTpD8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR03MB6861 kaddr1/2/3 in the stratix10 service layer are set to addresses of local arm_smccc_res fields that go out of scope when the setting function returns, leaving dangling pointers in the callback data. Patch 1 fixes this by adding a1/a2/a3 scratch fields to struct stratix10_svc_cb_data, which lives for the SVC thread lifetime, and pointing kaddrN to those fields instead of the stack. Patch 2 uses the same mechanism to populate the previously unset kaddr1 in svc_thread_cmd_config_status(), exposing firmware status details to callers. Adrian Ng Ho Yin (2): firmware: stratix10-svc: fix dangling kaddr pointers in callback data firmware: stratix10-svc: populate kaddr1 from config status response drivers/firmware/stratix10-svc.c | 45 ++++++++++++------- .../firmware/intel/stratix10-svc-client.h | 17 +++++++ 2 files changed, 47 insertions(+), 15 deletions(-) -- 2.49.GIT