mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Uwe Kleine-König (The Capable Hub)" <u.kleine-koenig@baylibre.com>
To: Arnd Bergmann <arnd@arndb.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH v1 0/3] misc: pch_phub: Fix fallout and more cleanup
Date: Tue, 26 May 2026 10:52:06 +0200	[thread overview]
Message-ID: <cover.1779785111.git.u.kleine-koenig@baylibre.com> (raw)

Hello,

Sashiko found a relevant issue in the patch that became 7b1d4ad96ea4
("misc: pch_phub: Introduce an enum for device indentification"). This
is fixed in the first patch.

The second patch is a follow-up to commit d14b649fd99f ("misc: pch_phub:
Drop two unused functions") that drops now unused struct members.

The third patch fixes an inconsistency in device handling. The comment
suggest that ML7213 isn't handled, the code just falls back in the else
branch for it. Make variant handling more explicit using a switch
statement. If a new device is added without adapting
pch_phub_write_gbe_mac_addr() a compiler warning is triggered.

Best regards
Uwe

Uwe Kleine-König (The Capable Hub) (3):
  misc: pch_phub: Complete enum usage for device identification
  misc: pch_phub: Drop unused members from struct pch_phub_reg
  misc: pch_phub: Make MAC address configuration more robust

 drivers/misc/pch_phub.c | 59 ++++++++++++++---------------------------
 1 file changed, 20 insertions(+), 39 deletions(-)


base-commit: 7b1d4ad96ea47b3275328fa385d0497e164f1f5f
-- 
2.47.3


             reply	other threads:[~2026-05-26  8:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-26  8:52 Uwe Kleine-König (The Capable Hub) [this message]
2026-05-26  8:52 ` [PATCH v1 1/3] misc: pch_phub: Complete enum usage for device identification Uwe Kleine-König (The Capable Hub)
2026-05-26  8:52 ` [PATCH v1 2/3] misc: pch_phub: Drop unused members from struct pch_phub_reg Uwe Kleine-König (The Capable Hub)
2026-05-26  8:52 ` [PATCH v1 3/3] misc: pch_phub: Make MAC address configuration more robust Uwe Kleine-König (The Capable Hub)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1779785111.git.u.kleine-koenig@baylibre.com \
    --to=u.kleine-koenig@baylibre.com \
    --cc=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®