From: Arnaud Bonnet <abo@medichon.fr>
To: trondmy@kernel.org, anna@kernel.org
Cc: linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org,
code@agatha.dev, skhan@linuxfoundation.org,
me@brighamcampbell.com, jkoolstra@xs4all.nl,
Arnaud Bonnet <abo@medichon.fr>
Subject: [PATCH 0/2] nfs: refactor bit operations using clear_and_wake_up_bit
Date: Mon, 22 Jun 2026 19:55:09 +0200 [thread overview]
Message-ID: <cover.1782148639.git.abo@medichon.fr> (raw)
Several functions in nfs code use the exact following sequence of calls
when dealing with flags:
clear_bit_unlock();
smp_mb__after_atomic();
wake_up_bit();
Since commit 8236b0ae31c8 ("bdi: wake up concurrent wb_shutdown()
callers.") came the helper clear_and_wake_up_bit() for this exact
purpose, and has since been adopted by several subsystems, including
vfs.
This function is already used in files such as nfs4state.c and
pnfs_nfs.c and this serie aims to continue this effort, which also
allows to remove some no longer used code.
Tested on x86 hardware using a loopback pNFS SCSI layout:
* doing image compression/decompression using xz and
* recompiling tinyconfig kernels on the remounted partition
No error reported under sanitizers.
Suggested-by: Agatha Isabelle Moreira <code@agatha.dev>
Link: https://kernelnewbies.org/Beginner%20Cleanup%20and%20Refactor%20Tasks%20by%20Agatha%20Isabelle%20Moreira#task_007
Signed-off-by: Arnaud Bonnet <abo@medichon.fr>
---
Arnaud Bonnet (2):
nfs: replace atomic bitops sequence with clear_and_wake_up_bit helper
nfs: refactor pNFS functions using clear_and_wake_up_bit
fs/nfs/inode.c | 4 +---
fs/nfs/pnfs.c | 35 ++++++++++-------------------------
2 files changed, 11 insertions(+), 28 deletions(-)
--
2.53.0
next reply other threads:[~2026-06-22 19:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-22 17:55 Arnaud Bonnet [this message]
2026-06-22 17:55 ` [PATCH 1/2] nfs: replace atomic bitops sequence with clear_and_wake_up_bit helper Arnaud Bonnet
2026-06-22 17:55 ` [PATCH 2/2] nfs: refactor pNFS functions using clear_and_wake_up_bit Arnaud Bonnet
2026-07-03 20:55 ` Agatha Isabelle Moreira
2026-07-08 9:45 ` Arnaud Bonnet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1782148639.git.abo@medichon.fr \
--to=abo@medichon.fr \
--cc=anna@kernel.org \
--cc=code@agatha.dev \
--cc=jkoolstra@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=me@brighamcampbell.com \
--cc=skhan@linuxfoundation.org \
--cc=trondmy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox