From: Adrian Ng Ho Yin <adrian.ho.yin.ng@altera.com>
To: Dinh Nguyen <dinguyen@kernel.org>, linux-kernel@vger.kernel.org
Cc: tze.yee.ng@altera.com, Adrian Ng Ho Yin <adrian.ho.yin.ng@altera.com>
Subject: [PATCH v2 0/2] firmware: stratix10-svc: async and teardown fixes
Date: Tue, 14 Jul 2026 13:37:45 +0800 [thread overview]
Message-ID: <cover.1784007275.git.adrian.ho.yin.ng@altera.com> (raw)
This series addresses two issues in the stratix10 service layer's
asynchronous transaction handling.
Patch 1 adds INTEL_SIP_SMC_STATUS_NO_RESPONSE (0x3) to the SMC status
definitions and handles it in stratix10_svc_async_poll() alongside
INTEL_SIP_SMC_STATUS_BUSY. Both statuses indicate the Secure Device
Manager has not yet produced a response and should cause callers to
retry rather than treating the poll as a hard failure. Without this,
the unrecognised status code falls through to the error path and is
mapped to -EINVAL, making "not ready yet" indistinguishable from a
real error.
Patch 2 fixes the teardown ordering in stratix10_svc_drv_remove()
reported by sashiko (https://lore.kernel.org/all/cd6460b2-7f53-4ac6-8f68-172e7853f63f@kernel.org/).
Previously, stratix10_svc_async_exit() was called before client
devices were unregistered, leaving a window where child devices could
issue service requests after the async infrastructure had already been
destroyed. The fix unregisters client devices first so all in-flight
calls drain before the underlying channels and threads are torn down.
---
changelog:
v1->v2:
* update commit message to include Fixes tag and Cc: stable@vger.kernel.org.
---
Adrian Ng Ho Yin (2):
firmware: stratix10-svc: handle NO_RESPONSE in async poll
firmware: stratix10-svc: fix teardown order in remove to prevent race
drivers/firmware/stratix10-svc.c | 9 +++++----
include/linux/firmware/intel/stratix10-smc.h | 4 ++++
2 files changed, 9 insertions(+), 4 deletions(-)
--
2.49.GIT
next reply other threads:[~2026-07-14 5:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-14 5:37 Adrian Ng Ho Yin [this message]
2026-07-14 5:37 ` [PATCH v2 1/2] firmware: stratix10-svc: handle NO_RESPONSE in async poll Adrian Ng Ho Yin
2026-07-14 5:37 ` [PATCH v2 2/2] firmware: stratix10-svc: fix teardown order in remove to prevent race Adrian Ng Ho Yin
2026-07-14 22:26 ` [PATCH v2 0/2] firmware: stratix10-svc: async and teardown fixes Dinh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1784007275.git.adrian.ho.yin.ng@altera.com \
--to=adrian.ho.yin.ng@altera.com \
--cc=dinguyen@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tze.yee.ng@altera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome