From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6AC41377EBC for ; Wed, 12 Aug 2026 14:46:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786545971; cv=none; b=Gf1z6D+vJhgN0xsCI52cAJEwF98NjV8TNc5fmqkwpSQR4ISg7utFonR7OkEdGOWoEm+nhiwCJl8A46rgXHpNeXmIWb8f01LU6RvCzJchlH3GIIXe/NduPS4NGTKgQNDkdZYE0ipOqQ9jkHC7rPuKTgwAieyBRSWMBM2Gum/ORGw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786545971; c=relaxed/simple; bh=cFqGG+1MzXWnp4RB9sSPNS0z7zmYPd2l9Kb59YR2vtw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=V72pR5Gco4fM4xpKhYjM39TIWLQwmQ3XMkRa3BK65PbafS19zVcIyPCGsJcQ4s1XKQxSNMN7OIJsifRY7RuB6KfrvO5HFxsBVuU7rIWKTdy31hcRndN+yd9ZjBMPgNPfRAKHEhwLGIBDZOwep8p0PNI48ZuTdb4Auwm1XmOsKvY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EffaJWcA; arc=none smtp.client-ip=209.85.167.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EffaJWcA" Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-5b01cb18515so975646e87.2 for ; Wed, 12 Aug 2026 07:46:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786545968; x=1787150768; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=o/XYikGcJLG4ug//+sYZHF8ixfSnZ+jEXi7zvDeMcXw=; b=EffaJWcA4gj5g6KFE1XpkhWaVFrdBMT1+RL54b+f98075KO6ELK3cH5LD0kNVpPfoU cA49m4iNYFsonWXc7wuCnlmXv3PYgAj1nSModYNjKj4ppoUnr9Wpq8OspzkbFKGROmBB T+0ExIWR+agicFkfy0yG9Ok8J65z93AxtI0W0+nEBEgXCQvF2c6zr4y7jMRrR3spvl5u EnNRBCc5TwHHpjHt21JhYZJJHSfdBdk9jBQp3+aUvywvP8qoC6ZPS/WHhNadeUHUBuEP u4FErafrRkI5FiBNugpfPkPx5hNn9LenFVbPN/arTDjQwT34olAZuroN/0uqOjjzqsl0 2Q2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786545968; x=1787150768; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=o/XYikGcJLG4ug//+sYZHF8ixfSnZ+jEXi7zvDeMcXw=; b=H3bTAGXKvV2h4FhIM7MMOYa4xYTUct16rEDjeo5R2JwiIIDuqZVIF7y9JKFAks7cKw +0HJ7ZS0LU5+0yztJFEv2js0MgKr8mxcbIC1zuHT/rrpYj/C7oUYs9MFsMpZgirY+wlo s8MJFlOtOLpeLRSWaJDl603G/RN5bjM2isBh1Zij8AxUHTAn4YGK2P2UMvNPqKSuAcR4 SIvGKSfRNvuKMjOaYXXok0i0Ll/FNoU5MRCD1Nv0iejkmBh9Xp1qtvn6tdrz9jkJRpyo 7aiHMw3lJr9GcLE6uk39td37p5p7BgdmU5vIau4MiFUHiVlRC778B+Q8s/uvktktjBUy kC1A== X-Forwarded-Encrypted: i=1; AHgh+Rqecl/00nwMMg0PUA6uvIkAfBqsvwGJuOA51QggRK8TZebI2dZpmCeW+P6K81usRSGVbZS11NGimCV0KcE=@vger.kernel.org X-Gm-Message-State: AOJu0YwifBw6j/rzp8en4F5fY4U1LJuOMOdRnz9/lzxSI8ncOK1oYVLM qeJe+bE74hjNnx4BerJbVlsrXXosMkbGTytF6mfQQoHQ72HQafqZBAhG X-Gm-Gg: AR+sD11WndWf+400Dn057KEDObRip8IDJHoIDaeh1eT15tVyJ4EFvjbbdwej6NwJPhX ap0vPTD6b9CMuhcefSiiTDHH4Atj0y/EVoj15X+TIXRz9DQlUQsz6uMnm+JVMiJYfr+0/Z9Bi7I 1iTiqEmvQP/CFA5utikbWYfLAnj0d1Mz4T4DSRvOQnfEL4wiyL+OWcwdo/TKrm7P++KIU8VXw4R /chU5B4ntg8Ed6JIbOV49uN7EjGKjqAyOooeK4EVIKe6on2a9GMrhlord6M8oF0wE2b4oLU+wKN mQ2hUmVEbACzA16X1zOdtglS0YkJJZlwJ1AZtkoMAKqQIjOdZdeJv/QhCyjXLtH9luDd9R2CxyA nj7yRuEw/q2eJEtm/usyf4MNpiIEnemhOv1VtzylTZ7c+w7VvoZspRo3OyMaHXlukZ7BNPzvrmo xNiRlo82p5oKrz6aYwLuJByA0ezYnxZRcBg/P4ov+OKAQhafBehEol2EGAEENFoy8ibQSVHISEW YWyKNgLp/IEDgCMPiQWhHI6/EvkufpggNLH74yd5lncUeikykG/PrFFoviqQWEDmzUZ9EYdQw== X-Received: by 2002:ac2:43cd:0:b0:5b2:add9:d073 with SMTP id 2adb3069b0e04-5b44e31efc5mr671915e87.46.1786545968119; Wed, 12 Aug 2026 07:46:08 -0700 (PDT) Received: from archlinux ([94.180.96.85]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5b44cfc27besm552179e87.21.2026.08.12.07.46.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2026 07:46:07 -0700 (PDT) From: Arsenii Pashchenko To: pkshih@realtek.com Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Arsenii Pashchenko Subject: [PATCH 0/4] wifi: rtw88: rtw8822c: refactor DAC IQ calibration to s32 Date: Wed, 12 Aug 2026 21:45:42 +0700 Message-ID: X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This series refactors the Digital-to-Analog Converter (DAC) IQ calibration routines in the rtw8822c driver. The original code heavily relies on unsigned 32-bit math mapped over a 10-bit circular hardware register scale centered around 0x200. This introduces complex nested boundary checks, custom bubble sort rules, and custom min/max tracking helpers. By migrating the temporary stack arrays and signatures to signed s32 and utilizing the kernel's sign_extend32() API, the coordination system is linearized. This allows the removal of internal custom helpers and collapses unsigned wrap-around logic into standard linear operations. The series is broken down as follows: Patch 1: Prepares signatures and stack buffers, converting types to s32. Patch 2: Introduces sign_extend32() and simplifies the validation window. Patch 3: Replaces custom bubble sort with the kernel's native sort(). Patch 4: Eliminates minmax_cmp, streamlining search and offset loops. AI Disclosure: An AI assistant was used for source code analysis and conceptual consultation regarding the signed math transformation. All code modifications, final implementations, and refactoring steps were written, reviewed, and verified manually by the author. Testing: - Every patch in the series was verified with scripts/checkpatch.pl and yielded 0 errors and 0 warnings. - Each patch was sequentially built (bisected and compiled) to ensure there are no compiler warnings, pointer type mismatches, or broken builds at any intermediate step. Arsenii Pashchenko (4): wifi: rtw88: rtw8822c: convert DAC IQ buffers and signatures to s32 wifi: rtw88: rtw8822c: use sign_extend32 for DAC IQ validation wifi: rtw88: rtw8822c: switch to the kernel's sort() library wifi: rtw88: rtw8822c: simplify amplitude search and offset via s32 drivers/net/wireless/realtek/rtw88/rtw8822c.c | 146 ++++++------------ 1 file changed, 43 insertions(+), 103 deletions(-) -- 2.55.0