From: Yehyeong Lee <yhlee@isslab.korea.ac.kr>
To: Alexander Duyck <alexanderduyck@fb.com>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org
Cc: kernel-team@meta.com, Andrew Lunn <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Dimitri Daskalakis <daskald@meta.com>,
Mohsin Bashir <mohsin.bashr@gmail.com>,
Bobby Eshleman <bobbyeshleman@meta.com>,
stable@vger.kernel.org, linux-kernel@vger.kernel.org,
Yehyeong Lee <yhlee@isslab.korea.ac.kr>
Subject: [PATCH net v2 0/2] eth: fbnic: validate the Rx completion path
Date: Sun, 11 Oct 2026 04:26:48 +0900 [thread overview]
Message-ID: <cover.1791659860.git.yhlee@isslab.korea.ac.kr> (raw)
Patch 1 is v2 of "eth: fbnic: validate the Rx completion buffer index".
Besides bounding the completion buffer index against rx_buf[], it now
also rejects a buffer-descriptor-queue clean-up head that falls outside
the ring in fbnic_clean_bdq(), and sets add_frag_failed when
fbnic_add_rx_frag() bails on a buffer that was never set up. Both were
raised in review of v1:
https://lore.kernel.org/netdev/20261009175358.1598001-1-yhlee@isslab.korea.ac.kr/
Patch 2 returns a page-pool reference that is leaked on the
fragment-overflow path of the same function, found while auditing
patch 1. It carries a different Fixes tag, so it is a separate patch.
v2:
- patch 1: also reject an out-of-range clean-up head in
fbnic_clean_bdq(), and set add_frag_failed in fbnic_add_rx_frag()'s
no-buffer bail.
- patch 2: new.
Yehyeong Lee (2):
eth: fbnic: validate the Rx completion buffer index
eth: fbnic: return the page reference taken for a dropped Rx fragment
drivers/net/ethernet/meta/fbnic/fbnic_txrx.c | 40 +++++++++++++++++++-
1 file changed, 38 insertions(+), 2 deletions(-)
--
2.43.0
next reply other threads:[~2026-10-10 19:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-10 19:26 Yehyeong Lee [this message]
2026-10-10 19:26 ` [PATCH net v2 1/2] eth: fbnic: validate the Rx completion buffer index Yehyeong Lee
2026-10-10 19:26 ` [PATCH net v2 2/2] eth: fbnic: return the page reference taken for a dropped Rx fragment Yehyeong Lee
2026-10-10 19:30 ` [PATCH net v2 0/2] eth: fbnic: validate the Rx completion path netdev-bot+sinfo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1791659860.git.yhlee@isslab.korea.ac.kr \
--to=yhlee@isslab.korea.ac.kr \
--cc=alexanderduyck@fb.com \
--cc=andrew+netdev@lunn.ch \
--cc=bobbyeshleman@meta.com \
--cc=daskald@meta.com \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=horms@kernel.org \
--cc=kernel-team@meta.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mohsin.bashr@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®