From: Ivy Lopez <skunkolee@gmail.com>
To: akpm@linux-foundation.org
Cc: david@kernel.org, ljs@kernel.org, liam@infradead.org,
vbabka@kernel.org, rppt@kernel.org, surenb@google.com,
mhocko@suse.com, fvdl@google.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, Ivy Lopez <skunkolee@gmail.com>
Subject: [PATCH v2 0/2] mm/cma: fix range selection in cma_declare_contiguous_multi()
Date: Wed, 14 Oct 2026 20:53:39 -0600 [thread overview]
Message-ID: <cover.1792032699.git.skunkolee@gmail.com> (raw)
These two patches fix two independent bugs in the multi-range selection
of cma_declare_contiguous_multi(), found by code inspection with the
help of an LLM (both patches carry Assisted-by: LLM).
Patch 1 fixes list_insert_sorted(), which does not actually sort: it
stops at the wrong entry and, when no entry matches, inserts before the
last entry instead of appending. The caller assumes the list tail is the
smallest recorded range and that the list is walked largest first.
Patch 2 fixes sizesum counting the size of ranges that were skipped
because the list was full, so the sizesum < total_size check can pass
when the recorded ranges cannot cover the request, and the function
returns 0 having reserved less than asked for.
Each patch fixes a distinct failure and neither depends on the other.
No kernel-level reproducer was produced and nothing was tested beyond
compiling; the examples in the commit messages come from a userspace
copy of the helper and the selection loop, written from the source.
Changes in v2:
- resend as a series with a cover letter, as requested by Lorenzo
- commit messages now state how the bugs were found and that they were
not tested on hardware or in a booted kernel
- add Assisted-by: LLM
- patch 1: correct the sentence about the first inserted range staying
at the tail (only until it is evicted)
- rebased on the current akpm/mm-new
- no code changes
v1: https://lore.kernel.org/all/20261011003059.169430-1-skunkolee@gmail.com/
Ivy Lopez (2):
mm/cma: fix list_insert_sorted() ordering
mm/cma: do not count skipped ranges in cma_declare_contiguous_multi()
mm/cma.c | 16 ++++++----------
1 file changed, 6 insertions(+), 10 deletions(-)
--
2.56.0
next reply other threads:[~2026-10-15 2:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-15 2:53 Ivy Lopez [this message]
2026-10-15 2:53 ` [PATCH v2 1/2] mm/cma: fix list_insert_sorted() ordering Ivy Lopez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1792032699.git.skunkolee@gmail.com \
--to=skunkolee@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=david@kernel.org \
--cc=fvdl@google.com \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=rppt@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®