mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrei Rusu de Castro <arc@empyreal.works>
To: amd-gfx@lists.freedesktop.org
Cc: harry.wentland@amd.com, sunpeng.li@amd.com, siqueira@igalia.com,
	alexander.deucher@amd.com, christian.koenig@amd.com,
	airlied@gmail.com, simona@ffwll.ch, alex.hung@amd.com,
	roman.li@amd.com, mario.limonciello@amd.com,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	chen-yu.chen@amd.com, ray.wu@amd.com
Subject: [PATCH v3 0/2] drm/amd/display: keep custom brightness curve in userspace domain
Date: Sat, 24 Oct 2026 01:33:30 +0000	[thread overview]
Message-ID: <cover.1792805565.git.arc@empyreal.works> (raw)
In-Reply-To: <cover.1788388049.git.arc@empyreal.works>

convert_custom_brightness() adds the firmware minimum before
convert_brightness_from_user() applies it again, so a zero request
through a custom curve never reaches the panel minimum. Patch 1 keeps
the curve output in the userspace domain. Patch 2 adds KUnit coverage
with a non-zero firmware minimum.

Changes in v3:

- rebase onto amd-staging-drm-next (77f548b12);
- drop v2 patches 3 and 4, which changed the PWM path to the power
  module; "drm/amd/display: map PWM brightness through custom backlight
  curve" has since reworked that path;
- describe which panels still reach the helper: AUX panels with a custom
  curve, and PWM panels on stable kernels before the power module.

The amdgpu_dm KUnit suites were run under UML on this base with and
without the series: 1897 and 1906 cases, all passing; the backlight
suite goes from 70 to 79 cases. The rebase and the test runs were
LLM-assisted.

v2: https://lore.kernel.org/r/cover.1788388049.git.arc@empyreal.works

Andrei Rusu de Castro (2):
  drm/amd/display: keep custom brightness curve in userspace domain
  drm/amd/display: test custom brightness with non-zero minimum

 .../display/amdgpu_dm/amdgpu_dm_backlight.c   |  13 +-
 .../display/amdgpu_dm/amdgpu_dm_backlight.h   |   3 +-
 .../tests/amdgpu_dm_backlight_test.c          | 294 +++++++++++++++++-
 3 files changed, 286 insertions(+), 24 deletions(-)


base-commit: 77f548b127c6de34ce271fa09ba270cb1ef9f2da
-- 
2.56.0



  parent reply	other threads:[~2026-10-24  1:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-02 12:31 [PATCH 0/4] drm/amd/display: fix brightness ownership through power module Andrei Rusu de Castro
2026-09-02 12:31 ` [PATCH 1/4] drm/amd/display: keep custom brightness curve in userspace domain Andrei Rusu de Castro
2026-09-02 12:31 ` [PATCH 2/4] drm/amd/display: test custom brightness with non-zero minimum Andrei Rusu de Castro
2026-09-02 12:32 ` [PATCH 3/4] drm/amd/display: pass userspace brightness to power module Andrei Rusu de Castro
2026-09-02 12:33 ` [PATCH 4/4] drm/amd/display: test power module brightness input domain Andrei Rusu de Castro
     [not found] ` <cover.1788388049.git.arc@empyreal.works>
     [not found]   ` <8ec5dc8922407924f771d353cb7f2dd1846553ae.1788388049.git.arc@empyreal.works>
2026-10-12 20:06     ` [PATCH v2 1/4] drm/amd/display: keep custom brightness curve in userspace domain Mario Limonciello
2026-10-24  1:33       ` Andrei Rusu de Castro
2026-10-24  1:33   ` Andrei Rusu de Castro [this message]
2026-10-24  1:33     ` [PATCH v3 1/2] " Andrei Rusu de Castro
2026-10-24  1:33     ` [PATCH v3 2/2] drm/amd/display: test custom brightness with non-zero minimum Andrei Rusu de Castro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1792805565.git.arc@empyreal.works \
    --to=arc@empyreal.works \
    --cc=airlied@gmail.com \
    --cc=alex.hung@amd.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=chen-yu.chen@amd.com \
    --cc=christian.koenig@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=harry.wentland@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mario.limonciello@amd.com \
    --cc=ray.wu@amd.com \
    --cc=roman.li@amd.com \
    --cc=simona@ffwll.ch \
    --cc=siqueira@igalia.com \
    --cc=sunpeng.li@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®