mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: wen.yang@linux.dev
To: Joel Granados <joel.granados@kernel.org>,
	David Laight <david.laight.linux@gmail.com>,
	Kees Cook <kees@kernel.org>
Cc: Wen Yang <wen.yang@linux.dev>,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [RFC PATCH v2 0/6] sysctl: replace overloaded extra pointers with typed bounds and core stride
Date: Tue, 17 Nov 2026 00:07:32 +0800	[thread overview]
Message-ID: <cover.1794844686.git.wen.yang@linux.dev> (raw)

From: Wen Yang <wen.yang@linux.dev>

struct ctl_table has long relied on extra1 and extra2 pointers to serve
multiple unrelated duties, including range limits and caller-specific
context.  This series addresses both:

1. Replace bound pointers with plain unsigned long min and max fields
   directly in struct ctl_table.

2. Replace per-entry context pointers with a core stride mechanism,
   allowing callers to register arrays of structures embedding struct
   ctl_table and recover enclosing context via standard container_of().

This RFC focuses on the core stride infrastructure and two representative
complex users (netfilter nf_log and IPv4 devinet), as suggested by Joel
Granados.  The remaining treewide callers are converted in a single
squashed commit to ensure the tree builds and tests pass cleanly.

Changes from v1:
=================
v1: https://lore.kernel.org/all/cover.1793204511.git.wen.yang@linux.dev/

1. Abandoned per-entry 'void *priv' (David Laight):
   - v1 added 'priv' to struct ctl_table, incurring 8 bytes on 64-bit and
     4 bytes on 32-bit for all ~1,000 entries across thousands of dynamic
     instances, even though <7% of entries need context.
   - Refactor: context lives outside struct ctl_table via core stride;
     callers embed ctl_table at offset 0 of their own record and recover
     context with standard container_of().
   - Cost: zero growth in struct ctl_table (56/32 bytes) and zero growth
     in struct ctl_table_header (88/52 bytes, packing u16 stride and type).

2. Eliminated slot wrappers & index coupling (Joel Granados, David Laight):
   - An intermediate prototype discussed on the list used slot-indexed
     container recovery, requiring 32 wrapper functions in devinet and 11
     in nf_log.
   - Refactor: with core stride, the core passes the exact registered
     entry pointer to the handler, so handlers use container_of() directly
     and all 43 wrappers disappear without touching proc_handler
     signatures.

3. KUnit purity & dependency fix (0-day robot):
   - Removed register_sysctl() calls from KUnit; tests invoke
     proc_handler directly so no live /proc/sys nodes are modified.
   - Added 'depends on SYSCTL' to SYSCTL_KUNIT_TEST in lib/Kconfig.debug,
     fixing undefined symbols when built as a module with SYSCTL=n.

4. Baseline rebase & conflict resolution:
   - Rebased onto next-20261111 (aaa2f954c21b).
   - Added proc_dointvec_jiffies_minmax and proc_dointvec_ms_jiffies_minmax
     to sysctl_check_table().

5. Added Coccinelle verification script (Joel Granados):
   - A 17-rule script (patch and context modes) maps all 15 SYSCTL_*
     constants through one lookup table instead of repeating two rules
     per constant.
   - Bounds that point at a variable (&foo_min, &foo_max) are left
     untouched and reported: in several callers (power/main.c, i915_perf,
     ipc_sysctl, pid, sched/rt, rds, xprtsock) that variable is updated
     at boot or at run time, so inlining its initial value would silently
     freeze a live bound.  The script also flags .min/.max fields holding
     a pointer or a legacy macro.

6. Streamlined RFC series layout (Joel Granados):
   - Reduced from 39 patches in v1 to 6 focused patches (core
     infrastructure, unit test, two complex stride consumers, coccinelle
     script.

Key Design Points:
==================

1. Zero Memory Growth:
   - struct ctl_table keeps its exact size (56 bytes on 64-bit, 32 bytes on
     32-bit). No 'priv' field is added.
   - u16 ctl_table_stride is introduced into struct ctl_table_header.
     Together with u16 type, it occupies the existing alignment padding
     hole on 64-bit (88 bytes unchanged) and keeps 52 bytes on 32-bit.
     Registration rejects stride values that exceed U16_MAX.
   - Headers are allocated once per table registration (~240 sites
     in-tree), not per entry (thousands in-tree).

2. Eliminates some Wrapper Functions:
   - net/ipv4 devinet: registers strided struct devinet_sysctl_entry,
     eliminating 32 per-attribute wrapper functions.
   - Handlers recover their context using standard container_of() without
     changing any proc_handler signatures.

3. Standalone Stride API vs. Existing _sz:
   register_sysctl_stride() and register_net_sysctl_stride() are added
   alongside register_*_sz() so existing callers remain untouched.  If
   preferred, stride can instead be folded into register_*_sz() as an
   element-size parameter (similar to bsearch()).

4. Fixes & Cleanups:
   - Fixes net.core sysctl write permissions in init_net (mode 0222 is
     now cleared only for non-init network namespaces).
   - Cleans up redundant '.min = 0' initializers treewide.
   - Provides a Coccinelle script (scripts/coccinelle/api/sysctl/) for
     automated conversion and proof of no leftover extra1/extra2 uses.

Series Structure:
=================
- Patch 1: Core stride infrastructure and numeric bounds.
- Patch 2: KUnit unit test coverage (21 tests, pure handler execution).
- Patch 3: netfilter nf_log stride migration (11 wrappers removed).
- Patch 4: net/ipv4 devinet stride migration (32 wrappers removed).
- Patch 5: Coccinelle script for detection and conversion.

Testing:
========
- KUnit sysctl_test: pass:21 fail:0 (UML).
- x86_64 defconfig build of kernel/, fs/proc/, net/ passed.
- Coccinelle: full-tree MODE=context finds 0 leftovers after conversion
  and 822 before it; MODE=patch converts the legacy net/unix table.


Wen Yang (5):
  sysctl: add numeric bounds and core stride infrastructure
  sysctl: cover numeric bounds and table containers in KUnit
  netfilter: embed logger sysctl context using stride
  net/ipv4: embed device sysctl context using stride
  scripts/coccinelle: add script to detect and convert sysctl bounds

 fs/proc/proc_sysctl.c                         |  82 +-
 include/linux/sysctl.h                        |  43 +-
 include/net/net_namespace.h                   |  10 +
 kernel/sysctl-test.c                          | 776 +++++++++++++++++-
 kernel/sysctl.c                               |  38 +-
 lib/Kconfig.debug                             |   1 +
 net/ipv4/devinet.c                            | 190 +++--
 net/netfilter/nf_log.c                        |  84 +-
 net/sysctl_net.c                              |  31 +-
 .../api/sysctl/sysctl_numeric_bounds.cocci    | 276 +++++++
 10 files changed, 1339 insertions(+), 192 deletions(-)
 create mode 100644 scripts/coccinelle/api/sysctl/sysctl_numeric_bounds.cocci

base-commit: aaa2f954c21b205a0bcd0961e5b2be4e82e58455
-- 
2.25.1


             reply	other threads:[~2026-11-16 16:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 16:07 wen.yang [this message]
2026-11-16 16:07 ` [RFC PATCH v2 1/5] sysctl: add numeric bounds and core stride infrastructure wen.yang
2026-11-16 16:07 ` [RFC PATCH v2 2/5] sysctl: cover numeric bounds and table containers in KUnit wen.yang
2026-11-16 16:07 ` [RFC PATCH v2 3/5] netfilter: embed logger sysctl context using stride wen.yang
2026-11-16 16:07 ` [RFC PATCH v2 4/5] net/ipv4: embed device " wen.yang
2026-11-16 16:07 ` [RFC PATCH v2 5/5] scripts/coccinelle: add script to detect and convert sysctl bounds wen.yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1794844686.git.wen.yang@linux.dev \
    --to=wen.yang@linux.dev \
    --cc=david.laight.linux@gmail.com \
    --cc=joel.granados@kernel.org \
    --cc=kees@kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®