From: Julius Bairaktaris <julius@bairaktaris.de>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, edumazet@kernel.org, kuba@kernel.org,
pabeni@redhat.com, willemb@google.com, horms@kernel.org,
andrew+netdev@lunn.ch, dsahern@kernel.org, idosch@nvidia.com,
ncardwell@google.com, kuniyu@google.com,
steffen.klassert@secunet.com, herbert@gondor.apana.org.au,
richardbgobert@gmail.com, ecree.xilinx@gmail.com,
andy.moreton@amd.com, alex.austin@amd.com,
linux-net-drivers@amd.com, saeedm@nvidia.com, tariqt@nvidia.com,
mbloch@nvidia.com, leon@kernel.org, linux-rdma@vger.kernel.org,
alexei.starovoitov@gmail.com, ast@kernel.org,
daniel@iogearbox.net, andrii@kernel.org, eddyz87@gmail.com,
memxor@gmail.com, martin.lau@linux.dev, song@kernel.org,
yonghong.song@linux.dev, jolsa@kernel.org, emil@etsalapatis.com,
ihor.solodrai@linux.dev, john.fastabend@gmail.com,
sdf@fomichev.me, izaiahsun@gmail.com, corbet@lwn.net,
skhan@linuxfoundation.org, rdunlap@infradead.org,
shuah@kernel.org, bpf@vger.kernel.org, ipsec@lists.linux.dev,
linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH net v3 0/2] net: keep the TCP fixed-ID flags on the header they describe
Date: Sat, 21 Nov 2026 19:26:58 +0100 [thread overview]
Message-ID: <cover.1795284858.git.julius@bairaktaris.de> (raw)
GRO sets SKB_GSO_TCP_FIXEDID for a TCP packet whose IPv4 IDs do not
change. Since commit 3271f19bf7b9 ("net: gso: restore ids of outer ip
headers correctly") the flag describes the outermost header and
SKB_GSO_TCP_FIXEDID_INNER the inner one, so every path that adds or
removes a header would have to move the flags. None does, and a TCP
stream that GRO merged and that crosses a tunnel boundary is segmented
with the fixed-ID state of the wrong header.
Patch 1 lets SKB_GSO_TCP_FIXEDID describe the innermost header again and
replaces the inner flag with SKB_GSO_TCP_FIXEDID_OUTER, as Alexei
suggested in review of v1. A header added in front of a packet that is
already encapsulated clears the outer flag, and ESP transport and BEET
mode with crypto offload, which keep the IPv4 header, copy the inner flag
to the outer one. Two flags cannot describe the middle header of a packet
with three IPv4 headers: software segmentation uses SKB_GSO_TCP_FIXEDID
for it, as it used SKB_GSO_TCP_FIXEDID_INNER before. Patch 2 adds a
selftest.
The hosted Sashiko AI review of v2 2/3 of my "ipmr: forward GSO multicast
packets" series reported the issue [1], and the selftest in patch 2
reproduces it.
Tested in QEMU (KVM) with the selftest, 19 cases, 400 segments each:
- net (d5b89d55a322), 1 run: 6 cases fail. Fixed inner IDs increment
after IPIP over IPv4 and IPv6 and after the ESP tunnel (390 of 400
segments carry an inner ID the sender did not use), the outer IDs
repeat after GRE and VXLAN over IPv4 (10 distinct outer IDs for 400
segments), and a VXLAN stream with fixed outer IDs keeps that state
after decapsulation into IPIP (10 distinct outer IDs).
- v2 of this series, 1 run: the ESP transport mode case fails (390 of 400
segments carry an ID the sender did not use).
- this series, 3 of 3 runs: 19 of 19 pass.
Changes in v3:
- Patch 1: clear SKB_GSO_TCP_FIXEDID_OUTER in iptunnel_handle_offloads()
and in the BPF LWT encapsulation, where a header goes in front of an
encapsulated packet; the new outermost header kept the flag of the
header below it (Sashiko).
- Patch 1: copy the inner flag to the outer one in xfrm_output() for ESP
transport and BEET mode with crypto offload, which set
skb->encapsulation without adding an IPv4 header; v2 gave that header
incrementing IDs (Sashiko).
- Patch 1: name the paths that change the outer flag and the middle
header that the flags cannot describe in skbuff.h,
segmentation-offloads.rst and the commit message, and list
SKB_GSO_TCP_FIXEDID_OUTER in the bpf_skb_adjust_room() decap flags of
the uAPI header (Sashiko).
- Patch 1: wrap lines at 80 columns (NIPA).
- Patch 2: add an ESP transport mode case.
- Patch 2: skip a run in which GRO merged nothing before the outer IDs
are checked, and check that ESP tunnel mode outer IDs increment within
each packet (Sashiko).
- Patch 2: delete only the netdevsim devices the test created, also from
the EXIT trap, and before the namespaces (Sashiko).
- Patch 2: make the receiver's -c optional, as documented (Sashiko).
- Patch 2: use slowwait and check_gen_prog from lib.sh, and create the
netdevsim devices inside their namespace, as lib.sh does, with the
new_device write checked (Sashiko).
- Patch 2: report a receiver that is not bound within 10 s as such.
- Patch 2: fix shellcheck SC2016 and wrap lines at 80 columns (NIPA).
- Rebased onto net d5b89d55a322.
- v2: https://lore.kernel.org/netdev/cover.1794139176.git.julius@bairaktaris.de/
- v1: https://lore.kernel.org/netdev/cover.1792857378.git.julius@bairaktaris.de/
[1] https://lore.kernel.org/netdev/179182559332.434549.18294510093742639467@kernel.org/
I used Claude (Anthropic) to help write these patches.
Julius Bairaktaris (2):
net: keep the TCP fixed-ID flags on the header they describe
selftests: net: check TCP IP IDs across tunnels after GRO and GSO
.../networking/segmentation-offloads.rst | 8 +-
.../net/ethernet/mellanox/mlx5/core/en_rx.c | 8 +-
drivers/net/ethernet/sfc/ef100_tx.c | 12 +-
include/linux/netdevice.h | 2 +-
include/linux/skbuff.h | 12 +-
include/net/ip_tunnels.h | 1 +
include/uapi/linux/bpf.h | 16 +-
net/core/filter.c | 1 +
net/core/lwt_bpf.c | 2 +
net/ipv4/af_inet.c | 9 +-
net/ipv4/ip_tunnel_core.c | 2 +
net/ipv4/tcp_offload.c | 7 +-
net/xfrm/xfrm_output.c | 10 +
tools/include/uapi/linux/bpf.h | 16 +-
tools/testing/selftests/net/.gitignore | 1 +
tools/testing/selftests/net/Makefile | 2 +
tools/testing/selftests/net/tcp_fixedid.c | 432 ++++++++++++++++++
tools/testing/selftests/net/tcp_fixedid.sh | 427 +++++++++++++++++
18 files changed, 929 insertions(+), 39 deletions(-)
create mode 100644 tools/testing/selftests/net/tcp_fixedid.c
create mode 100755 tools/testing/selftests/net/tcp_fixedid.sh
base-commit: d5b89d55a322b632e2b465b392a4c1d9d338db9c
--
2.53.0
next reply other threads:[~2026-11-21 18:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-21 18:26 Julius Bairaktaris [this message]
2026-11-21 18:26 ` [PATCH net v3 1/2] " Julius Bairaktaris
2026-11-21 18:27 ` [PATCH net v3 2/2] selftests: net: check TCP IP IDs across tunnels after GRO and GSO Julius Bairaktaris
2026-11-21 18:32 ` [PATCH net v3 0/2] net: keep the TCP fixed-ID flags on the header they describe netdev-bot+sinfo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1795284858.git.julius@bairaktaris.de \
--to=julius@bairaktaris.de \
--cc=alex.austin@amd.com \
--cc=alexei.starovoitov@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrii@kernel.org \
--cc=andy.moreton@amd.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=corbet@lwn.net \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=ecree.xilinx@gmail.com \
--cc=eddyz87@gmail.com \
--cc=edumazet@kernel.org \
--cc=emil@etsalapatis.com \
--cc=herbert@gondor.apana.org.au \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=ihor.solodrai@linux.dev \
--cc=ipsec@lists.linux.dev \
--cc=izaiahsun@gmail.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=leon@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-net-drivers@amd.com \
--cc=linux-rdma@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=mbloch@nvidia.com \
--cc=memxor@gmail.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rdunlap@infradead.org \
--cc=richardbgobert@gmail.com \
--cc=saeedm@nvidia.com \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=song@kernel.org \
--cc=steffen.klassert@secunet.com \
--cc=tariqt@nvidia.com \
--cc=willemb@google.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®