From: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
To: Jiazi Liu <jiazi.liu1984@gmail.com>, tytso@mit.edu
Cc: adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Jiazi Liu <liujiazi@amazon.com>
Subject: Re: [PATCH 1/1] ext4: fix incorrect function call when initializing s_resgid
Date: Tue, 28 Jul 2026 10:10:07 +0530 [thread overview]
Message-ID: <cxw7n2vs.ritesh.list@gmail.com> (raw)
In-Reply-To: <20260727104103.28916-1-liujiazi@amazon.com>
Jiazi Liu <jiazi.liu1984@gmail.com> writes:
> In __ext4_fill_super(), s_resgid is initialized by calling
> ext4_get_resuid() instead of ext4_get_resgid(), resulting in the
> reserved GID being set to the same value as the reserved UID rather
> than the value stored in the superblock.
>
> Fixes: 12c84dd4d308 ("ext4: add support for 32-bit default reserved uid and gid values")
> Cc: stable@vger.kernel.org
> Signed-off-by: Jiazi Liu <liujiazi@amazon.com>
yup, that clearly looks like a simple miss.
Nice catch! Wondering whether this was caught by code review or did you
hit an issue due to this?
Looks good to me. Feel free to add:
Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
next prev parent reply other threads:[~2026-07-28 4:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-27 10:41 Jiazi Liu
2026-07-28 4:40 ` Ritesh Harjani [this message]
2026-07-29 3:31 ` Liu Jiazi
2026-08-06 15:00 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cxw7n2vs.ritesh.list@gmail.com \
--to=ritesh.list@gmail.com \
--cc=adilger.kernel@dilger.ca \
--cc=jiazi.liu1984@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liujiazi@amazon.com \
--cc=stable@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®