From: Andriy Tryshnivskyy <andriy.tryshnivskyy@opensynergy.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: jbhayana@google.com, lars@metafoo.de, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org, Vasyl.Vavrychuk@opensynergy.com
Subject: Re: [PATCH v6 1/1] iio/scmi: Add reading "raw" attribute.
Date: Sun, 24 Oct 2021 10:23:38 +0300 [thread overview]
Message-ID: <d0050bf2-e8d0-c2e7-66cb-f3099dfe8d53@opensynergy.com> (raw)
In-Reply-To: <20211021103607.38c85766@jic23-huawei>
>>> On Tue, 19 Oct 2021 10:59:49 +0300
>>> Andriy Tryshnivskyy <andriy.tryshnivskyy@opensynergy.com> wrote:
>>>
>>>> Add IIO_CHAN_INFO_RAW to the mask and implement corresponding
>>>> reading "raw" attribute in scmi_iio_read_raw.
>>>> Introduce new type IIO_VAL_INT_64 to read 64-bit value
>>>> for "raw" attribute.
>>>>
>>> Change log needs to be below the --- otherwise we'll store it forever
>>> in git. A linked tag (which will be generated when I apply)
>>> is sufficient for this sort of historical info.
>>>
>> Sorry, this is my first patch, I was not aware of that.
>> Thanks for the explanation.
>> Quick question: since next version will include 2 patches,
>> I guess a change log should be moved back to the cover letter, right?
> It's a trade off for which there are no firm rules.
> Sometimes changes are well isolated in individual patches, in which case
> the best bet is to put the change logs in each patch, sometimes they are
> more global things that affect the whole series in which case the change
> log is best in the cover letter.
>
> However, for a given series pick one or other style (don't mix!) as
> otherwise it would get really confusing. Mostly no one really minds
> where the log is as long as we can find it easily.
>
> Jonathan
thank you for the clarification!
best regards,
Andriy.
next prev parent reply other threads:[~2021-10-24 7:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-19 7:59 [PATCH v6 0/1] " Andriy Tryshnivskyy
2021-10-19 7:59 ` [PATCH v6 1/1] " Andriy Tryshnivskyy
2021-10-20 17:51 ` Jonathan Cameron
2021-10-20 18:57 ` Andriy Tryshnivskyy
2021-10-21 0:40 ` Jyoti Bhayana
2021-10-24 7:35 ` Andriy Tryshnivskyy
2021-10-21 9:36 ` Jonathan Cameron
2021-10-24 7:23 ` Andriy Tryshnivskyy [this message]
[not found] ` <CAHp75VeZ5=T8N50PoZQVsWjf5ZWjZ4kwHAxUp=pyuK6ioUrQog@mail.gmail.com>
2021-10-24 8:49 ` [PATCH v6 0/1] " Andriy Tryshnivskyy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0050bf2-e8d0-c2e7-66cb-f3099dfe8d53@opensynergy.com \
--to=andriy.tryshnivskyy@opensynergy.com \
--cc=Vasyl.Vavrychuk@opensynergy.com \
--cc=jbhayana@google.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®