From: Cezary Rojewski <cezary.rojewski@intel.com>
To: <phucduc.bui@gmail.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
<cassiogabrielcontato@gmail.com>,
Haotian Zhang <vulab@iscas.ac.cn>,
Christian Marangi <ansuelsmth@gmail.com>,
Cyril Chao <Cyril.Chao@mediatek.com>, Tuo Li <islituo@gmail.com>,
Rosen Penev <rosenp@gmail.com>,
Garlic Tseng <garlic.tseng@mediatek.com>,
"Alexandre Mergnat" <amergnat@baylibre.com>,
Dan Carpenter <error27@gmail.com>, <linux-sound@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, "Mark Brown" <broonie@kernel.org>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Trevor Wu <trevor.wu@mediatek.com>
Subject: Re: [PATCH v2 0/4] ASoC: mediatek: Handle constraint return value in FE startup
Date: Wed, 7 Oct 2026 16:03:12 +0200 [thread overview]
Message-ID: <d00880e3-01b6-476a-93f5-79ea6e536a1c@intel.com> (raw)
In-Reply-To: <20261007110858.509341-1-phucduc.bui@gmail.com>
On 10/7/2026 1:08 PM, phucduc.bui@gmail.com wrote:
> From: bui duc phuc <phucduc.bui@gmail.com>
>
> Hi all,
>
> Some FE startup callbacks may return a positive value from constraint
> helpers, but ASoC expects 0 on success. This can cause .shutdown() to be
> skipped during rollback.
>
> Return 0 explicitly on success.
>
> Compile-tested only.
>
> Changes in v2:
> - Rename the patch subject.
> - Simplify the code change as suggested by Cezary.
Thank you for the update. The snd_pcm_hw_constraint_xxx() finding is a
good catch.
Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com>
prev parent reply other threads:[~2026-10-07 14:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-07 11:08 phucduc.bui
2026-10-07 11:08 ` [PATCH v2 1/4] ASoC: mediatek: common: " phucduc.bui
2026-10-07 11:08 ` [PATCH v2 2/4] ASoC: mediatek: mt8188: " phucduc.bui
2026-10-07 11:08 ` [PATCH v2 3/4] ASoC: mediatek: mt8189: " phucduc.bui
2026-10-07 11:08 ` [PATCH v2 4/4] ASoC: mediatek: mt8365: " phucduc.bui
2026-10-07 14:03 ` Cezary Rojewski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d00880e3-01b6-476a-93f5-79ea6e536a1c@intel.com \
--to=cezary.rojewski@intel.com \
--cc=Cyril.Chao@mediatek.com \
--cc=amergnat@baylibre.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=ansuelsmth@gmail.com \
--cc=broonie@kernel.org \
--cc=cassiogabrielcontato@gmail.com \
--cc=error27@gmail.com \
--cc=garlic.tseng@mediatek.com \
--cc=islituo@gmail.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-sound@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=perex@perex.cz \
--cc=phucduc.bui@gmail.com \
--cc=rosenp@gmail.com \
--cc=tiwai@suse.com \
--cc=trevor.wu@mediatek.com \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®