From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0398AC433DF for ; Sun, 24 May 2020 18:49:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E4B1820787 for ; Sun, 24 May 2020 18:49:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388019AbgEXSti (ORCPT ); Sun, 24 May 2020 14:49:38 -0400 Received: from smtprelay0074.hostedemail.com ([216.40.44.74]:40220 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2387903AbgEXSth (ORCPT ); Sun, 24 May 2020 14:49:37 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay06.hostedemail.com (Postfix) with ESMTP id 9A4F418009FEB; Sun, 24 May 2020 18:49:36 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: base72_230952626d3a X-Filterd-Recvd-Size: 2154 Received: from XPS-9350.home (unknown [47.151.136.130]) (Authenticated sender: joe@perches.com) by omf17.hostedemail.com (Postfix) with ESMTPA; Sun, 24 May 2020 18:49:35 +0000 (UTC) Message-ID: Subject: Re: [PATCH] printk: Remove pr_cont_once() From: Joe Perches To: Tetsuo Handa , Andrew Morton , Petr Mladek , Sergey Senozhatsky , Steven Rostedt Cc: linux-kernel@vger.kernel.org Date: Sun, 24 May 2020 11:49:34 -0700 In-Reply-To: <20200524153243.11690-1-penguin-kernel@I-love.SAKURA.ne.jp> References: <20200524153243.11690-1-penguin-kernel@I-love.SAKURA.ne.jp> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.36.2-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2020-05-25 at 00:32 +0900, Tetsuo Handa wrote: > pr_cont_once() does not make sense; at least emitting module name using > pr_fmt() into middle of a line (after e.g. pr_info_once()) does not make > sense. Let's remove unused pr_cont_once(). Right, thanks. It's nearly a decade old cut'n'paste defect and no one has ever used it or noticed it until now. > Signed-off-by: Tetsuo Handa > Cc: Joe Perches > --- > include/linux/printk.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/include/linux/printk.h b/include/linux/printk.h > index 2562ffb438ed..4c565871f659 100644 > --- a/include/linux/printk.h > +++ b/include/linux/printk.h > @@ -476,8 +476,7 @@ extern int kptr_restrict; > printk_once(KERN_NOTICE pr_fmt(fmt), ##__VA_ARGS__) > #define pr_info_once(fmt, ...) \ > printk_once(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) > -#define pr_cont_once(fmt, ...) \ > - printk_once(KERN_CONT pr_fmt(fmt), ##__VA_ARGS__) > +/* no pr_cont_once, don't do that... */ > > #if defined(DEBUG) || defined(CONFIG_TWIST_ALWAYS_EVALUATE_DEBUG_PRINTK) > #define pr_devel_once(fmt, ...) \