From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f180.google.com (mail-qt1-f180.google.com [209.85.160.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D7ED48EBEE for ; Fri, 14 Aug 2026 16:55:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786726531; cv=none; b=h9vVdA1EUI8dOjSm1+RgnaOxhkXN6fnEFaDtiOgxi+PjSP6sLXeSCTn7SEymKpgB/mgbOtFkzW7NiBWKhRm2pSkGtEOwxhpSc64K4/wubA4KUtm/hWTvW+VhT9/d71X//pTvGXiTiXFK6lplcMQeZcjec+69QdII/TFV3TE3b7g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786726531; c=relaxed/simple; bh=K5dcQJf2Ch/6vpTqCE5mVe/Cn73el9CTj0AfswwkkrU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZBWwlBEUWW8bzU2/0Ff1HrzdU/R1FdWxcDmXyarzbdbHimPZJuA8sbeCrm3m3gqoqbrK86+p4olx3U8zcSCAurKw9hstuDlXa4OBOKWtw1Ke6cLulZ/lyYJRIEZe4AI3rzLsOHpQUZ+C93NF5nUwstZe84baQqdpev5+1mLS3zY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com; spf=pass smtp.mailfrom=riscstar.com; dkim=pass (2048-bit key) header.d=riscstar-com.20251104.gappssmtp.com header.i=@riscstar-com.20251104.gappssmtp.com header.b=hZl4XSeo; arc=none smtp.client-ip=209.85.160.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=riscstar.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=riscstar-com.20251104.gappssmtp.com header.i=@riscstar-com.20251104.gappssmtp.com header.b="hZl4XSeo" Received: by mail-qt1-f180.google.com with SMTP id d75a77b69052e-51c0c45c580so8356751cf.0 for ; Fri, 14 Aug 2026 09:55:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riscstar-com.20251104.gappssmtp.com; s=20251104; t=1786726528; x=1787331328; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=anIgQ2iX3wKwO3iZRXoJM1Kp7efYwEyDsRDYZCL7bQI=; b=hZl4XSeoJSQ1E5VaDwJCpUi82lFCjvf5F0Qc4TmiLi/n0N5YNnVq0wg/W8oZu42xfn Qw/MtJWsT2x+peeaBieNucWefU96eullYWPr5ut7AMvRNE9+kaItWj7KLt3ozSGWjQu+ mHsElWeA+U7auxXZpBd9Hozvvd2Oio/ijZsyGYU6wbEuxKl9ZgyMU5eyIhgnAyajRX/S r3E2QEHU92X8i/STt2500nr9b1jF/n5qz2X4K2+5Hjw8TKviLmw0fCQ18IP++Ee15bkU kFcd5b0Xg6cw/Im6eNPbpfPu+YehOJk0FogK6ECA33dtbuCYBeYqaI7D5oCAGVYi9Hpo vKGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786726528; x=1787331328; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=anIgQ2iX3wKwO3iZRXoJM1Kp7efYwEyDsRDYZCL7bQI=; b=k1joeV65ySktoTDXmv0o9abwnqEOgXWXwxDSgatUnfHtNCQkrF5hVbVlWgHRoBI7xV XFIBaO0wd70Ye30WYLUOyHOq4AYhnKvcVl4sx9LFhKt6kxGvChDyMsOaR9OHO+xhnLq6 zMZhcwe/R3v2myXk5vqncTSvvs3knllVxntYBiU5Fjzu301L1OvS+6Cm2df2M7Wj+yWQ qYNYMWwKAmH8U09r81V4bK9bTklCeKkPF4g/MT/nBCGEPXDj+R3oSK+EVZyrH7CDBIs/ 6sdA2P63+z29rK7Wkqv89AkS1Z+gv6/qtRAx/ZJKY0Mo+76YpsKdfZjt7X9ncYveVIwZ 4x3w== X-Forwarded-Encrypted: i=1; AHgh+RrXr0YW1n6JOifZEO5yNPITMeTBp+yb2xWBzfKXUf1ZjDSUhoiKtZylGNkgjAj+BxU/M9XcyR36vJ7HYpM=@vger.kernel.org X-Gm-Message-State: AOJu0YyZf8gqU0f3SwinrVXvxkizdHNHxxWt9KHcFnHJ1p02t9OfJ6g9 Z7aCvtKemtykeOhLhVrg8ckFSwXDFU7Zxl76uBZbhc5C9agq8BNBq3Nw4NNVz+eOWvU= X-Gm-Gg: AR+sD11SPx7Mw8bRfnvHpSHODHSRQQd+J28UXP9O2CHDAny+vbZiKL01f0PBxHoA9AE gcohwhc/mbNeZvzisU0AqNlZSNDmTOhZTYgTS2T32kw40d/+qOa/V0xBvMiAz26PR8QcntSvoVL f6vOXY3KsQTkH2MLqYVBOVFmjqFRjy7DwhKx6JAUDbFA5YYLqFcc4fASSsdZtnculbg94zq4xSy lSesOBGMXw+jFYcUcCjHvqTXWOq62xhz3iQZ0tGVkbi2mJ85Cl5+QvLJUBI6kyfJvVf5KkpV7lg bQVpeYsGnP1QCqSvoq3p2OpGYRe7Bd448BMBDoMyY3evO5e+i61SvOZGinILIVTTLs2TtBrv5pd 7Gh3BwuOdW/GPskAbFUhwCBHrF4U+tJjt5xybeMF8fZdTE/MATguBaap7NGPc5ZUi5B+tDmt08A 8TY+4aaTZcE2HPgHbbl6k0BQX7jv+/OjyhG4beEiK8gLaoJCPh8VXv1Kt5ax/SXWYqyNzhbtA= X-Received: by 2002:a05:622a:17c5:b0:51b:fadc:ed7d with SMTP id d75a77b69052e-52d855893ccmr86941561cf.44.1786726528261; Fri, 14 Aug 2026 09:55:28 -0700 (PDT) Received: from [172.22.22.28] ([73.62.185.64]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-52d84071799sm24476161cf.20.2026.08.14.09.55.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Aug 2026 09:55:27 -0700 (PDT) Message-ID: Date: Fri, 14 Aug 2026 11:55:26 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] misc: tc9564: introduce base PCI driver To: Krzysztof Kozlowski Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, arnd@arndb.de, gregkh@linuxfoundation.org, bhelgaas@google.com, daniel@riscstar.com, mohdayaa@qti.qualcomm.com, lbiancon@qti.qualcomm.com, devicetree@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260813222943.1655453-1-elder@riscstar.com> <20260813222943.1655453-3-elder@riscstar.com> <20260814-rainbow-alchemical-gaur-9fd8de@quoll> Content-Language: en-US From: Alex Elder In-Reply-To: <20260814-rainbow-alchemical-gaur-9fd8de@quoll> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 8/14/26 2:03 AM, Krzysztof Kozlowski wrote: > On Thu, Aug 13, 2026 at 05:29:42PM -0500, Alex Elder wrote: >> +static struct pci_driver tc9564_function_driver = { >> + .name = DRIVER_NAME, >> + .id_table = tc9564_function_id_table, >> + .probe = tc9564_function_probe, >> + .remove = tc9564_function_remove, >> + .driver = { >> + .name = DRIVER_NAME, >> + .owner = THIS_MODULE, > > You just copied some old driver. Why do you need this? What do you mean I "just copied some old driver"? I do now see that a PCI driver doesn't need to set it, because pci_register_driver() sets it automatically. I will remove that in the next version. -Alex> >> + }, >> +}; >> +module_pci_driver(tc9564_function_driver); >> + >> +MODULE_DESCRIPTION("Toshiba TC9564 PCIe Embedded Function Driver"); >> +MODULE_LICENSE("GPL"); >> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c >> index 6501c949c5b76..b484f1b1d0e71 100644 >> --- a/drivers/pci/quirks.c >> +++ b/drivers/pci/quirks.c >> @@ -6388,6 +6388,7 @@ DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_XILINX, 0x5020, of_pci_make_dev_node); >> DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_XILINX, 0x5021, of_pci_make_dev_node); >> DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_REDHAT, 0x0005, of_pci_make_dev_node); >> DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_EFAR, 0x9660, of_pci_make_dev_node); >> +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_TOSHIBA, 0x0220, of_pci_make_dev_node); >> >> /* >> * Devices known to require a longer delay before first config space access >> -- >> 2.53.0 >>