From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87F5FEB64D9 for ; Fri, 30 Jun 2023 02:20:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230410AbjF3CUO (ORCPT ); Thu, 29 Jun 2023 22:20:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56276 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229576AbjF3CUM (ORCPT ); Thu, 29 Jun 2023 22:20:12 -0400 Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B5EE82D5B for ; Thu, 29 Jun 2023 19:20:08 -0700 (PDT) X-UUID: 190f60f2e69a4b23b1f50b9cd8b6b5e0-20230630 X-CID-O-RULE: Release_Ham X-CID-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.27,REQID:665a12d9-ccb0-4a46-a3d5-30687c7ab01a,IP:10, URL:0,TC:0,Content:0,EDM:0,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACTI ON:release,TS:-5 X-CID-INFO: VERSION:1.1.27,REQID:665a12d9-ccb0-4a46-a3d5-30687c7ab01a,IP:10,UR L:0,TC:0,Content:0,EDM:0,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACTION :release,TS:-5 X-CID-META: VersionHash:01c9525,CLOUDID:fdf7650d-26a8-467f-b838-f99719a9c083,B ulkID:230629143756S0BHX8LB,BulkQuantity:3,Recheck:0,SF:38|24|17|19|44|102, TC:nil,Content:0,EDM:-3,IP:-2,URL:1,File:nil,Bulk:40,QS:nil,BEC:nil,COL:0, OSI:0,OSA:0,AV:0,LES:1,SPR:NO X-CID-BVR: 0,NGT X-CID-BAS: 0,NGT,0,_ X-CID-FACTOR: TF_CID_SPAM_FSD,TF_CID_SPAM_FSI,TF_CID_SPAM_ULS,TF_CID_SPAM_SNR, TF_CID_SPAM_FAS X-UUID: 190f60f2e69a4b23b1f50b9cd8b6b5e0-20230630 X-User: jiangfeng@kylinos.cn Received: from [192.168.12.178] [(116.128.244.171)] by mailgw (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES128-GCM-SHA256 128/128) with ESMTP id 552225035; Fri, 30 Jun 2023 10:19:55 +0800 Message-ID: Date: Fri, 30 Jun 2023 10:19:33 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH] drm/ttm: Remove duplicate assignments to ttm->caching To: =?UTF-8?Q?Christian_K=c3=b6nig?= , ray.huang@amd.com, airlied@gmail.com, daniel@ffwll.ch, michael.j.ruhl@intel.com Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20230625024528.13668-1-jiangfeng@kylinos.cn> <1688091259850883.47.seg@mailgw> Content-Language: en-US From: Feng Jiang In-Reply-To: <1688091259850883.47.seg@mailgw> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/6/29 14:37, Christian König wrote: > This has already been fixed with: > > commit 2ce977df10c179138e2723b25c2d2c055a3e3cc6 > Author: Ma Jun > Date:   Wed May 31 13:30:51 2023 +0800 > >     drm/ttm: Remove redundant code in ttm_tt_init_fields > >     Remove redundant assignment code for ttm->caching as it's overwritten >     just a few lines later. > >     v2: >      - Update the commit message. > >     Signed-off-by: Ma Jun >     Reviewed-by: Guchun Chen >     Reviewed-by: Christian König >     Signed-off-by: Christian König >     Link: https://patchwork.freedesktop.org/patch/msgid/20230531053051.3453509-1-Jun.Ma2@amd.com > > > Regards, > Christian. > > Am 25.06.23 um 04:45 schrieb Feng Jiang: >> The parameter 'caching' has already been assigned to >> 'ttm->caching', so 'ttm_cached' is redundant. >> >> Fixes: 1b4ea4c5980f ("drm/ttm: set the tt caching state at creation time") >> Signed-off-by: Feng Jiang >> --- >>   drivers/gpu/drm/ttm/ttm_tt.c | 1 - >>   1 file changed, 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/ttm/ttm_tt.c b/drivers/gpu/drm/ttm/ttm_tt.c >> index ab725d9d14a6..1ce4b36ab33b 100644 >> --- a/drivers/gpu/drm/ttm/ttm_tt.c >> +++ b/drivers/gpu/drm/ttm/ttm_tt.c >> @@ -137,7 +137,6 @@ static void ttm_tt_init_fields(struct ttm_tt *ttm, >>                      unsigned long extra_pages) >>   { >>       ttm->num_pages = (PAGE_ALIGN(bo->base.size) >> PAGE_SHIFT) + extra_pages; >> -    ttm->caching = ttm_cached; >>       ttm->page_flags = page_flags; >>       ttm->dma_address = NULL; >>       ttm->swap_storage = NULL; > Sorry, I will check before sending next time, thanks! -- Best regards, Feng