From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from canpmsgout06.his.huawei.com (canpmsgout06.his.huawei.com [113.46.200.221]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E3564C77D6 for ; Tue, 12 May 2026 12:12:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=113.46.200.221 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778587946; cv=none; b=T0Kz2weWDwap7g2Ev/SiHAL08iA4rHVp/z3jF1c2O3oeP1jc9eC43aHvL96TbUjVtiVMQQKU5dvRHq1vw51RDAZ8KDVHcdngPU67qOVddhJ6zbnYXjAl9kiDiTZE8Y5GyYtez6yVwslKSrBu092pR4Qpinufr2M7ttT/yS99AL0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778587946; c=relaxed/simple; bh=jZGJYYrMUBBWSC/WQhBcO1+dMJF6I1hhDzPbOiWxc4I=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=KcN1mZ7+Xxe+vqPuFce9BbkZV4b3ydacojDagOC+4PKsySgFx9QeTAqkgnnb7CHwa+MuL7xUqGUwDBgK6Rfpp1Z6ddxQjh7JZBjUXzeFbmd65duttJrySKUkIlmyydTDUgHBPCsCzPbmpuZWgR9HI0Di/3Q07R69/Cq+enBpcYw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com header.b=l5HQoC3d; arc=none smtp.client-ip=113.46.200.221 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com header.b="l5HQoC3d" dkim-signature: v=1; a=rsa-sha256; d=huawei.com; s=dkim; c=relaxed/relaxed; q=dns/txt; h=From; bh=RUY8JwnijBo4MYkY0cWpwDESs0uauL0DBCZ0hq4URZs=; b=l5HQoC3d2Ha9FbqH86HL6zm0Y5vfmKIS7z8wk58wpOKwd3yeQTpehcWEnw1Md1FznTYYhNDZQ UvcFmI/ODwtXBDXqHezz1k+IEVCnlt6b/6qSK/KApLTBsPKKncjt4f9ik+liu9RhvPl600UoAbt RSe58yoVEeGH5sb71l3lcMo= Received: from mail.maildlp.com (unknown [172.19.163.104]) by canpmsgout06.his.huawei.com (SkyGuard) with ESMTPS id 4gFFdT00zFzRhSr; Tue, 12 May 2026 20:04:44 +0800 (CST) Received: from dggemv712-chm.china.huawei.com (unknown [10.1.198.32]) by mail.maildlp.com (Postfix) with ESMTPS id 39E464056A; Tue, 12 May 2026 20:12:21 +0800 (CST) Received: from kwepemq100007.china.huawei.com (7.202.195.175) by dggemv712-chm.china.huawei.com (10.1.198.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Tue, 12 May 2026 20:12:21 +0800 Received: from [10.159.167.44] (10.159.167.44) by kwepemq100007.china.huawei.com (7.202.195.175) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Tue, 12 May 2026 20:12:20 +0800 Message-ID: Date: Tue, 12 May 2026 20:12:19 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH for drm-misc-fixes v6 0/4] Fix some bugs in the hibmc driver To: Thomas Zimmermann , , , , , , , , CC: , , , , , , , , References: <20260509032302.2057227-1-shiyongbang@huawei.com> From: Yongbang Shi In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-ClientProxiedBy: kwepems200002.china.huawei.com (7.221.188.68) To kwepemq100007.china.huawei.com (7.202.195.175) > Hi, > > I've gone through the series and reviewed the patches. Let me know when they are ready to get merged. > Thanks for the review. The series is ready for merging now. Thanks, Yongbang. > Best regards > Thomas > > > Am 09.05.26 um 05:22 schrieb Yongbang Shi: >> From: Lin He >> >> There are some bugfix for hibmc-drm driver. >> >> --- >> ChangeLog: >> v5 -> v6: >>    - Rename 'phys_state' to 'phys_status' >>    - Replace `drm_kms_helper_poll_init` with `drmm_kms_helper_poll_init` >>      and adjust the timing of the call. >>    - Split "return vdac->phys_state = state;" into separate statements. >>    - Change `get_mode` to return 0 when no modes are available, allowing DRM to >>      install a default resolution. >>    - Change the initial phys_status of vdac from >>      'connector_status_connected' to 'connector_status_disconnected' >>    - Removed invalid bit configurations from `hibmc_display_ctrl`. >>    - Modify the return values of `hibmc_get_best_clock_idx` and >>      `hibmc_crtc_mode_valid` >> v4 -> v5: >>    - The 'epoch_counter' of the vdac connector is incremented when the >>     physical status changes. >>    - The polling mechanism for the KMS helper is enabled. >> v3 -> v4: >>    - fix incorrect cover-letter subject prefix in v3. >> v2 -> v3: >>    - remove unused macro CLOCK_TOLERANCE. >> v1 -> v2: >>    - fix the checkpatch.pl warning "Unknown commit ID 'e6c7c59da494'". >>    - fix the checkpatch.pl warning "line length of 83/85 exceeds 80 columns". >>    - remove tag "Reviewed-by: Tao Tian ", witch will >>      be given in public. >>    - add 'drm-misc-fixes' in subject prefix. >> --- >> >> Lin He (4): >>    drm/hisilicon/hibmc: add updating link cap in DP detect() >>    drm/hisilicon/hibmc: fix no showing when no connectors connected >>    drm/hisilicon/hibmc: move display contrl config to hibmc_probe() >>    drm/hisilicon/hibmc: use clock to look up the PLL value >> >>   drivers/gpu/drm/hisilicon/hibmc/dp/dp_comm.h  |  1 + >>   drivers/gpu/drm/hisilicon/hibmc/dp/dp_hw.h    |  1 + >>   drivers/gpu/drm/hisilicon/hibmc/dp/dp_link.c  |  2 +- >>   .../gpu/drm/hisilicon/hibmc/hibmc_drm_de.c    | 80 +++++++++++-------- >>   .../gpu/drm/hisilicon/hibmc/hibmc_drm_dp.c    | 35 +++++--- >>   .../gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c   | 14 ++++ >>   .../gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h   |  1 + >>   .../gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c  | 75 +++++++++-------- >>   8 files changed, 124 insertions(+), 85 deletions(-) >> >