mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>, jolsa@redhat.com
Cc: Sandipan Das <sandipan@linux.vnet.ibm.com>,
	linux-kernel@vger.kernel.org, naveen.n.rao@linux.vnet.ibm.com
Subject: Re: [PATCH 1/2] perf script: Show virtual addresses instead of offsets
Date: Fri, 18 May 2018 10:03:44 +0530	[thread overview]
Message-ID: <d01892c2-4c99-620c-5b1b-76dd82af3c21@linux.ibm.com> (raw)
In-Reply-To: <20180517195957.GD18538@kernel.org>

Arnaldo,

We already have a binary offset handy in perf code but there is no way to
dump it with perf script. We can derive it from symname+symoff but that's
a manual work.

Will it be good to have a '-F binoff' option?

Ravi


On 05/18/2018 01:29 AM, Arnaldo Carvalho de Melo wrote:
> Em Thu, May 17, 2018 at 12:03:25PM +0530, Sandipan Das escreveu:
>> When perf data is recorded with the call-graph option enabled,
>> the callchain shown by perf script shows the binary offsets of
>> the symbols as the ip. This is incorrect for kernel symbols as
>> the ip values are always off by a fixed offset depending on the
>> architecture. If the offsets from the start of the symbols are
>> printed, they are also incorrect for both kernel and userspace
>> symbols.
>>
>> Without the call-graph option, the callchain shows the virtual
>> addresses of the symbols rather than their binary offsets. The
>> offsets printed in this case are also correct.
>>
>> This fixes the inconsistency in perf script's output.
> 
> Thanks, tested and applied,
> 
> - Arnaldo
> 

  reply	other threads:[~2018-05-18  4:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-17  6:33 Sandipan Das
2018-05-17  6:33 ` [PATCH 2/2] perf script: Show symbol offsets by default Sandipan Das
2018-05-19 11:45   ` [tip:perf/core] " tip-bot for Sandipan Das
2018-05-17 19:59 ` [PATCH 1/2] perf script: Show virtual addresses instead of offsets Arnaldo Carvalho de Melo
2018-05-18  4:33   ` Ravi Bangoria [this message]
2018-05-19 11:45 ` [tip:perf/core] " tip-bot for Sandipan Das

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d01892c2-4c99-620c-5b1b-76dd82af3c21@linux.ibm.com \
    --to=ravi.bangoria@linux.ibm.com \
    --cc=acme@kernel.org \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=naveen.n.rao@linux.vnet.ibm.com \
    --cc=sandipan@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®