From: Jia-Ju Bai <baijiaju1990@gmail.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
airlied@linux.ie, daniel@ffwll.ch, jani.nikula@linux.intel.com,
joonas.lahtinen@linux.intel.com, lkml@SDF.ORG,
matthew.auld@intel.com, rodrigo.vivi@intel.com
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gpu: drm: i915: fix error return code of igt_buddy_alloc_smoke()
Date: Mon, 8 Mar 2021 17:26:18 +0800 [thread overview]
Message-ID: <d01ccf05-abbf-7f65-396d-31735d9b31f1@gmail.com> (raw)
In-Reply-To: <161519509650.8241.14778072091965189208@build.alporthouse.com>
On 2021/3/8 17:18, Chris Wilson wrote:
> Quoting Jia-Ju Bai (2021-03-08 08:59:52)
>> When i915_random_order() returns NULL to order, no error return code of
>> igt_buddy_alloc_smoke() is assigned.
>> To fix this bug, err is assigned with -EINVAL in this case.
> It would not be EINVAL since that is used for a reference failure, but
> in this case the idea was to return 0 as no testing was done and the
> ENOMEM was raised before testing began i.e. not an internal and
> unexpected driver allocation failure.
> -Chris
Okay, thanks for your reply :)
Best wishes,
Jia-Ju Bai
prev parent reply other threads:[~2021-03-08 9:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-08 8:59 Jia-Ju Bai
2021-03-08 9:18 ` Chris Wilson
2021-03-08 9:26 ` Jia-Ju Bai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d01ccf05-abbf-7f65-396d-31735d9b31f1@gmail.com \
--to=baijiaju1990@gmail.com \
--cc=airlied@linux.ie \
--cc=chris@chris-wilson.co.uk \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkml@SDF.ORG \
--cc=matthew.auld@intel.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®