From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751533AbcFCFNi (ORCPT ); Fri, 3 Jun 2016 01:13:38 -0400 Received: from szxga03-in.huawei.com ([119.145.14.66]:48340 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751088AbcFCFNh (ORCPT ); Fri, 3 Jun 2016 01:13:37 -0400 Subject: Re: [PATCH] f2fs: fix to redirty page if fail to gc data page To: Jaegeuk Kim References: <1463807951-10472-1-git-send-email-chao@kernel.org> <20160530023702.GB78763@jaegeuk.hsd1.ca.comcast.net> <20160603050858.GA24882@jaegeuk> CC: Chao Yu , , From: Chao Yu Message-ID: Date: Fri, 3 Jun 2016 13:13:21 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <20160603050858.GA24882@jaegeuk> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020202.575111F8.00E9,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-05-26 15:14:31, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 5ce67f7fdd8d8f55e5391525df6bd40d Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016/6/3 13:08, Jaegeuk Kim wrote: > On Tue, May 31, 2016 at 02:10:50PM +0800, Chao Yu wrote: >> Hi Jaegeuk, >> >> On 2016/5/30 10:37, Jaegeuk Kim wrote: >>> Hi Chao, >>> >>> On Sat, May 21, 2016 at 01:19:11PM +0800, Chao Yu wrote: >>>> From: Chao Yu >>>> >>>> If we fail to move data page during foreground GC, we should give another >>>> chance to writeback that page which was set dirty previously by writer. >>>> >>>> Signed-off-by: Chao Yu >>>> --- >>>> fs/f2fs/gc.c | 5 ++++- >>>> 1 file changed, 4 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c >>>> index 38d56f6..ee213a8 100644 >>>> --- a/fs/f2fs/gc.c >>>> +++ b/fs/f2fs/gc.c >>>> @@ -653,12 +653,15 @@ static void move_data_page(struct inode *inode, block_t bidx, int gc_type) >>>> .page = page, >>>> .encrypted_page = NULL, >>>> }; >>>> + bool is_dirty = PageDirty(page); >>>> + >>>> set_page_dirty(page); >>>> f2fs_wait_on_page_writeback(page, DATA, true); >>>> if (clear_page_dirty_for_io(page)) >>>> inode_dec_dirty_pages(inode); >>>> set_cold_data(page); >>>> - do_write_data_page(&fio); >>>> + if (do_write_data_page(&fio) && is_dirty) >>>> + set_page_dirty(page); >>> >>> If this page is truncated with -ENOENT, we don't need to set it dirty again. >> >> Agree >> >>> I expect that, if we get an error here, do_garbage_collect() would retry FG_GC >> >> IIRC, you have reworked the FG_GC flows changed from an infinite loop to trying >> do the movement just one time. Here, I think if there are just few of blocks are >> failed to be moved, we can give one more time for retrying. How do you think? > > Mostly I expected here -ENOENT caused by race condition. If we hit ENOENT case, we can pass get_valid_blocks check, so we don't need to worry about this case, right? > Do we have another expectation? ENOMEM or EIO? Thanks, > > Thanks, > >> >>> again. >>> >>> Thanks, >>> >>>> clear_cold_data(page); >>>> } >>>> out: >>>> -- >>>> 2.7.2 >>> . >>> > . >