From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Baolin Wang <baolin.wang@linux.alibaba.com>,
Pedro Demarchi Gomes <pedrodemargomes@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Lorenzo Stoakes <ljs@kernel.org>, Zi Yan <ziy@nvidia.com>,
"Liam R . Howlett" <liam@infradead.org>,
Nico Pache <nico.pache@linux.dev>,
Ryan Roberts <ryan.roberts@arm.com>, Dev Jain <dev.jain@arm.com>,
Barry Song <baohua@kernel.org>, Lance Yang <lance.yang@linux.dev>,
Usama Arif <usama.arif@linux.dev>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH mm-stable] mm/khugepaged: avoid unnecessary checking for swap entries when collapsing a mTHP
Date: Thu, 27 Aug 2026 13:02:14 +0200 [thread overview]
Message-ID: <d02405a5-1d0d-49d5-9056-1a34ccdeef10@kernel.org> (raw)
In-Reply-To: <1ec4ef97-47e4-48af-a8c8-4e50faf781f0@linux.alibaba.com>
On 8/27/26 10:06, Baolin Wang wrote:
>
>
> On 8/26/26 3:24 AM, Pedro Demarchi Gomes wrote:
>> mthp_collapse() tries to swap in PTEs when collapsing a mTHP if there are any
>> swap PTEs in the PMD range, even if none of those swap PTEs are
>> actually part of the mTHP's range.
>
> Are you sure? I wonder how you tested your patch? Because we never swapin PTEs
> for mTHP collapse, see the code in __collapse_huge_page_swapin():
I'm confused as well, this doesn't really make sense.
--
Cheers,
David
next prev parent reply other threads:[~2026-08-27 11:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-25 19:24 Pedro Demarchi Gomes
2026-08-26 4:43 ` Lance Yang
2026-08-27 8:06 ` Baolin Wang
2026-08-27 11:02 ` David Hildenbrand (Arm) [this message]
2026-08-27 12:11 ` Lance Yang
2026-08-27 14:07 ` Kiryl Shutsemau
2026-08-28 3:24 ` Pedro Demarchi Gomes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d02405a5-1d0d-49d5-9056-1a34ccdeef10@kernel.org \
--to=david@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=dev.jain@arm.com \
--cc=lance.yang@linux.dev \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=nico.pache@linux.dev \
--cc=pedrodemargomes@gmail.com \
--cc=ryan.roberts@arm.com \
--cc=usama.arif@linux.dev \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®