mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Grygorii Strashko <grygorii.strashko@ti.com>
To: Jeroen Hofstee <jhofstee@victronenergy.com>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Cc: "Koen Kooi" <koen@dominion.thruhere.net>,
	"Benoît Cousson" <bcousson@baylibre.com>,
	"Tony Lindgren" <tony@atomide.com>,
	"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARM: dts: am335x-sancloud-bbe: Fix PHY mode for ethernet
Date: Wed, 2 Oct 2019 17:48:35 +0300	[thread overview]
Message-ID: <d027ef07-807d-6a7b-2939-b67be4542469@ti.com> (raw)
In-Reply-To: <20191002095416.19603-1-jhofstee@victronenergy.com>



On 02/10/2019 12:54, Jeroen Hofstee wrote:
> cd28d1d6e52e: ("net: phy: at803x: Disable phy delay for RGMII mode") broke
> the ethernet networking on the beaglebone enhanced.

Above commit is incorrect (by itself) and there are few more commits on top of
it, so pls. update reference to commit(s)

bb0ce4c1517d net: phy: at803x: stop switching phy delay config needlessly
6d4cd041f0af net: phy: at803x: disable delay only for RGMII mode


> 
> The board relied on the bug in the at803x driver to always enable the rx
> delay. So change the phy-mode to rgmii-id so it is enabled again.
> 
> Signed-off-by: Jeroen Hofstee <jhofstee@victronenergy.com>
> cc: Koen Kooi <koen@dominion.thruhere.net>
> ---
>   arch/arm/boot/dts/am335x-sancloud-bbe.dts | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/am335x-sancloud-bbe.dts b/arch/arm/boot/dts/am335x-sancloud-bbe.dts
> index 8678e6e35493..e5fdb7abb0d5 100644
> --- a/arch/arm/boot/dts/am335x-sancloud-bbe.dts
> +++ b/arch/arm/boot/dts/am335x-sancloud-bbe.dts
> @@ -108,7 +108,7 @@
>   
>   &cpsw_emac0 {
>   	phy-handle = <&ethphy0>;
> -	phy-mode = "rgmii-txid";
> +	phy-mode = "rgmii-id";
>   };
>   
>   &i2c0 {
> 

-- 
Best regards,
grygorii

  reply	other threads:[~2019-10-02 14:48 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-02  9:54 Jeroen Hofstee
2019-10-02 14:48 ` Grygorii Strashko [this message]
2019-10-03  8:16   ` Jeroen Hofstee
2019-10-03  9:31     ` Grygorii Strashko
2019-10-08 14:23       ` Tony Lindgren
2019-10-08 14:46         ` Jeroen Hofstee
2019-10-08 16:02         ` Jeroen Hofstee
2019-10-08 16:14           ` Tony Lindgren
2019-10-08 16:42             ` Jeroen Hofstee
2019-10-08 16:51               ` Tony Lindgren
2019-10-08 16:59                 ` Jeroen Hofstee
2019-10-08 17:02                   ` Tony Lindgren
2019-10-09  9:43                     ` Grygorii Strashko
2019-10-09 10:09                       ` Jeroen Hofstee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d027ef07-807d-6a7b-2939-b67be4542469@ti.com \
    --to=grygorii.strashko@ti.com \
    --cc=bcousson@baylibre.com \
    --cc=jhofstee@victronenergy.com \
    --cc=koen@dominion.thruhere.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®