From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751863AbdKVVZE (ORCPT ); Wed, 22 Nov 2017 16:25:04 -0500 Received: from mout.web.de ([212.227.17.11]:57105 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751447AbdKVVZA (ORCPT ); Wed, 22 Nov 2017 16:25:00 -0500 Subject: [PATCH 2/2] ASoC: cs42l52: Improve two size determinations in cs42l52_i2c_probe() From: SF Markus Elfring To: alsa-devel@alsa-project.org, Brian Austin , Jaroslav Kysela , Liam Girdwood , Mark Brown , Paul Handrigan , Takashi Iwai Cc: LKML , kernel-janitors@vger.kernel.org References: Message-ID: Date: Wed, 22 Nov 2017 22:23:41 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:NHdHkkw4mseaBylpaZGWq3mRVm2RaJoHSswp6syQz2FqQRIl8SP RMhKPXU2T8NohC4Mw1GpIxZhQ6hzeRJNVqU0wzrjPtCJwuK0TUqi7FXeJf1mlrB7RV+gs6u lxfL5ayMW59no954Eb5TDyO55MI0535Jlrtb26zS3To2L1jcDdJBmN5tdeDpASeR5NVIPcl 0A5SiOyCCBYAA78CzwsFA== X-UI-Out-Filterresults: notjunk:1;V01:K0:uyPx1Xkf2MQ=:9cYOrxztHTOlMB5pQEgh1L unmQaYXA8av0qF6W1Xy4emF+vf5SaKlh0CC8M6t0A/51FOzKVqoI06P3tO72MJJoN++YbE9yT MGooSLk0gvrFZBio9Pg6/KYNkEc2Xz1tCu7hLPVoUqQpqt5Dv1+FakmR3qfvixLPPlHJXSy6U S9RKy1ctXEmZn/nEqZe1wj4KihOxwIskzgq/v2JNv47C2rhGABYK6568JyXxrGR3XZRaKoIEl 8gIe1RXW9ga8zg4o6PDEaGh/hgdhpo1oMxd+imG8UGAhVW3z9UVCjCJOR3jajGVf5vaY0052Z pBOMp6cJQyAGdPGDWkrdysS19dIeoiNzEztCY1lono+YIpZMP2wKH+0JyNpexpeGzZwpGuaL6 SEfNVzyvPfPFWf1xtdS0cbuHAVqwKnmIe11SGjPVB1NPIl8mWLHbqdg+9tDPdwkF/Ul09mLnT yluQYVyBV0tTqWOl3Ar2Hot66ZthFFMIl4SZpnwHeFAsLL4AVztHSICyBRcxhE5h1imPPLWC1 gsSlMm8hHUMSeFl6zmAC1bjnWfkw/NxYnMbHYgtK6yVlo4xYdidXjR9DwO2AoNvz7wfCVx4eQ qWkQ6yPXLaGyb/Q82ppMDOL9czWoz3e6X+Q+LmqetTJyfOV61DVME59auoxSsBwgfRWaa2rDB aVV+g4GBKA84btzFKCL4ftKYljZGs7PcAm92eHOPzXt0FuxTESF0eBDhpmxido9M+5UFHQ4Nt hBBL8Ani+ys8h45GF90pd9WT3ULS6hZmfjf5DgT7L5dwmQL7LZwBIg2q7sM1dYSOloldH5Zrm c7tn+ccE2sKDFgNbYPuvAFaXDiG4pg/JuCMue6SYxtMNWId7h8= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Wed, 22 Nov 2017 22:11:30 +0100 Replace the specification of two data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- sound/soc/codecs/cs42l52.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/sound/soc/codecs/cs42l52.c b/sound/soc/codecs/cs42l52.c index e8645f2ac0d9..9731e5dff291 100644 --- a/sound/soc/codecs/cs42l52.c +++ b/sound/soc/codecs/cs42l52.c @@ -1100,8 +1100,7 @@ static int cs42l52_i2c_probe(struct i2c_client *i2c_client, unsigned int reg; u32 val32; - cs42l52 = devm_kzalloc(&i2c_client->dev, sizeof(struct cs42l52_private), - GFP_KERNEL); + cs42l52 = devm_kzalloc(&i2c_client->dev, sizeof(*cs42l52), GFP_KERNEL); if (cs42l52 == NULL) return -ENOMEM; cs42l52->dev = &i2c_client->dev; @@ -1115,9 +1114,8 @@ static int cs42l52_i2c_probe(struct i2c_client *i2c_client, if (pdata) { cs42l52->pdata = *pdata; } else { - pdata = devm_kzalloc(&i2c_client->dev, - sizeof(struct cs42l52_platform_data), - GFP_KERNEL); + pdata = devm_kzalloc(&i2c_client->dev, sizeof(*pdata), + GFP_KERNEL); if (!pdata) return -ENOMEM; -- 2.15.0