From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D4A2C24A06D for ; Tue, 25 Aug 2026 06:37:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787639839; cv=none; b=X6XazS2/hNq6hFy/yrN2wbIdxwdwWGxgdNH3bZfqMGEele2BsYp+/A25/DLNJGOHw6Jgolxz8CfrC6KJ4UL1+pKQBWbcHDtWjaativ7WI6mwgxoWLnmZNIoGScrGvnAsy+Cag8GR1ZOCgoTnvtWOfp7mdT0+y+XaJJ41DWuoFGI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787639839; c=relaxed/simple; bh=rExle40my1IOYHoCCnlLOu0wao//1RwYDpYC+rzLP1I=; h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From: In-Reply-To:Content-Type; b=V5k4nK3ePvGFbqx978lL5/hQz0Z9L/oDM6y/IO1tjqVksWrAUJGjmXBESnE7XGNTgDk7ziL648Jzj9sWrLt971DxZG7P7HixHPElnIQH7Kc1D3omg3hHuTY6hEFDNQqaFgWLVIKznXybMRBgRJvXgFOuwEmXk3elSZ9kyf3PbOY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=fBiqn5Ff; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fBiqn5Ff" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BB6D31F000E9; Tue, 25 Aug 2026 06:37:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1787639838; bh=T1juKe2OIJmSp+bgGiNvE3domWkVDZj0t45aNAKcz2U=; h=Date:Cc:Subject:To:References:From:In-Reply-To; b=fBiqn5FfPqLphRakGtAKr7LN8RI/lNcQURq0w18bGn3EcgcZdLPAneR8cwH7E9dJy /YVdAbjakTkKAR/zlPklWqERV3pMgh7L9IBrQ9wvmU+eLTwD4eWJ1kc1+UEykmlzot 4l1Zeo42T9vKxH4KZmBo6JAKhAs5o+OSmYmYVwCWWOgOVaajUGxdc/OcyPyV6ZKh0m 3uBcQ626vtKboly4Xql4r2r2HV/ffsnY0PDXceNPk96zkOAXDIh87NbO3ukgWsKt+y pksdzbCfSCxyPYKPIwjoUUf486yndSxJWXxLgJNveOVNP8/TwRs+I8hLF8+1+iLT37 1vRRVIFyJEGZA== Message-ID: Date: Tue, 25 Aug 2026 14:37:16 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: chao@kernel.org, Jaegeuk Kim , qiwenjie@xiaomi.com, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [PATCH v2 03/12] f2fs: cache: introduce shrinker To: Wenjie Qi References: <20260824134731.3704352-1-chao@kernel.org> <20260824134731.3704352-4-chao@kernel.org> <20260825054226.399346-1-qiwenjie@xiaomi.com> Content-Language: en-US From: Chao Yu In-Reply-To: <20260825054226.399346-1-qiwenjie@xiaomi.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 8/25/26 13:42, Wenjie Qi wrote: > Hi Chao, > >> spin_lock(&cache->list_lock); >> list_for_each_entry_safe(entry, next, &cache->lru_list, list) { >> if (isolated >= nr_to_scan) >> break; >> >> if (f2fs_cache_test_dirty(entry) || >> f2fs_cache_test_writeback(entry) || >> f2fs_cache_test_locked(entry)) >> continue; >> >> if (f2fs_cache_refcount(entry) != 1) >> continue; >> >> list_move_tail(&entry->list, &dispose_list); >> isolated++; >> } > > `isolated` advances only for an eligible entry. Entries skipped by the state > and refcount checks do not consume the `nr_to_scan` budget. > > Is `nr_to_scan` intended to bound the number of entries examined here, or only > the number of reclaimable entries isolated? Yes, better to consume nr_to_scan no matter what state of entry is. Thanks,