From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1035D318EFA for ; Fri, 23 Jan 2026 01:27:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769131685; cv=none; b=esttMdgSwIa6bvzzwhoQPT2fw0+vxkrpgNIsePtKHNSwLmLmTThHa2QWeinNyZqSJ8eznFcFSMcIeqkn3Q3FariP8sIKrF52sKW2MLpQy4NCg/X3seM0Mfbsd/wrQP02upzsUaW9vILl0IICOQT1lXcsgbUJFYDgG80Bzz9sAls= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769131685; c=relaxed/simple; bh=vAVCWN4R8VmDkjt8UP3zubrMPwp3HWU/dmWQ+AZC7io=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HqOUf3UDjd4T4lAmVLr3bQncv7TMkFEGkX06zFr/N20H/bev4rBVSuCPW7aBHFzEIcEHkbziysllSUJTEF6NrOLxNxr8L546pdDsW9lGAhhlmOxnYcJw3tgsSR30LHivB4rJA990t/fVmhgrdgj2oFaTxEKj69/bxJ457tg23dA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=TkPKQxZK; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Dc9cVcBn; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="TkPKQxZK"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Dc9cVcBn" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60MK7Y9v1117264 for ; Fri, 23 Jan 2026 01:27:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= S9ilNfxsCAgF3/catfRgv/bNEw6+UvvAVmiznKDkFLs=; b=TkPKQxZKY18/K1T6 /glZzMFAAMzoQdwb94/IWwrZ9r36Z8AP7PuT13/n0NAt9LDji+3JGPSXfgwALrr1 dXAqlGFWFng6pMbzO3TCmdBP6kr0PnJSd3pr3+nmxSpbLC8ihb/xhEH58ZNZi8qG WSuB/huyQoJXUmOq9IN4vISWnSJmGzIaIoB8AYMdrDba+CytYbR42KjFpp+G8bVV 4WcHF+qcIbpUd2daKtU6KjisqSwGK7uzStIGkrqU82b1O2hIL5tQpmIr6aykvr+O QJaqdiaebxb7TKffJiwQtZTl3tayvxOKbPoc37y9JGN+dqE1R73hRYZn3QCXYQFi KhIWvA== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bur1c9bry-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 23 Jan 2026 01:27:47 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-352e195f662so1354035a91.2 for ; Thu, 22 Jan 2026 17:27:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1769131667; x=1769736467; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=S9ilNfxsCAgF3/catfRgv/bNEw6+UvvAVmiznKDkFLs=; b=Dc9cVcBn5O4Qypn0dHIGgQW4PZNQMalqFM1fvnTtCjZQKDa2AWNElFEpc6B1eWD+DF 7QogDAzK/iUc6rYn+L/405eo0zLJxsAVYpYLxsX9gq0gcHdPIrrwcGtVAydia3ccIKEv et74Q1lF6LmHfde2l+X2HirJti4RiRmet5ZXkDVnTyBWO3CJbZn++QuRpPtyr+B2CWZ+ LC36BTCdZugZTORs+E9oVDEz6dlOyfs0NTpZ03wl+z20U4V+etRWOT8N0JTSoGNmKdY9 UovOYhZNeaT2iRECuDMEYRCGB/GFsVjvn5HV3RUCCJMrlOCqXcOt9nw3+wrsfWu2+Q3A 5Jpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769131667; x=1769736467; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=S9ilNfxsCAgF3/catfRgv/bNEw6+UvvAVmiznKDkFLs=; b=hOlIuV9HhTrDSz0nW6R9wNeC78k6ksHnI7BIsKYDHeXH1Aqz4zQHaistZPmVd3ZSpF 5zkhfld6g533U0bK3vWvN4y9MxD4C4L+ACFUTodfwXVj5N6CCZQY6ifAemrtg/AlcT4d OlmndtlnWVYhlHeMsllT8v99/V3dQnWvAKfpEf17YYycv291NY16keC/0L+KdwL4mTl0 WfNqNuFnHBPvqbZVAAgDH4tiMX81iN13lRxuRYMOCm/tPUw3du6NLVqhGN4PVflOqT+u 4RC+uIE4rTxH+TLXHnZ7pg6WcFvTraGb/umv/Z2xfxEtZnPrOmrnPmFMTbiVWe1bqcFe VszQ== X-Forwarded-Encrypted: i=1; AJvYcCUQ3SRwS4j/vHdA7e70VyGkUpgOhiCyOu16VXGx+6a7hbiSh9K8xuQDNHf1w77Xf97QBO1rC4r6hcje7Zk=@vger.kernel.org X-Gm-Message-State: AOJu0Yw9nNWgWRvdVXGVI//EgfLqfWnhXiT69B1xGd6ONnAlCNOQBn+w h2mUj+9bte+arwSgRE4qTQPDjtqY5vUuh77XmTB3GF6CtOMq4/sIP+8BUAkb78dOQOtBnOg75jR UpIwJ456kMoJCMRhxUIkwdKWsuNhkBXGmbNr+v/MjyS9nReV0Y6kGjvgdMfE/7Z8RguU= X-Gm-Gg: AZuq6aJnsbU/rlOTfpl2Ymb++W3mKZSDn/cpNIoYtKH9KuWkOLF5hbmzvld7byyhj27 6zfaa8jyzfatO9QSEsiLYI94bdaYS+LAF4t07ls+u3+TroYTOZaA2HRawRo23KcXf2rLMPHHp8H Cwt3t8U74fBi2WTY1uZ64Ng+nBBuUi/Jp9ZzBbuy2HKGYqbJdkqycnCbaE/XtlughHM+hLL80fo yQ04dKUOug32OAjvdYaWBHVSZ6iOLBhpfCUoX4x2GgmonyU5lxmxCjSY9f2/08sG1nzPHZwp/0T E2wJb0qa6xBnai3BY2Sh7/QpUmshKN/pWUrntK6qpcfJDIOsuRLWj9/Z1P+cwHHCx0tN4zpVdG/ N6FUWLQxQFFOCplrBg4+GdOrcN+qtemOgpY8QPOT+mezfgUvqoEBQsm7UBktxvvZ1WJTKbg3mYH I= X-Received: by 2002:a17:90b:224b:b0:34c:aba2:dd95 with SMTP id 98e67ed59e1d1-35368b44712mr1380903a91.26.1769131666709; Thu, 22 Jan 2026 17:27:46 -0800 (PST) X-Received: by 2002:a17:90b:224b:b0:34c:aba2:dd95 with SMTP id 98e67ed59e1d1-35368b44712mr1380868a91.26.1769131666182; Thu, 22 Jan 2026 17:27:46 -0800 (PST) Received: from [10.133.33.105] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-353355e1161sm3480323a91.17.2026.01.22.17.27.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Jan 2026 17:27:45 -0800 (PST) Message-ID: Date: Fri, 23 Jan 2026 09:27:38 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v10 1/8] coresight: core: Refactoring ctcu_get_active_port and make it generic To: Suzuki K Poulose , Mike Leach , James Clark , Alexander Shishkin , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Tingwei Zhang , Mao Jinlong , Bjorn Andersson , Konrad Dybcio Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org References: <20260122-enable-byte-cntr-for-ctcu-v10-0-22978e3c169f@oss.qualcomm.com> <20260122-enable-byte-cntr-for-ctcu-v10-1-22978e3c169f@oss.qualcomm.com> <525fe4ad-3d3e-4c05-a6f5-da91157f362e@arm.com> Content-Language: en-US From: Jie Gan In-Reply-To: <525fe4ad-3d3e-4c05-a6f5-da91157f362e@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=FswIPmrq c=1 sm=1 tr=0 ts=6972ce93 cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=fsjGGd5fPUumY84vGlEA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: -Sf5Ug1LkggID-5AU_Wk7eqWIeKwSDTx X-Proofpoint-GUID: -Sf5Ug1LkggID-5AU_Wk7eqWIeKwSDTx X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTIzMDAwNyBTYWx0ZWRfX5CiH7OxORuZB abeD4nKPRQd8E16Bi+JR7UBaZYZfE6sQzO8x6/0+LWekRmFzM+DfqCXbZE2Yp+61ufu2MFCkBUZ Hkz7VdMgKPqieJwXHjB4071Ejk8fPFwxmMtq/SrIKZcMC9+dElWjH54aFZ40DaLM0460kJReuwG 8sxlM7tkBx2fgIYDuynmqgCOFaCeEgiLGq69pdGth6VQwJBfar5B7QoD4KSLaLkgkESUu6PGp38 oy1K46+kiU3AohJBkOsOKehyXi3fZ/X0/z2ZoFOihD/1JU0QII2HDTgNnuxw+J/ulTVLLi2Hczs YqaNcZATASgsluiDg1tZ8+1ogn6sHM7/tEnV3yG08LmRewHlvlsYdrief6HtBWhIaBdylTRfi7G whhpLJpvmVKZEio5Ev+bywevD8h36n+szCQYlcWVTm4+BU+LEGy3SvK4U7GuxKRjn/+/jUfeGy7 jBcAtZlJcWcZVhSNf3A== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.20,FMLib:17.12.100.49 definitions=2026-01-22_06,2026-01-22_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 malwarescore=0 spamscore=0 priorityscore=1501 phishscore=0 lowpriorityscore=0 bulkscore=0 adultscore=0 clxscore=1015 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601230007 On 1/22/2026 6:00 PM, Suzuki K Poulose wrote: > On 22/01/2026 02:08, Jie Gan wrote: >> Remove ctcu_get_active_port from CTCU module and add it to the core >> framework. >> >> The port number is crucial for the CTCU device to identify which ETR >> it serves. With the port number we can correctly get required parameters >> of the CTCU device in TMC module. >> >> Reviewed-by: Mike Leach >> Signed-off-by: Jie Gan >> --- >>   drivers/hwtracing/coresight/coresight-core.c      | 24 +++++++++++++ >> ++++++++++ >>   drivers/hwtracing/coresight/coresight-ctcu-core.c | 19 >> +----------------- >>   drivers/hwtracing/coresight/coresight-priv.h      |  2 ++ >>   3 files changed, 27 insertions(+), 18 deletions(-) >> >> diff --git a/drivers/hwtracing/coresight/coresight-core.c b/drivers/ >> hwtracing/coresight/coresight-core.c >> index c660cf8adb1c..0e8448784c62 100644 >> --- a/drivers/hwtracing/coresight/coresight-core.c >> +++ b/drivers/hwtracing/coresight/coresight-core.c >> @@ -585,6 +585,30 @@ struct coresight_device >> *coresight_get_sink(struct coresight_path *path) >>   } >>   EXPORT_SYMBOL_GPL(coresight_get_sink); >> +/** >> + * coresight_get_in_port: Find the input port number at @csdev where >> a @remote >> + * device is connected to. > > This doesn't match the code ? > > We are looking at the remote devices' in_connections ? csdev here is the coresight_device of the TMC_ETR. We would like to find the in-port number of the CTCU device(remote) which is connected to the TMC_ETR device(csdev). The description is incorrect, and I will update it in next version: Find the input port number at @remote where the @csdev device is connected to. Thanks, Jie > >> + * >> + * @csdev: csdev of the device. >> + * @remote: csdev of the remote device which is connected to @csdev. >> + * >> + * Return: port number upon success or -EINVAL for fail. >> + */ >> +int coresight_get_in_port(struct coresight_device *csdev, >> +              struct coresight_device *remote) >> +{ >> +    struct coresight_platform_data *pdata = remote->pdata; >> +    int i; >> + >> +    for (i = 0; i < pdata->nr_inconns; ++i) { >> +        if (pdata->in_conns[i]->src_dev == csdev) >> +            return pdata->in_conns[i]->dest_port; >> +    } > > Suzuki >