From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 08B54264A65 for ; Sun, 7 Dec 2025 14:43:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765118625; cv=none; b=JfLxWwjbBzYMAYb/U+/yZhaw3LhO3jrx2dtBuQWCZUHpwdnQ8CBTMVZ3WTDqomPOys0bmrNXKHqCEIjpv1CNob0SocLohsIQrqC3niEyXZ8MUsrfk0JBLcJ0bEuBg6yE094D0x5btQPeBqUWj2QS1QE/tTvvcXobGLllBk/5Yko= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765118625; c=relaxed/simple; bh=N/AlMPNy9lcY4VhplAEjXH+tZcWwQ6XaS+OqFJZACXY=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=TnGyK4q48qkRTaFfrmyH7JB5Q6a8zve8fLn+WHhJEx3uJkMHSQnqYvurnJdARMBGqumY8VLpe8vQaUxFRS7Or8RwJen7GSlzK3EbUAVEceggX8fVo45KHpNvvBgXCG0M9bgc9vn9jMhzbFHqsPyUFlIdZJjI7gCN+OgHgjRsuCY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=BKHHXiJ+; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=jfGtuU5e; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="BKHHXiJ+"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="jfGtuU5e" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5B79QlE61517791 for ; Sun, 7 Dec 2025 14:43:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= l/aaJFyQoXHpvQwzDEFmgidOgL9qCsCAZ9X7taPnYrc=; b=BKHHXiJ+nUEgoKku Fvdz+fmK+FjsgKxZvxrHErBn1BTMTXrQtN6eF4q+UmlcdMVIoiLfQoTWqkRKrz3Q NnvkBLXs2STX9raqgwHxWKLOZtVpbFqWsroT21Nvw+ZGvzMdD4ZDLlfqA4wA93oj nxs1RacIE7DhSoQOixd2ymfpIp1UDMrFNf3Zq+sWidv/x00ef8EjN1gbcxDt8wtl ycdaIk48S9hSodcpgkOOqwIEPVbu8ihMcCBpXjuAkbl0i8apeTOeeXB7yZYGwF9j fTpFkN6IvxkexpQPdH908sxJfjUG6w61KnwfxA4FxhhTKoeKX4BkhqyQWIU32YMW rhGyVg== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4avd8e2g73-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 07 Dec 2025 14:43:36 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-8b19a112b75so342613785a.1 for ; Sun, 07 Dec 2025 06:43:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1765118616; x=1765723416; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=l/aaJFyQoXHpvQwzDEFmgidOgL9qCsCAZ9X7taPnYrc=; b=jfGtuU5eF7mVO1xeSjNI20lNYgGrcjIqDL4eRZfedWoj2gWlrI2SIkwnGAGwvuonpE BMCRmU4Wc1WzNjkTovuYWyZmY+bTDSgQOnoRTfEm4vzMGJfcvs6nK5F05gfi2PJCvTFg 0rg2REjzJ++BshJ7WP9rWclEOTqVghNnSPgJcV+OwBQlW3Tjgkcn242HB9kR+L04lrXF KifUFE8Nqmkl7BqiGy+fEqBKeWu4bvivVaLxp9lG1WuVPa/85joTvyiUAHO98sBqUfiw ZQF5zCNZIBkLTtmELyNglHN1dVHtVhba5BZxEkY3uxaFceU4NRj6LsI+RuLLDAW12kSG CNNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765118616; x=1765723416; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=l/aaJFyQoXHpvQwzDEFmgidOgL9qCsCAZ9X7taPnYrc=; b=IGhbQLTuryFS5JoMaNbWZCZP4C6pOqKERbco372kvwND9gitBkfAUI4Z1f3nEpCEdD UwCXS+7GSRZojZ0J5uI6hpRbmPDPQyMLbiay6neJy4IuRm9NLnJhNRtYPyLtdgptrEu1 ENV0SE/flmIVKM0XCU6ET8SLZlrhu1SixpM5m0S7mPanHqEWlY1/AW+lBKlkXW2Id9BB LhudWSD3uXU7aWXJ2ZqCqErFeVeYnqZVog7VrignMLEqERmZnhf8PSwbo0a8sFtUjXAq caTXPt1ulQCLT3tJflYJjRvWUIU5oJFp3sR+jY8e7KVA9nK8oK++vxcQBv9gEP6pigLN HCnw== X-Forwarded-Encrypted: i=1; AJvYcCVnE+DpBVNpOr1hf3WfGLvExiarZ2yAc7Q0L5zdSKyst7ilEqopcRLubaRFGUUsvX6HqgA+qIcTUe3gDfg=@vger.kernel.org X-Gm-Message-State: AOJu0YyTo7+H3TF+VNSdJP6+PfUROlWsQZ9gsCyERWeWPP36vSqJtxdv lpt6U/uRlfrr2UW6HKxwwqCKQUIFbEomuqpfwK5dqXBGErjbjIRqQNnVLkgnAUBbJYBEhRwdyL1 9FFCdUdW9trVmLprAtDsOD/4v5t1ZkVoCObQpA0THwrgXQncWwVfMhewr4zh5XZ2Y25M= X-Gm-Gg: ASbGncuhNyBiqpJXumRsu7wP5Y10JNHCv6KQMwoQs4oxuJIOld/g2jhZ9FigvIntQKa 7t0XGfCTQwjEpoUBP/ld9es0psrG7vzIjh8hj+ll2g5+97eTXCm+h+pBDuss9DHl8JDZx9VL/pT 2Ihg/2RrqcXRN3uT+7FwRqNeEAsXFgLfeZLbmmEVwYzqIuXz9SMH1hg7AyOI9lf19ZAYyX1eWYk r4j0vv7CCaEjP6gOCTU6bHNlAk+YX3hDv2Xovm/xO4pQTmxkuAZRXiL7TMakypcnP4tppnUwxwP W2VBJIgTkNC0ULuizjSTYGULfN6LqdzOnZBEvmq44lrDb0Lkxogh5p/Y+xDYcQFB18T6jCR7a7X uCgqvC57u2Oync4SAYwYA/1nh2rJ8CxE9QdjUEDuASMOSNlGVxjqMlAAxQa2KOGWOjKMrY6GvGg ZsRFnvZbetIRGejxoLAFhBXFuN5/KyQTz/5GrOsKtd/QNhbhILcvtr2/G58z3uA+uSz6CweVH5N 2qU X-Received: by 2002:a05:620a:2a11:b0:8b2:e7db:253d with SMTP id af79cd13be357-8b6a2388c05mr637280385a.38.1765118615662; Sun, 07 Dec 2025 06:43:35 -0800 (PST) X-Google-Smtp-Source: AGHT+IH0XFmkIf34WFVbXKGLe44+OBlysT3op2/v7IyhvdnovY4Uv/rO0mzOwvjhifu9aaaI5NRsOQ== X-Received: by 2002:a05:620a:2a11:b0:8b2:e7db:253d with SMTP id af79cd13be357-8b6a2388c05mr637277785a.38.1765118615137; Sun, 07 Dec 2025 06:43:35 -0800 (PST) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b79f49d24a6sm847908466b.54.2025.12.07.06.43.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 07 Dec 2025 06:43:34 -0800 (PST) Message-ID: Date: Sun, 7 Dec 2025 15:43:33 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: johannes.goede@oss.qualcomm.com Subject: Re: [PATCH] platform/x86: int3472: Use actual clock frequency for DSM method To: Sakari Ailus , Bingbu Cao Cc: Hao Yao , platform-driver-x86@vger.kernel.org, hdegoede@redhat.com, dan.scally@ideasonboard.com, ilpo.jarvinen@linux.intel.com, bingbu.cao@intel.com, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251205095525.1264971-1-hao.yao@intel.com> Content-Language: en-US, nl In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjA3MDEyOSBTYWx0ZWRfXza17zTJpxyR+ tul0GA1irxXSKikcQGZtW1LRXHdyi+eFz1UXYC8JZECsTPDyLZ98E4aJ1ERwPeyG9TOtkXzvNDq DtHsxMmjP0t86yihvrh1YYNV6zw0Gv312SdvmBUkoexWQSlAuekadaRtRePpP0IPypC1aI55aoQ 64bXaXRVUDKiwbY4r/u4Z/e5ZMBa1qtt3sDpOnEwIUFof2pbu9GBxJV5fHd53UQ4tWQkE13lX4C dheJgJ6XP4fKOkCouRM3dz4i0bjdmCxmfmdoBdWKmxzZ2dXNNRLLy2N+DYzD8uDpH3RtpGyls9L KWpw9PORFUBqQVxYqmFgo0Ab0+I5wcOpbCi7F4syH+2TKXAdg6XGdlAXXjnaSKU1PE3OHakw5NV u7g3pvLWn1NwcBuOHYW4pKE70FrrtQ== X-Authority-Analysis: v=2.4 cv=BqaQAIX5 c=1 sm=1 tr=0 ts=69359298 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=AdU8BewJLfuzazTBXZYA:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-GUID: RlX-es1R7LEACvdqYN37eJ2jBp0d1x1Y X-Proofpoint-ORIG-GUID: RlX-es1R7LEACvdqYN37eJ2jBp0d1x1Y X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-06_02,2025-12-04_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 clxscore=1015 phishscore=0 spamscore=0 lowpriorityscore=0 impostorscore=0 adultscore=0 priorityscore=1501 bulkscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512070129 Hi, On 5-Dec-25 8:05 PM, Sakari Ailus wrote: > On Fri, Dec 05, 2025 at 06:10:10PM +0800, Bingbu Cao wrote: >>> +#define PCH_CLK_FREQ_19M 1 >> >> I like 19P2MHZ. > > How about simply PCH_CLK_FREQ_19M2? +1 for this, this is the standard way to write fractional MHz clocks. With that fixed / so for v2: Reviewed-by: Hans de Goede Regards, Hans