mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yu Kuai <yukuai1@huaweicloud.com>
To: John Garry <john.g.garry@oracle.com>,
	Yu Kuai <yukuai1@huaweicloud.com>,
	tglx@linutronix.de, akpm@linux-foundation.org,
	ming.lei@redhat.com, axboe@kernel.dk
Cc: linux-kernel@vger.kernel.org, yi.zhang@huawei.com,
	yangerkun@huawei.com, johnny.chenyi@huawei.com,
	"yukuai (C)" <yukuai3@huawei.com>
Subject: Re: [PATCH v2] lib/group_cpus: fix NULL pointer dereference from group_cpus_evenly()
Date: Fri, 20 Jun 2025 09:10:59 +0800	[thread overview]
Message-ID: <d03be22a-ff9f-cc1e-7739-7c455c6d9345@huaweicloud.com> (raw)
In-Reply-To: <9024faaf-d4e3-4699-8b7c-df6650bd6f3b@oracle.com>

Hi,

在 2025/06/19 22:08, John Garry 写道:
> There's a non-SMP version of group_cpus_evenly() at the bottom of 
> lib/group_cpus.c
> 
> It also does a kcalloc(numgrps, ...)
> 
> Does that need to be fixed as well?

Yes, you're right. Just run the test with SMP disabled, and the problem
can be reporduced as well.

Thanks,
Kuai


      reply	other threads:[~2025-06-20  1:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-19 13:26 Yu Kuai
2025-06-19 13:45 ` Ming Lei
2025-06-19 13:52 ` Jens Axboe
2025-06-19 14:08 ` John Garry
2025-06-20  1:10   ` Yu Kuai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d03be22a-ff9f-cc1e-7739-7c455c6d9345@huaweicloud.com \
    --to=yukuai1@huaweicloud.com \
    --cc=akpm@linux-foundation.org \
    --cc=axboe@kernel.dk \
    --cc=john.g.garry@oracle.com \
    --cc=johnny.chenyi@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ming.lei@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=yangerkun@huawei.com \
    --cc=yi.zhang@huawei.com \
    --cc=yukuai3@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®