mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tammo Block <tammo.block@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jslaby@suse.com>
Subject: [PATCH v1 4/6] vt/vt: Add SRG mouse reporting protocol
Date: Tue, 30 Jun 2020 09:11:28 +0200	[thread overview]
Message-ID: <d0435e5d32f1b14033d3c4ba22457356e8ae85b3.1593499846.git.tammo.block@gmail.com> (raw)
In-Reply-To: <cover.1593499846.git.tammo.block@gmail.com>

The SRG protocol indicates a button release by appending a "m" to the
report. In this case the button number is not 3 ("release state") but
the number of the button that was released. As release event are only
reported for the first three buttons, we need to store the number on
click events because it is not sent to us from userspace.

We also need to check for the case where no button state change occurred
at all (bit 6 set), in this case a value of 3 is OK even in SRG.

Bitmasks for your convenience:
195 - All bits related to any button number
227 - All bits related to button number and "state not changed" bit
252 - All, except low button numbers (left, middle, right button)

Signed-off-by: Tammo Block <tammo.block@gmail.com>
---
 drivers/tty/vt/vt.c | 19 ++++++++++++++++---
 1 file changed, 16 insertions(+), 3 deletions(-)

diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt/vt.c
index e2324d8e4e74..36520f7f0315 100644
--- a/drivers/tty/vt/vt.c
+++ b/drivers/tty/vt/vt.c
@@ -183,6 +183,9 @@ core_param(consoleblank, blankinterval, int, 0444);
 static DECLARE_WORK(console_work, console_callback);
 static DECLARE_WORK(con_driver_unregister_work, con_driver_unregister_callback);
 
+/* remember mouse state */
+unsigned char last_button_pressed = 3;
+
 /*
  * fg_console is the current virtual console,
  * last_console is the last used one,
@@ -1840,11 +1843,21 @@ static inline void respond_ID(struct tty_struct *tty)
 
 void mouse_report(struct tty_struct *tty, int butt, int mrx, int mry)
 {
-	char buf[8];
+	char buf[20];
+	bool rel;
 	int len;
 
-	len = sprintf(buf, "\033[M%c%c%c", (char)(' ' + butt),
-			(char)('!' + mrx), (char)('!' + mry));
+	if (vc_cons[fg_console].d->vc_protocol_mouse == 1) {	/* SRG*/
+		/* For SRG release events, we send the last clicked button < 3 */
+		rel = ((butt & 195) == 3);
+		if ((butt & 195) < 3)
+			last_button_pressed = butt & 3;
+		if ((butt & 227) == 3)
+			butt = (butt & 252) | last_button_pressed;
+		len = sprintf(buf, "\033[<%d;%d;%d%c", butt, mrx + 1, mry + 1, rel ? 'm' : 'M');
+	} else							/* X10 */
+		len = sprintf(buf, "\033[M%c%c%c", (char)(' ' + butt),
+				(char)('!' + mrx), (char)('!' + mry));
 	respond_string(buf, len, tty->port);
 }
 
-- 
2.27.0


  parent reply	other threads:[~2020-06-30  7:11 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-30  7:09 [PATCH v1 0/6] vt: Add SRG mouse reporting features Tammo Block
2020-06-30  7:10 ` [PATCH v1 1/6] tiocl.h: Change/Add defines for mouse report Tammo Block
2020-06-30  7:55   ` Jiri Slaby
2020-06-30  7:10 ` [PATCH v1 2/6] console_struct.h: Two members " Tammo Block
2020-06-30  7:11 ` [PATCH v1 3/6] vt/vt: Enable mode change via escape sequence Tammo Block
2020-06-30  7:11 ` Tammo Block [this message]
2020-06-30  7:59   ` [PATCH v1 4/6] vt/vt: Add SRG mouse reporting protocol Jiri Slaby
2020-06-30  7:11 ` [PATCH v1 5/6] vt/vt: Add URXVT " Tammo Block
2020-06-30  7:12 ` [PATCH v1 6/6] Documentation: Describe console mouse reporting Tammo Block
2020-06-30  8:16   ` Jiri Slaby
2020-06-30 16:14   ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d0435e5d32f1b14033d3c4ba22457356e8ae85b3.1593499846.git.tammo.block@gmail.com \
    --to=tammo.block@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®