From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C67A0C433E0 for ; Wed, 17 Jun 2020 06:05:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9A6822080D for ; Wed, 17 Jun 2020 06:05:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="ldFy59vn" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726912AbgFQGFR (ORCPT ); Wed, 17 Jun 2020 02:05:17 -0400 Received: from fllv0016.ext.ti.com ([198.47.19.142]:57064 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726769AbgFQGFQ (ORCPT ); Wed, 17 Jun 2020 02:05:16 -0400 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 05H651rG119792; Wed, 17 Jun 2020 01:05:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1592373901; bh=pjgQJY6FtV2aSO68aw+isVN5H6rQrBZ0BarV7CeclmA=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=ldFy59vnuaLA/u87+fSXcqQRsUB1FMfZ07OUnq32bevnq5CuqguFk6/XIN+tU3b5b QzajJXonGLbCTYhJ7liLkJqF8XcR6NM3wvFilkEO57mLXav1z5rVRgnlWTAQRsftd+ mmEMIUL1z+KZBoKQCcf3OXJ7dxO5ulRadfJySHJE= Received: from DFLE109.ent.ti.com (dfle109.ent.ti.com [10.64.6.30]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 05H651lZ051995 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 17 Jun 2020 01:05:01 -0500 Received: from DFLE111.ent.ti.com (10.64.6.32) by DFLE109.ent.ti.com (10.64.6.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Wed, 17 Jun 2020 01:05:00 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DFLE111.ent.ti.com (10.64.6.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Wed, 17 Jun 2020 01:05:00 -0500 Received: from [192.168.2.6] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 05H64vko028969; Wed, 17 Jun 2020 01:04:57 -0500 Subject: Re: [PATCH 1/5] drm/omap: Fix suspend resume regression after platform data removal To: Grygorii Strashko , Tony Lindgren CC: , "Andrew F . Davis" , Dave Gerlach , Faiz Abbas , Greg Kroah-Hartman , Keerthy , Nishanth Menon , Peter Ujfalusi , Roger Quadros , Suman Anna , Tero Kristo , , , , Laurent Pinchart References: <20200531193941.13179-1-tony@atomide.com> <20200531193941.13179-2-tony@atomide.com> <16ba1808-5c7f-573d-8dd0-c80cac2f476e@ti.com> <20200603140639.GG37466@atomide.com> <47e286dd-f87a-4440-5bde-1f7b53e8b672@ti.com> <20200609151943.GL37466@atomide.com> <9ed70121-2a53-d2b3-051a-88eb83e6c53f@ti.com> <592501c9-2d94-b266-ae76-e383d3bffa29@ti.com> <20200616153042.GZ37466@atomide.com> <3f2855cc-48b8-ecb8-5d92-beeabe344b26@ti.com> From: Tomi Valkeinen Message-ID: Date: Wed, 17 Jun 2020 09:04:56 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <3f2855cc-48b8-ecb8-5d92-beeabe344b26@ti.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/06/2020 19:56, Grygorii Strashko wrote: > > > On 16/06/2020 18:30, Tony Lindgren wrote: >> * Tomi Valkeinen [200616 13:02]: >>> On 11/06/2020 17:00, Grygorii Strashko wrote: >>>> I think, suspend might be fixed if all devices, which are now child of ti-sysc, will do >>>> pm_runtime_force_xxx() calls at noirq suspend stage by adding: >>>> >>>>       SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend, >>>>                         pm_runtime_force_resume) >>>> >>>> Am I missing smth? >>> >>> Isn't this almost exactly the same my patch does? I just used suspend_late >>> and resume_early. Is noirq phase better than late & early? >> >> Well up to you as far as I'm concerned. The noirq phase comes with serious >> limitations, for let's say i2c bus usage if needed. Probably also harder >> to debug for suspend and resume. > > Unfortunately, you can't use PM runtime force API at .suspend() stage as pm_runtime_get will still > work and > there is no sync between suspend and pm_runtime. > The PM runtime force API can be used only during late/noirq as at this time pm_runtime is disabled. Yes, but which one... Do you know what the diff is with late/noirq from driver's perspective? I guess noirq is atomic context, late is nto? Dispc's suspend uses synchronize_irq(), so that rules out noirq. Although the call is not needed if using noirq version, so that could also be managed with small change. But I wonder if there's any benefit in using noirq versus late. Tomi -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki