From: Zenghui Yu <yuzenghui@huawei.com>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Lorenzo Pieralisi <lpieralisi@kernel.org>,
Marc Zyngier <maz@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Sascha Bischoff <sascha.bischoff@arm.com>,
Timothy Hayes <timothy.hayes@arm.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 3/3] irqchip/gic-v5: Fix error handling in gicv5_its_irq_domain_alloc()
Date: Mon, 25 Aug 2025 11:54:56 +0800 [thread overview]
Message-ID: <d04c798e-cce4-6e08-2632-0255d48b0564@huawei.com> (raw)
In-Reply-To: <c9ee3799-8b70-4109-aa13-2febaff9973c@sabinyo.mountain>
On 2025/7/18 2:45, Dan Carpenter wrote:
> There are two issues to fix in this code:
> 1) If gicv5_alloc_lpi() fails the original code was checking the wrong
> variable. Fix the mixup between "ret" and "lpi".
> 2) Clean up from all the previous iterations and not just the current
> iteration.
>
> Fixes: 57d72196dfc8 ("irqchip/gic-v5: Add GICv5 ITS support")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
> v2: In v1 I had the wrong goto if gicv5_alloc_lpi() failed. Also change
> the label name from out_free_lpi to out_free_irqs.
>
> drivers/irqchip/irq-gic-v5-its.c | 20 ++++++++++++++------
> 1 file changed, 14 insertions(+), 6 deletions(-)
Reviewed-by: Zenghui Yu <yuzenghui@huawei.com>
prev parent reply other threads:[~2025-08-25 3:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1752777667.git.dan.carpenter@linaro.org>
2025-07-17 18:45 ` [PATCH v2 1/3] irqchip/gic-v5: Delete a stray tab Dan Carpenter
2025-08-07 14:55 ` Dan Carpenter
2025-08-20 8:51 ` Lorenzo Pieralisi
2025-08-22 1:00 ` Zenghui Yu
2025-07-17 18:45 ` [PATCH v2 2/3] irqchip/gic-v5: Fix forever loop in gicv5_its_create_itt_two_level() error handling Dan Carpenter
2025-08-25 3:54 ` Zenghui Yu
2025-07-17 18:45 ` [PATCH v2 3/3] irqchip/gic-v5: Fix error handling in gicv5_its_irq_domain_alloc() Dan Carpenter
2025-08-25 3:54 ` Zenghui Yu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d04c798e-cce4-6e08-2632-0255d48b0564@huawei.com \
--to=yuzenghui@huawei.com \
--cc=dan.carpenter@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=maz@kernel.org \
--cc=sascha.bischoff@arm.com \
--cc=tglx@linutronix.de \
--cc=timothy.hayes@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®