From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D91CFC43613 for ; Fri, 21 Jun 2019 08:08:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AAF7A208CA for ; Fri, 21 Jun 2019 08:08:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726289AbfFUIIl (ORCPT ); Fri, 21 Jun 2019 04:08:41 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:38036 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726030AbfFUIIl (ORCPT ); Fri, 21 Jun 2019 04:08:41 -0400 Received: from DGGEMS410-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 7C9AAF193B3EFDC9476A; Fri, 21 Jun 2019 16:08:36 +0800 (CST) Received: from [10.151.23.176] (10.151.23.176) by smtp.huawei.com (10.3.19.210) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 21 Jun 2019 16:08:29 +0800 Subject: Re: [PATCH v2 2/8] staging: erofs: add compacted compression indexes support To: Chao Yu CC: Greg Kroah-Hartman , , LKML , , , Chao Yu , Fang Wei , Miao Xie , Du Wei References: <20190620160719.240682-1-gaoxiang25@huawei.com> <20190620160719.240682-3-gaoxiang25@huawei.com> <4274208b-63bc-6dfd-a2c8-a94d2fa5c8d7@huawei.com> From: Gao Xiang Message-ID: Date: Fri, 21 Jun 2019 16:08:30 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <4274208b-63bc-6dfd-a2c8-a94d2fa5c8d7@huawei.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.151.23.176] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2019/6/21 15:53, Chao Yu wrote: > On 2019/6/21 0:07, Gao Xiang wrote: >> This patch aims at compacted compression indexes: >> 1) cleanup z_erofs_map_blocks_iter and move into zmap.c; >> 2) add compacted 4/2B decoding support. >> >> On kirin980 platform, sequential read is increased about >> 6% (725MiB/s -> 770MiB/s) on enwik9 dataset if compacted 2B >> feature is enabled. >> >> Signed-off-by: Gao Xiang > > Reviewed-by: Chao Yu > >> +static int vle_legacy_load_cluster_from_disk(struct z_erofs_maprecorder *m, >> + unsigned long lcn) >> +{ >> + struct inode *const inode = m->inode; >> + struct erofs_vnode *const vi = EROFS_V(inode); >> + const erofs_off_t ibase = iloc(EROFS_I_SB(inode), vi->nid); >> + const erofs_off_t pos = Z_EROFS_VLE_EXTENT_ALIGN(ibase + >> + vi->inode_isize + >> + vi->xattr_isize) + >> + 16 + lcn * sizeof(struct z_erofs_vle_decompressed_index); > > use macro instead of raw number? OK, I will wrap it up in patch v3 too. Thanks, Gao Xiang > > Thanks, >