From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE9B6C433B4 for ; Tue, 11 May 2021 01:43:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CE22C6162C for ; Tue, 11 May 2021 01:43:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230424AbhEKBox (ORCPT ); Mon, 10 May 2021 21:44:53 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:5097 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230401AbhEKBov (ORCPT ); Mon, 10 May 2021 21:44:51 -0400 Received: from dggemx753-chm.china.huawei.com (unknown [172.30.72.56]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4FfLHK23zFzYY1p; Tue, 11 May 2021 09:41:17 +0800 (CST) Received: from [10.136.110.154] (10.136.110.154) by dggemx753-chm.china.huawei.com (10.0.44.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Tue, 11 May 2021 09:43:43 +0800 Subject: Re: [f2fs-dev] [PATCH v2] f2fs: support iflag change given the mask To: Jaegeuk Kim , , References: <20210506191347.1242802-1-jaegeuk@kernel.org> From: Chao Yu Message-ID: Date: Tue, 11 May 2021 09:43:42 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.136.110.154] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggemx753-chm.china.huawei.com (10.0.44.37) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/5/10 22:42, Jaegeuk Kim wrote: > In f2fs_fileattr_set(), > > if (!fa->flags_valid) > mask &= FS_COMMON_FL; > > In this case, we can set supported flags by mask only instead of BUG_ON. > > /* Flags shared betwen flags/xflags */ > (FS_SYNC_FL | FS_IMMUTABLE_FL | FS_APPEND_FL | \ > FS_NODUMP_FL | FS_NOATIME_FL | FS_DAX_FL | \ > FS_PROJINHERIT_FL) > > Fixes: 4c5b47997521 ("vfs: add fileattr ops") > Signed-off-by: Jaegeuk Kim Except fixes line issue pointed out by Eric, other part looks good to me. Reviewed-by: Chao Yu Thanks,