From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70EF428FD for ; Mon, 13 Jan 2025 07:20:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736752835; cv=none; b=CDtSCSKGeuMAUMnOsCIZJSdQhT4ZTuPQZDfDeu+jzIMe2hAUquIfHyLeSaaEX/erQnvA0qs0uLSXGPKQJQo8eeo/HPgduZYdydesw2fMsUo4TE3oNxcwANyN0F9EARyionixxoar4yn2ODdlQ1/DzC9yug353QO2zCUPxe9swxg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736752835; c=relaxed/simple; bh=dpgutzoZVQgIvyG8LwfoLuacQkUA104t3dPq0gpkI6o=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=atWLNPePuyTT8EY5rKPwyj9W4j4TQYyrN3dY/etGKFtWbFJNU9v6XCM1xFRWwlIshXAEQszLqNq0vcA7tDHg/C0fevgZRcMc4JYUPn6QDerz2UjJWois32q3DTW30PEr4BDfQ/TkWAD10gY3ggjpSBRLVOFRkxc8uMWnd3wSgX8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=OdKdXyN2; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="OdKdXyN2" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-43634b570c1so27554415e9.0 for ; Sun, 12 Jan 2025 23:20:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1736752832; x=1737357632; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=1SDKKN4HmdNIWYqyaibttvrx4Bo3thegKgI3FwzuVQ4=; b=OdKdXyN2Uf47lRpIe2/3cZ8VLaw7dHpU4545qKZTFBHCfh5v5AJb0M1oVeyjxS1CRF MMTPoreC/srvUQnHjjcpERBBZCPp52iLJvNEjJrBkHKCLt+/LspWRx2e/ApUvRjQ3JJS z9IcSQqt7Xv9QKUO0UOGurdr465BioEX8tQwtxG/XgecfktyKkLWbMsIgubStStt2p9H +5NYMhUlcUD/taI/lCIJ5tuNfwkiP3WIahuRDbhn4Aqb1kUBQWwQV2+fCIR/mW8JAmF+ BDTpWYgVU+EsEZGzF028ca+XlTpcBGQ6OJKz93sr7OW9rfFI2GLnlyFYD8RhPCdOvYnB QSLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736752832; x=1737357632; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1SDKKN4HmdNIWYqyaibttvrx4Bo3thegKgI3FwzuVQ4=; b=sggZxCGsDxj0DmsbIL9PMvde8YmHTVX3T15MkkJbbwgQcYBnuWU8ti7914NMckZaeC r2lTuCkFQxc2UgUDUV9PRIOa2guKD80/fkinHuyCAeu8o0OcE+wA8ZuhlVRkHnUgyqlX wLeNVB0OpUFCSHUlTfYJQsysCZxQ6H3xUdDZLL+zqmoKIrofBIO/LSdC0DOvvSobP81B jOYMbU79n+KODmLUkgc3TOQvNXCKYo4TODS1SHALZK3IMlRUJVE6jdQBQ3kwa4XdMcZm 5QGjTvXQLrhQVATSbeb7QWPNi/QjeOuTvDGNoMQm0cpiV6sIXfKgmw0W2LG3K/c0nLLW DG2g== X-Gm-Message-State: AOJu0YzbBP/80JTC1jfK7e1Jauefhi5j+Ge5uo3bLnr6JZPuuhBufKrW FWTa1kK1oaaM8cErtn2QxW5VlyVDeF3JX1fCnVi8SK19z6jqs49MksXMCdjTfQ== X-Gm-Gg: ASbGncsOGlT5+xmHmx07DY4zjGLXmbEa598QQk1A/NJKXvLSadqCfWmY5aPWMARmle/ 79bxVyhtWjp3oAHTPrDYqdjmBtciXqceR2aCr1RKkbTTgi7MLHaw78X674ddw3UWmBuJqSBe5WZ pinct2iHB+E5ws2z5LyF642QP2HCCiSRkuDEOZXDKWmoE6B8ggDW6gzaXLmi2s8YqXNBXb5EMao TSIq6DBnI6cncuI/XDH8yOoEVSeHMbRtAHQ5HZeYbj0ob7BlGQYrQGEfEWON8Vw1fId6y6xK9Yx yQlUlGPcDNSCRvULwTHUDoyqEFklY/E0b/HEa8P7Zg== X-Google-Smtp-Source: AGHT+IH43ppTcJvK46N0WR/AhbN+4+NAtYpn93VBtAvkvsnsz55xa2QYKfB1B7SiqmhmGwePow6L2A== X-Received: by 2002:a05:600c:3149:b0:434:9fac:b158 with SMTP id 5b1f17b1804b1-436e2680c4amr144180955e9.1.1736752831667; Sun, 12 Jan 2025 23:20:31 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-436e2e92dc4sm167300385e9.39.2025.01.12.23.20.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 12 Jan 2025 23:20:31 -0800 (PST) Message-ID: Date: Mon, 13 Jan 2025 08:20:32 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] xen/pci: do not register devices outside of PCI segment scope To: Bjorn Helgaas Cc: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Roger Pau Monne References: <20250110222129.GA317771@bhelgaas> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <20250110222129.GA317771@bhelgaas> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10.01.2025 23:21, Bjorn Helgaas wrote: > On Fri, Jan 10, 2025 at 03:01:48PM +0100, Roger Pau Monne wrote: >> The PCI segment value is limited to 16 bits, however there are buses like VMD >> that fake being part of the PCI topology by adding segment with a number >> outside the scope of the PCI firmware specification range (>= 0x10000). The >> MCFG ACPI Table "PCI Segment Group Number" field is defined as having a 16 bit >> width. >> >> Attempting to register or manage those devices with Xen would result in errors >> at best, or overlaps with existing devices living on the truncated equivalent >> segment values. > > The ACPI _SEG method (ACPI r6.5, sec 6.5.6) and the corresponding > value in the MCFG table (PCI Firmware r3.3, sec 4.1.2) are clearly > 16-bit values. > > But otherwise, the segment value is pretty much an arbitrary software > value, and the kernel works fine with the larger domain values from > vmd_find_free_domain(), so this isn't quite enough to explain what the > issue with Xen is. > > Does Xen truncate the domain to 16 bits or use it to look up something > in ACPI? One of the involved public interface structs starts like this: struct physdev_pci_device_add { /* IN */ uint16_t seg; uint8_t bus; uint8_t devfn; ... So yes, wider segment values would be truncated. Plus, even if they weren't, there would need to be coordination between Dom0 and Xen on which devices gets which segment number, since - as you say - the assignment in Linux is pretty much arbitrary. Jan