From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755899AbcITR4Q convert rfc822-to-8bit (ORCPT ); Tue, 20 Sep 2016 13:56:16 -0400 Received: from hqemgate16.nvidia.com ([216.228.121.65]:16996 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755226AbcITR4O (ORCPT ); Tue, 20 Sep 2016 13:56:14 -0400 X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Tue, 20 Sep 2016 10:50:39 -0700 Subject: Re: [PATCH 3/4] ARM: tegra: nyan-big: Include compatible revisions for proper detection To: Paul Kocialkowski , References: <20160828173246.32621-1-contact@paulk.fr> <20160828173246.32621-3-contact@paulk.fr> <1474394004.1215.2.camel@paulk.fr> CC: , Stephen Warren , Thierry Reding , , Alexandre Courbot , From: Jon Hunter Message-ID: Date: Tue, 20 Sep 2016 18:56:08 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1474394004.1215.2.camel@paulk.fr> X-Originating-IP: [10.21.132.118] X-ClientProxiedBy: UKMAIL101.nvidia.com (10.26.138.13) To UKMAIL101.nvidia.com (10.26.138.13) Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20/09/16 18:53, Paul Kocialkowski wrote: > * PGP Signed by an unknown key > > Le mardi 20 septembre 2016 à 18:41 +0100, Jon Hunter a écrit : >> On 28/08/16 18:32, Paul Kocialkowski wrote: >>> >>> Depthcharge (the payload used with cros devices) will attempt to detect >>> boards using their revision. This includes all the known revisions for >>> the nyan-big board so that the dtb can be selected preferably. >> >> May be I am missing something here, but for the mainline there is only >> one dtb available and so why is this needed for the mainline? > > There is indeed a single dts in mainline, but depthcharge will use the revision > to match the compatible string (e.g. it will look for google,nyan-big-rev5, not > google,nyan-big), so we need to list them all in that single dts. Otherwise, > depthcharge will fall back to the default config, which may or may not be > suitable for nyan. Is tegra124-nyan-big.dtb not the default? Jon -- nvpublic