mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Daniel Xu" <dxu@dxuuu.xyz>
To: "Eduard Zingerman" <eddyz87@gmail.com>,
	"Andrii Nakryiko" <andrii@kernel.org>,
	"Alexei Starovoitov" <ast@kernel.org>,
	"Shuah Khan" <shuah@kernel.org>,
	"Daniel Borkmann" <daniel@iogearbox.net>
Cc: "Mykola Lysenko" <mykolal@fb.com>,
	"Martin KaFai Lau" <martin.lau@linux.dev>,
	"Song Liu" <song@kernel.org>,
	"Yonghong Song" <yonghong.song@linux.dev>,
	"John Fastabend" <john.fastabend@gmail.com>,
	"KP Singh" <kpsingh@kernel.org>,
	"Stanislav Fomichev" <sdf@fomichev.me>,
	"Hao Luo" <haoluo@google.com>, "Jiri Olsa" <jolsa@kernel.org>,
	"bpf@vger.kernel.org" <bpf@vger.kernel.org>,
	linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org
Subject: Re: [PATCH bpf-next v5 5/5] bpf: selftests: verifier: Add nullness elision tests
Date: Tue, 17 Dec 2024 17:57:10 -0800	[thread overview]
Message-ID: <d05e9e36-36e4-456f-9c4a-2476be13a7f7@app.fastmail.com> (raw)
In-Reply-To: <00d01559793cb22a323ff8e800e1ed6e79163e57.camel@gmail.com>


On Fri, Dec 13, 2024, at 10:17 PM, Eduard Zingerman wrote:
> On Thu, 2024-12-12 at 16:22 -0700, Daniel Xu wrote:
>> Test that nullness elision works for common use cases. For example, we
>> want to check that both full and subreg stack slots are recognized. As
>> well as when there's both const and non-const values of R2 leading up to
>> a lookup. And obviously some bound checks.
>> 
>> Signed-off-by: Daniel Xu <dxu@dxuuu.xyz>
>> ---
>
> Daniel,
>
> since there would be a respin of this patch-set,
> maybe consider using plain C for some of the tests?

Yeah, makes sense. Will do for v6.

Thanks,
Daniel

      reply	other threads:[~2024-12-18  1:57 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-12 23:22 [PATCH bpf-next v5 0/5] Support eliding map lookup nullness Daniel Xu
2024-12-12 23:22 ` [PATCH bpf-next v5 1/5] bpf: verifier: Add missing newline on verbose() call Daniel Xu
2024-12-12 23:22 ` [PATCH bpf-next v5 2/5] bpf: tcp: Mark bpf_load_hdr_opt() arg2 as read-write Daniel Xu
2024-12-16 18:18   ` Martin KaFai Lau
2024-12-12 23:22 ` [PATCH bpf-next v5 3/5] bpf: verifier: Refactor helper access type tracking Daniel Xu
2024-12-13  4:04   ` Eduard Zingerman
2024-12-13 20:02     ` Daniel Xu
2024-12-12 23:22 ` [PATCH bpf-next v5 4/5] bpf: verifier: Support eliding map lookup nullness Daniel Xu
2024-12-13  4:04   ` Eduard Zingerman
2024-12-13 20:57     ` Daniel Xu
2024-12-13 23:02   ` Andrii Nakryiko
2024-12-14  2:44     ` Daniel Xu
2024-12-14  3:13       ` Eduard Zingerman
2024-12-16 23:24         ` Andrii Nakryiko
2024-12-19  0:09           ` Daniel Xu
2024-12-19 21:41           ` Daniel Xu
2024-12-20  0:04             ` Eduard Zingerman
2024-12-20  0:40               ` Daniel Xu
2024-12-20  0:43                 ` Eduard Zingerman
2024-12-20  0:49                   ` Alexei Starovoitov
2024-12-20  4:00                     ` Daniel Xu
2024-12-13 23:10   ` Kumar Kartikeya Dwivedi
2024-12-13 23:14     ` Eduard Zingerman
2024-12-13 23:18       ` Eduard Zingerman
2024-12-12 23:22 ` [PATCH bpf-next v5 5/5] bpf: selftests: verifier: Add nullness elision tests Daniel Xu
2024-12-14  6:17   ` Eduard Zingerman
2024-12-18  1:57     ` Daniel Xu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d05e9e36-36e4-456f-9c4a-2476be13a7f7@app.fastmail.com \
    --to=dxu@dxuuu.xyz \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=eddyz87@gmail.com \
    --cc=haoluo@google.com \
    --cc=john.fastabend@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=kpsingh@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=martin.lau@linux.dev \
    --cc=mykolal@fb.com \
    --cc=netdev@vger.kernel.org \
    --cc=sdf@fomichev.me \
    --cc=shuah@kernel.org \
    --cc=song@kernel.org \
    --cc=yonghong.song@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®