mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Sudarshan Shetty <tessolveupstream@gmail.com>,
	andersson@kernel.org, konradybcio@kernel.org
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/1] arm64: dts: qcom: talos-evk: Add support for dual-channel LVDS panel
Date: Tue, 28 Oct 2025 10:25:23 +0100	[thread overview]
Message-ID: <d05fe82a-640f-4a09-9d83-39bb5aff179d@oss.qualcomm.com> (raw)
In-Reply-To: <20251028061636.724667-2-tessolveupstream@gmail.com>

On 10/28/25 7:16 AM, Sudarshan Shetty wrote:
> This patch introduces a new device tree for the QCS615 Talos
> EVK platform with dual-channel LVDS display support.
> 
> The new DTS file (`talos-evk-lvds.dts`) is based on the existing
> `talos-evk.dts` and extends it to enable a dual-channel LVDS display
> configuration using the TI SN65DSI84 DSI-to-LVDS bridge.
> 
> where channel-A carries odd pixel and channel-B carries even pixel
> on the QCS615 talos evk platform.
> 
> Signed-off-by: Sudarshan Shetty <tessolveupstream@gmail.com>
> ---

[...]

> +	backlight: backlight {
> +		compatible = "gpio-backlight";
> +		gpios = <&tlmm 115 GPIO_ACTIVE_HIGH>;
> +		default-on;
> +	};
> +
> +	lcd0_pwm_en {

Use hyphens instead of underscores in node names

> +		compatible = "pwm-gpio";
> +		gpios = <&tlmm 59 GPIO_ACTIVE_HIGH>;
> +		pinctrl-0 = <&lcd0_bklt_pwm>;

I think your intention was to use pwm-backlight and wire this node
up to that

Konrad

  reply	other threads:[~2025-10-28  9:25 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-28  6:16 [PATCH v1 0/1] arm64: dts: qcom: Add dual-channel LVDS support on QCS615 Talos EVK Sudarshan Shetty
2025-10-28  6:16 ` [PATCH v1 1/1] arm64: dts: qcom: talos-evk: Add support for dual-channel LVDS panel Sudarshan Shetty
2025-10-28  9:25   ` Konrad Dybcio [this message]
2025-10-29 12:20     ` Tessolve Upstream
2025-10-29 12:34       ` Dmitry Baryshkov
2025-10-30  8:54         ` Tessolve Upstream
2025-11-01  8:39           ` Dmitry Baryshkov
2025-10-29 15:48   ` Bjorn Andersson
2025-10-31  9:12     ` Tessolve Upstream
2025-11-01  8:43       ` Dmitry Baryshkov
2025-11-04  6:49         ` Tessolve Upstream
2025-11-05 22:43       ` Bjorn Andersson
2025-11-14  9:55         ` Tessolve Upstream
2025-10-29 15:43 ` [PATCH v1 0/1] arm64: dts: qcom: Add dual-channel LVDS support on QCS615 Talos EVK Bjorn Andersson
2025-10-31  9:13   ` Tessolve Upstream

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d05fe82a-640f-4a09-9d83-39bb5aff179d@oss.qualcomm.com \
    --to=konrad.dybcio@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=tessolveupstream@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®