From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6983EB64DC for ; Mon, 17 Jul 2023 06:26:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231455AbjGQG0v (ORCPT ); Mon, 17 Jul 2023 02:26:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58856 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230027AbjGQG0r (ORCPT ); Mon, 17 Jul 2023 02:26:47 -0400 Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A43B710DA for ; Sun, 16 Jul 2023 23:26:16 -0700 (PDT) Received: by mail-ed1-x52e.google.com with SMTP id 4fb4d7f45d1cf-51f90f713b2so6279620a12.1 for ; Sun, 16 Jul 2023 23:26:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1689575133; x=1692167133; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=chypWeQof4eZMpNxOQ7bwpe/4BlH0k2ZjlVM2ysN2ag=; b=tSvUHZ/dfsh2AS1KjJ4+HyHU0yuwHol2XSCRegzesMGf2acJQu3k6klTWKnn1fe0V4 DqIzw5vBmKP6sKhTqnhVlfP6wPB0wPGlsvrxeGE1TQNdebWJ611sbU96yb7U/q+wIGey Jh0e4TPnK1/Uswsq70/pyd0+7Gi7S/H8ftQxiCohdS3MXgMXKzc4lcJu7s2BgS5OrHVm gEGCeXjHJ+uCPMNb87clkp2JIPlzOyt+BQAhPpxNc5jrNLJwrCIcijTS/o8y5tIDYHHK FxDxDWaC3JC+3FDz5tjT8/cjpMVxTv5G9FFMVzi69cM46CyI4B8UEl6TX2IdYE0hx2sH DvxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689575133; x=1692167133; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=chypWeQof4eZMpNxOQ7bwpe/4BlH0k2ZjlVM2ysN2ag=; b=dkzS0XjxI3YnkSJp8FybSxppnHLJWscNRWe2LekJ9AlOodf9RTiro2L5GMr/Xm9vjH KZPaPv5NZoT2eJLxQ4Ls2vfLLBvlUONq7wMMrkf9JTN8jz2TjIiKAtPBshmm8Bv3uP6y Lm94XkXX54UGPS/fhniChe8XghH9cpKnVulfbMINHZmXozj2D3fUj3v702HEu1jlHz48 JjUUyf4/214ZUKXEP9OZZdms7SBWIEWEQt6enSHCPaJYt3wK4BlyTjgtotDL0fxN6LVS GoRmYUQriuYgt0NrIgwd9hgrtYHojRl5361nkv4oR4jX7oMvz+7X3bOM1FewJ5ZNvuW1 Mwiw== X-Gm-Message-State: ABy/qLaf6F2zJGzZj5MVnrUpZ11IO9fD8ry34COvMHOs6Q9hFwWbZCau AzVsU8jO8LKwxQQuKNfMzjjqUw== X-Google-Smtp-Source: APBJJlHyhzL6nlTig/tpsNYVFy33IRvan6jkBmK6Lnq2glVnJN33Njy1Fz2Md6teFo7t5ql+RPjaIw== X-Received: by 2002:a17:906:113:b0:987:fe18:1c56 with SMTP id 19-20020a170906011300b00987fe181c56mr11403416eje.47.1689575133290; Sun, 16 Jul 2023 23:25:33 -0700 (PDT) Received: from [192.168.1.20] ([178.197.223.104]) by smtp.gmail.com with ESMTPSA id c7-20020a17090654c700b009882e53a42csm8698829ejp.81.2023.07.16.23.25.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 16 Jul 2023 23:25:32 -0700 (PDT) Message-ID: Date: Mon, 17 Jul 2023 08:25:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v2 1/2] dt-bindings: iio: adc: adding MCP3564 ADC Content-Language: en-US To: marius.cristea@microchip.com, jic23@kernel.org, lars@metafoo.de, robh+dt@kernel.org Cc: krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230714150051.637952-1-marius.cristea@microchip.com> <20230714150051.637952-2-marius.cristea@microchip.com> From: Krzysztof Kozlowski In-Reply-To: <20230714150051.637952-2-marius.cristea@microchip.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/07/2023 17:00, marius.cristea@microchip.com wrote: > From: Marius Cristea > > This is the device tree schema for iio driver for > Microchip family of 153.6 ksps, Low-Noise 16/24-Bit ... > + > +dependencies: > + spi-cpol: [ spi-cpha ] > + spi-cpha: [ spi-cpol ] Put dependencies after patternProperties:, before required:. > + > +patternProperties: > + "^channel@([0-9]|([1-7][0-9]))$": > + $ref: adc.yaml > + type: object Missing unevaluatedProperties: false. Open other bindings and look how it is done there. > + description: Represents the external channels which are connected to the ADC. > + > + properties: > + reg: > + description: The channel number in single-ended and differential mode. > + minimum: 0 > + maximum: 79 > + > + diff-channels: true Why? Drop, unless you want to say there all other ADC properties are invalid for this type of device (device, not driver!). > + > + required: > + - reg Best regards, Krzysztof