From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 76D713D34A9 for ; Wed, 22 Apr 2026 12:26:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776860792; cv=none; b=FRcOCnf6mRxySClAUkGVTAE4zA509/5MkviiA54Ln9YtLp0XIde/INGZ1NMy4dUIlxjaMcFkUHnjJCAAyxrHf/cEJy+ABnxCD8gKpwj5Bd78usHtK5SczrtAmHbirvonKnS3yGMEUJuH0XPIZ0RdN97X/psE17eKUd0HqrsEKuE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776860792; c=relaxed/simple; bh=V27alqKNbHbQGFNKtKckSv2uL0QrcIKQxe8K/Ir0h7s=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Us9f2uaWuHSxTkTBQk2NaD9bK2bgTGEQj2G8kD+qexutBpoHKVDgt2DNsDVyL40CuTvl4ADN/d+EDYs1XFQD5pwD9JSjI4IbpnXBAhANj8eqQ/oCTA+LS/kNynnzLIgFA9aJKg+XPCN+ejGf4HeqO8PsRq2bM9QqzdO4nWjLBgk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=fekSiEjd; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=a5ngrgBP; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="fekSiEjd"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="a5ngrgBP" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63MB7Gm24051051 for ; Wed, 22 Apr 2026 12:26:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= gIsoQnVXMnLOvbncyck/9zSJa+oCDzxGM2a/zvT0E+c=; b=fekSiEjd8SwNK6RH N/ZPV23PDUJPNrz9LdDyrD0FoTC7fjWIlMK94I3qKfV6Yyx465xX13/zLlnarNAG DqVqy9/TAEHcoMEBT8U0hAa397M5OMtbe6f2yVyA0v3XE1u9dM5UkWyWaOE4diJw BrefUg7V4+F8ign/83Rm+C1/EOVyEEfivKx0KXW3vS+TqmzgvB75ofVDdm8qfZPQ a16bUgmvRCd96K/d+2WRyJFy2qp6vM/Npcbpd9Ra/zf7kmXk8GMNLNMb1G6Gz6Cg FbuKrJ5jYR31ggwz4StgP3hXENRJ9JIKJfzvnD4eenBnHVfLFGt3zQHV+kZO35/+ 81l8kg== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dpenfkd81-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 22 Apr 2026 12:26:30 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-50faec938fcso7235081cf.3 for ; Wed, 22 Apr 2026 05:26:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776860789; x=1777465589; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=gIsoQnVXMnLOvbncyck/9zSJa+oCDzxGM2a/zvT0E+c=; b=a5ngrgBPLNEhNNmV0HujAz1J/y922hyvBzEZ7BLswP4L5s2VHRBM2AyzyBJOCojbYR CodFMmQgUG9NPhekrA5WkpYhETxiVKmHX1r1uoxIpQL2KgMGjiYQEOPa2CobHjfbGOSb 3VyJudDLHg3j0YDEwPp4vmjCeCCxZFw5iLRwk143JyLnU6z0dVgZVqppRC4PxAOF43HE NdFxRTFl5dacLmykz5ZWSn6XFot+uOQNLzhbg3SVXPma8E19sm8OKSJ0tDEPSn5zy5q9 QP81HHNOmIyosy7hO5ew3bIbdJhRRv0qPGaFVbqfc4kaMX0BYZ80PmhqMxaWhHtmJAQE mfuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776860789; x=1777465589; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gIsoQnVXMnLOvbncyck/9zSJa+oCDzxGM2a/zvT0E+c=; b=d8pRHnzkR75grmgz0cjGvULAsj1gYq97sijukhh3skFWpZ9Mq9heBNCDwxey3KwAeo TtxKyrw3MUfSQsrVVJEaD9n1Ad23N3io8tUqihGClJumxUjbbFJBGHDTzDa8rHEuEvTa nvcZmjD4xwfuNGBDVJzlhZXsp8TbKzCa0R+N5MB3NxZ6ih6VNXU9IeHQonMR9CfJs0iW P467h500Vw65cqB3u1WHPHNGsgZRVPv47fqXp8QeDfw8MO3PJu4svwHg0g1DuWRNx4q+ cOhzWgZR9JaD9kW85SOHIoEAYso2EqdIJCBqVzfnoLFsITvZg70UB2DVz18wKY4Nu4D8 aoGQ== X-Forwarded-Encrypted: i=1; AFNElJ9azKBgGlurmhtR0ZczSGfUALgrckov8FTZeQkCvpFiUf9DtKA+VuCSyj7fAOTIqTP+9SS0RAwlJaCD5Nk=@vger.kernel.org X-Gm-Message-State: AOJu0YyVnf55mo48EnKiOFcOvWiq+LJGd+p03CHRsE8beJVhdQZg1Y/E eNaV8n+ze/Knetn0YT0D7noJcReOojeXmFdIlfDfX6NQBqWR5IOpkhXD0qV+8vGhPpnq+viWaVK zqeKlCRjCNUo13/gLw+ILPQwwoInHlJq1fZK3enHJJaGZ8KCQ4hyMFrPhIQCIqotZghw= X-Gm-Gg: AeBDieswr9bLK8YLeQKVeIA5e9CBeqVjIrU34STtgXGQm9MkPpNdp+tcR3lFHXh/ku1 /ElD8XZpGbjRt1vIH7rhiV9QsglaMU2ss0D55ABxg8/phseB5tKx+EAmnUU4E/xCMkpJxKH7+iM NjzAoeT988Fe0oNEJBf7pBESeOAETYht2RyNHSwXP46wU/0z0O963GJ1N2+3h6FEThs001ZxCsb mQ4pZ+IGmyy/PYN8lHx0185mGXKxqUTbpUvjmccNRfj4I6fsaYoe/crwbZlaYpWmthmLTtHZMYA 0Qvi6fmvH5nDnrnrCXMGjvd/OGvZcsOMyzaUAsIdp20VexxiIRf6jf29tN6mMo2y7Z2f6W81Try 4u+duhjoV4ZbZ+curldc1Q+lWPojYuL+E2XbdFOW2XgK3OUO4+Cd95YgeOefM5NjkXOWOhCMwUQ QEC/BW+sOc1H65lA== X-Received: by 2002:a05:622a:5c9:b0:50e:5cc1:1de9 with SMTP id d75a77b69052e-50e5cc12306mr130379841cf.7.1776860789176; Wed, 22 Apr 2026 05:26:29 -0700 (PDT) X-Received: by 2002:a05:622a:5c9:b0:50e:5cc1:1de9 with SMTP id d75a77b69052e-50e5cc12306mr130379451cf.7.1776860788699; Wed, 22 Apr 2026 05:26:28 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ba45553e9e4sm546474966b.60.2026.04.22.05.26.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Apr 2026 05:26:27 -0700 (PDT) Message-ID: Date: Wed, 22 Apr 2026 14:26:25 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 7/7] media: qcom: iris: Make iris_destroy_internal_buffer() return void To: Dikshita Agarwal , Vikash Garodia , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil , Stefan Schmidt , Hans Verkuil , Deepa Guthyappa Madivalara Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue References: <20260422-iris-code-improvement-v1-0-8e150482212d@oss.qualcomm.com> <20260422-iris-code-improvement-v1-7-8e150482212d@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260422-iris-code-improvement-v1-7-8e150482212d@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDIyMDEyMCBTYWx0ZWRfX8mWFZPPzioHr ns9MX2KP80m87J00d7PS1pS3ZYMSWyCMwa5Bi4m8spxItKdm1nbl/Ao7fbHMXy381nqfQmF7L2+ N+nhrgj6y0HpR4PUYURYXlmLlawDHuThVWtSpViLN04KIbqUMIulhd/XHKEZ5z+gtTvI6FJ33uu L9J1Xh6rIi5y6zGE+cgBhJiVC1WsDquUsHF3kJ2v5ZzuRRodKlD2wsELd4DtTaz7MKxbDKr2MPs N+rir+bHW4KOSSXLiBR4KmcPUusa6TLcLJ4RIMSfMwSGgedxLkPoPgMpbhyBpM9mfuEteyGxhkn RK0f4nn/Ee5aqxSt+ElurEV1Z0+BXJ23gE0A5GnHW9ojJ0mmYtjjVDjy6ltMsom5ab2EYIZx2i7 O6KKY4H1FA4/RMit6qOTHHaocGSFxww0yhCjhnqA2xoHZjGRRgL7MLkPC0Y8dBGZbUxs2t5li1s uNcNR5mTMb119bECUBw== X-Authority-Analysis: v=2.4 cv=VMrtWdPX c=1 sm=1 tr=0 ts=69e8be76 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=C_VYEJWI21jkAhOvB2sA:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-GUID: JLcKTrxBBws2QoGTUlUPLjpsXAYQGV2i X-Proofpoint-ORIG-GUID: JLcKTrxBBws2QoGTUlUPLjpsXAYQGV2i X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-22_01,2026-04-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 clxscore=1015 impostorscore=0 bulkscore=0 malwarescore=0 spamscore=0 phishscore=0 priorityscore=1501 suspectscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604220120 On 4/22/26 1:16 PM, Dikshita Agarwal wrote: > iris_destroy_internal_buffer() is guaranteed to succeed and never > reports an error. Returning an int is misleading and forces callers to > handle a meaningless status value. Convert it to return void to match > its behavior and simplify callers. > > Signed-off-by: Dikshita Agarwal > --- Reviewed-by: Konrad Dybcio Konrad