From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 944F3C433EF for ; Sun, 20 Mar 2022 18:46:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343542AbiCTSsR convert rfc822-to-8bit (ORCPT ); Sun, 20 Mar 2022 14:48:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54148 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343537AbiCTSsP (ORCPT ); Sun, 20 Mar 2022 14:48:15 -0400 Received: from eu-smtp-delivery-151.mimecast.com (eu-smtp-delivery-151.mimecast.com [185.58.86.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id EC129180048 for ; Sun, 20 Mar 2022 11:46:50 -0700 (PDT) Received: from AcuMS.aculab.com (156.67.243.121 [156.67.243.121]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id uk-mta-211-OvTu6yGEPO-aZeWLosJXtg-1; Sun, 20 Mar 2022 18:46:46 +0000 X-MC-Unique: OvTu6yGEPO-aZeWLosJXtg-1 Received: from AcuMS.Aculab.com (fd9f:af1c:a25b:0:994c:f5c2:35d6:9b65) by AcuMS.aculab.com (fd9f:af1c:a25b:0:994c:f5c2:35d6:9b65) with Microsoft SMTP Server (TLS) id 15.0.1497.32; Sun, 20 Mar 2022 18:46:46 +0000 Received: from AcuMS.Aculab.com ([fe80::994c:f5c2:35d6:9b65]) by AcuMS.aculab.com ([fe80::994c:f5c2:35d6:9b65%12]) with mapi id 15.00.1497.033; Sun, 20 Mar 2022 18:46:46 +0000 From: David Laight To: "'trix@redhat.com'" , "toke@toke.dk" , "kvalo@kernel.org" , "davem@davemloft.net" , "kuba@kernel.org" , "pabeni@redhat.com" CC: "linux-wireless@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH] ath9k: initialize arrays at compile time Thread-Topic: [PATCH] ath9k: initialize arrays at compile time Thread-Index: AQHYPG4UGesvc0U9PEWregiQnXO486zIm6Kg Date: Sun, 20 Mar 2022 18:46:46 +0000 Message-ID: References: <20220320152028.2263518-1-trix@redhat.com> In-Reply-To: <20220320152028.2263518-1-trix@redhat.com> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=C51A453 smtp.mailfrom=david.laight@aculab.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aculab.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: trix@redhat.com > Sent: 20 March 2022 15:20 > > Early clearing of arrays with > memset(array, 0, size); > is equivilent to initializing the array in its decl with > array[size] = { 0 }; > > Since compile time is preferred over runtime, > convert the memsets to initializations. ... > diff --git a/drivers/net/wireless/ath/ath9k/ar9003_calib.c > b/drivers/net/wireless/ath/ath9k/ar9003_calib.c > index dc24da1ff00b1..39fcc158cb159 100644 > --- a/drivers/net/wireless/ath/ath9k/ar9003_calib.c > +++ b/drivers/net/wireless/ath/ath9k/ar9003_calib.c > @@ -891,10 +891,9 @@ static void ar9003_hw_tx_iq_cal_outlier_detection(struct ath_hw *ah, > { > int i, im, nmeasurement; > int magnitude, phase; > - u32 tx_corr_coeff[MAX_MEASUREMENT][AR9300_MAX_CHAINS]; > + u32 tx_corr_coeff[MAX_MEASUREMENT][AR9300_MAX_CHAINS] = { 0 }; For a two dimensional array that needs to be {{0}} (or {}). And, since there is only one definitions of 'coeff' it can be static! (Currently on 96 bytes - si not a real problem on-stack.) Although I just failed to find the lock that stops concurrent execution on multiple cpu. David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)