From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 80FFE2853EE for ; Thu, 25 Sep 2025 02:42:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758768173; cv=none; b=izsMoPpoSsHXULih1iBzScPQjIgIs/UkyHvlpePSs9IYziCLjyCosbVWAKrl3baAPs/9R4Pkj/3/NyauxlfdiHrpfgZLpmwt+FR64a0jtoj5qmSRBsLt6+WiCpjuGdWDA1Mpoe61urZt112Q3DpeWU3WPmeI+fDL+8LhZ4IQ53A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758768173; c=relaxed/simple; bh=6ha9Kr3cHw1wO1FCl7TwD597fRof4tQ/XQ20AsKCc8w=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=um1Mfs5ZZrwTcep4oPIZhd/A4Xnmh574xaT54pXfQDe/6KwYUMJT6D/FLIE/7QCZ8A9TFXC+cwuxIkQNzqqwzwduYaoGPu9JX8g42QucT6xh0P6OGqWZURrRIt2rqvUT1EBjcIdQC+h5c647M6dhaa8gcz63VPbKVNavuTF+otU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JXtr+l4R; arc=none smtp.client-ip=209.85.216.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JXtr+l4R" Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-3322e6360bbso502413a91.0 for ; Wed, 24 Sep 2025 19:42:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1758768171; x=1759372971; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=H2hXuCp7EQSu2VY5F9OuSum1bbz+fDfBhTmNsUc96kw=; b=JXtr+l4RpD9JpQLtHRsUf+3yPB/CAR7v1G3esQ24HZqo6FfF3JIyUtKQuVG4Y0eWcg OjpR9OyXwSsu3dSnKumU3fkeNDV9yKRAEQm7joxRqHhUKj5lMx0Qx6Rxhd1dzNXWDF5O wKZNpte2zmXZkJF5k+zKznjqD5mENwfp+uFhGvv/XusbmgVszwjhQe7mnJIzRjJKm5up lFN+5Z/AEUZd6SFgC0ERpmVrGMVgbwHJKujoW8LAtZ6QCkLbjabRUlneGx5tBuDuON1E zAeWSJ4jOqZLQEu+QIHPuMPUBLkmGuThxMEq5Z0X+qfGJbZzQ/ZHL6flbHG3lwaLCx4T lxqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758768171; x=1759372971; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=H2hXuCp7EQSu2VY5F9OuSum1bbz+fDfBhTmNsUc96kw=; b=XcIlpWIXWfbZfChKBgQXVvhQPZxg79O4IbmCOuBBPVZqcr6K1fUdPuxes8ay4gNCdg Fy005fydMSMVRMzKknkMkEfAUN567/q3p32/7fl2909C+Gvl3wyTB3ykRYIuFzvSqiS5 ++cb3lVpaBtw1QVJ0onBqJpKE5y6urw9k0bxAud8QeJKEPOwCRx8vkZewcFJW2sDQy0R EF2Vd2t+xLxiToC9uLgVuebtngZSFSwLcCFHtYbkThM9FBzzcrDwE1ZaUWy1Mnk+01sp +E3qJrqv4s+OyOaXK1wtb9H+1SxMhIUkxa84Evz6M/SP7p8sMRn343N+fDntIJ1YqBCz bY1g== X-Gm-Message-State: AOJu0YzES5AKslw6NWAhY0WQMVg3CHLVAMGLulTH8KQ3daGYwU8uOQp2 iMMJ+8LlX0LKmNR592/xCz3VaOrEmu+jwtk99q0Im9N67R06R/5Uou6d X-Gm-Gg: ASbGncugHBxjaxh8Z5if8Ytj+MeNmRZpuTOi/JyBgFNbozmdnYjGOkQNutyX/oQYNnT DZ3kANJoPFbc5utHqHmtz/t3RoeQgVCCNxKGX56Ia6+zg2KLBhmmKq64EZLJkkmelnLaimbfUpV bC9zxnDJOqp6Y7YXKHhvV+8QvlhJS+uBFzHu4Jb8f7m5VLDINkA8oKCuNeFc4SRxffPPhCxW3ip Snea13ZJanSlbr0gSpWvqhrOfvuQlXa9s5eEzNswj664pme7KO70Bey0AXFVjEyfrQIIsmMseyX UFHbC/xoP1cG/bFDrYdQLfs0+DjgzkYiuElmDL3i48zt9MHBPLuSpCphKAYE7LeMbZElHnE1e18 ibM6wdmP2pnL6sz8HR0x1U9ftBtYgzzMhJhQ= X-Google-Smtp-Source: AGHT+IE0G2axEK95LZpQCj1blNLHLFhQYEdYLjR6DblWy6INXdm/D+7lSNoW57qRiV90T5B2V8ID1g== X-Received: by 2002:a17:90b:380a:b0:32e:5d87:8abc with SMTP id 98e67ed59e1d1-3342a306014mr1784771a91.36.1758768170707; Wed, 24 Sep 2025 19:42:50 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-33471d711ecsm525656a91.4.2025.09.24.19.42.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Sep 2025 19:42:50 -0700 (PDT) Sender: Guenter Roeck Date: Wed, 24 Sep 2025 19:42:49 -0700 From: Guenter Roeck To: Stanimir Varbanov Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, Broadcom internal kernel review list , linux-hwmon@vger.kernel.org, Jean Delvare , Rob Herring , Florian Fainelli , Krzysztof Kozlowski , Conor Dooley , Andrew Lunn , Stefan Wahren , Saenz Julienne , Andrea della Porta , Phil Elwell , Jonathan Bell , Dave Stevenson Subject: Re: [PATCH 2/4] hwmon: adc: rp1: Add Raspberry Pi's RP1 ADC driver Message-ID: References: <20250925000416.2408457-1-svarbanov@suse.de> <20250925000416.2408457-3-svarbanov@suse.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250925000416.2408457-3-svarbanov@suse.de> On Thu, Sep 25, 2025 at 03:04:14AM +0300, Stanimir Varbanov wrote: > A five-input successive-approximation analogue-to-digital converter > with 12-bit (effective number of 9.5 bits) resolution at 500kSPS. > The ADC has four external inputs and one internal temperature sensor. > > Signed-off-by: Phil Elwell > Signed-off-by: Jonathan Bell > Signed-off-by: Stanimir Varbanov I just realized that there is already a hwmon driver for Rasperri Pi - drivers/hwmon/raspberrypi-hwmon.c. Please add this code to that driver. > --- > drivers/hwmon/Kconfig | 10 ++ > drivers/hwmon/Makefile | 1 + > drivers/hwmon/rp1-adc.c | 301 ++++++++++++++++++++++++++++++++++++++++ Also, this needs documentation. Thanks, Guenter