mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Aniket Limaye <a-limaye@ti.com>
To: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
Cc: Andi Shyti <andi.shyti@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	<linux-i2c@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	<lianfeng.ouyang@starfivetech.com>
Subject: Re: [PATCH v4 2/2] i2c: Add Synopsys Advanced I2C (DWC_i2c) driver
Date: Sat, 31 Oct 2026 15:24:50 +0530	[thread overview]
Message-ID: <d074096f-73ff-47a6-8eb5-c85f0536e3c2@ti.com> (raw)
In-Reply-To: <auGgVBEHvowseCt0@monoceros>



On 28/10/26 12:44, Uwe Kleine-König wrote:
> Hello,
> 
> On Tue, Oct 27, 2026 at 05:00:36PM +0530, Aniket Limaye wrote:
>> +#include <linux/mod_devicetable.h>
>> [...]
>> +#include <linux/platform_device.h>
> 
> Please don't include <linux/mod_devicetable.h>.
> <linux/platform_device.h> already gives you everything you'd expect from
> <linux/mod_devicetable.h> without introducing a bunch of unneeded build
> dependencies.
> 
> Best regards
> Uwe

Noted, will fix this in next version

Thanks for the review!
Aniket


      reply	other threads:[~2026-10-31  9:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-27 11:30 [PATCH v4 0/2] i2c: Add Synopsys Advanced I2C (DWC_i2c) support for TI TDA54 Aniket Limaye
2026-10-27 11:30 ` [PATCH v4 1/2] dt-bindings: i2c: Add Synopsys DWC_i2c controller Aniket Limaye
2026-10-27 18:36   ` Krzysztof Kozlowski
2026-10-31  9:55     ` Aniket Limaye
2026-10-27 11:30 ` [PATCH v4 2/2] i2c: Add Synopsys Advanced I2C (DWC_i2c) driver Aniket Limaye
2026-10-27 16:32   ` Mark Brown
2026-10-31 10:28     ` Aniket Limaye
2026-10-28  7:14   ` Uwe Kleine-König
2026-10-31  9:54     ` Aniket Limaye [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d074096f-73ff-47a6-8eb5-c85f0536e3c2@ti.com \
    --to=a-limaye@ti.com \
    --cc=andi.shyti@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=lianfeng.ouyang@starfivetech.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=robh@kernel.org \
    --cc=u.kleine-koenig@baylibre.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®