From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B3B6626F29C for ; Tue, 6 Jan 2026 08:15:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767687324; cv=none; b=md1h3YQWu6Ljp6/oTSWEhLVywKKYrXLUw7UoFhC/P2zA+9OZwqWvyibfoLb7reRHWsq0DMqN/CVpRwQCYQ5LsvhLq76xxSTi4b34aIzY4pk7Um5cpfYttSWzg2hAd9di3alQMhnG09zSTIVpdXjwbjwqHcl3lQMPsLDVBr5a0Cw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767687324; c=relaxed/simple; bh=clsngDTY0FD0RBm6RZ1/aBXb5l1UcQWBbM4Zs83J7X8=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=Uh0akgR38cKc0BdC2XOoKNnz0LBDWNHnjjPabIV8487q3h0ujaDjrf0/tkow0nbOwOcSNqhvZ+jwFVMT/nEiBxQvVhEAlIrN0OGziedSqH9UvZvpD3ZXznm+dbXwJGejI5d5TDq7YZrhaIc7NTSUTw6ofWtAcpHpF9rBjpWiT0w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=x1diu78R; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="x1diu78R" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-47774d3536dso6477025e9.0 for ; Tue, 06 Jan 2026 00:15:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767687321; x=1768292121; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=WlcLJcRv6NmifS5tk12ISHXHC1kObcbQiLoIFthBsgY=; b=x1diu78REZVQ+VMO8Jz++MwtVDxsVW6iweocOqx4W9gM5B3NOLiI+4pP/XoB/4bf5d nryuit2P7VHMbm7WFkv090xDfyTeb//kjULRlvkjBTBDuNFXeSGexGF2lLu81Fxyq68o wJRibH6Kbq4Ezo7Xgt/LXM10t/F3bJdI0PLerVEIDcmnQSSx3hLvINH6jWbq69UCOF9x 4CggVqQrnXZYyzDgO7Y/t7i7ShG6eL35isREDDXPA3fUGLjIcrIdaKCPXTk/6PQQPlRo 4l80r291KrxEAbOr5cKVnRok2Wyzj06a0B6nHPjAqKGt+WnpHZs2LAJAS5xIwd4pcDbQ 4xPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767687321; x=1768292121; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WlcLJcRv6NmifS5tk12ISHXHC1kObcbQiLoIFthBsgY=; b=XETcX7PjjEHbV/DWMihsVVAlNGXuKkXsd+hlZrx81yFMUi7HXbdrdcR0hLkbeIIBRN LxYfouYAgGbgfYkOIYrNz6zY236B1wfjjKO/0flajIyvyTJU6bIpurG64f30I12tVTBa J+wiWZpwWvuGA5735wUCtjZmp3zsMNFs3KUL164XhOJ3MUTYD+cXa1Gi3qX354QhoLrp VxHEVtO8kgWMXly5/biS4cWrCHKblIHI89uDKSu9o/mnGy7r0MMMelVpzCpQXeSIzOxr 7rA+LXmw1yw29X8wvACdg60ZKJ46Ze0gFBa5pcnIDtiFTyOBrAss87Gb8cYaFX93QUjj bmbg== X-Forwarded-Encrypted: i=1; AJvYcCWdn80IkXYEjCoyRfr9G1Del/QSMNojKZhNqnJbd/SSqY6QpV4kV+JRPB1gTbMe+ofulAZZeGv4BS7eBxQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwMtnS3ai/g5w4eEZYJTkS0gy3K+mjBC54s1OTyXP3XvS4njY/p 8w4jQ/Q1c1nYPr1w3/KEzQqRltdLay0TJKetJmtH5GGTf678b3wDN9wEyWl/LJx1cbc= X-Gm-Gg: AY/fxX5rnBjeqLsgMoJ1HyQVjyM74GW3dCPV/1ji+5tP6b7E//DeVHBcIwPS5884+3w PXCHaellcL7/4NQJu5dVLHUaK7ryD8wBF2G6z0cqb1IsKlitmS8YuKOB+u3K9Twcf3h9qot7eAQ hqSLyCQxzLpoPanrdR3kYCx7hLYfHlVZoOZrkkVqNuccVUWGt57fETjDNq4VOgpzxMrgdkBDqXJ QVyp7IU3qgxxaL+9JShQioxqSDMht12NRCFCxgqvIMshGx1aMFwkb3QZyIx1oQ0Rvavj5PvCk5m FgYFut/AYOHZ4mQ33WG7dJcMbijhtmGyMq4z6K2wqTi8+qXKm9DbgG7e+n3cLb4LT1hPJdQ/o7b n6/sBj/KEqWM2Aoo00e3P7dRx21r8rlSj4cfy0+SqTLrF9MsC6NUjjSo2uS52wP/DKed37puZSA 0M6ZkVECvy7hsDcCRkn8LBTHU7v1LPAQy5lEbHyBXMGnuL6ct+HK6zUD2BmLTq6Rg= X-Google-Smtp-Source: AGHT+IFWWMC+vC3Jv1zN8otnZ5o0DsOhfa+A4/daWU3DP9hf9GKf9S7nKRd7ftIFNdP05wOd8OCVIQ== X-Received: by 2002:a05:600c:a112:b0:477:5639:ff66 with SMTP id 5b1f17b1804b1-47d7f627b7fmr20939945e9.13.1767687320848; Tue, 06 Jan 2026 00:15:20 -0800 (PST) Received: from ?IPV6:2a01:e0a:3d9:2080:d283:7a7e:4c57:678d? ([2a01:e0a:3d9:2080:d283:7a7e:4c57:678d]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-432bd5dfa07sm2901051f8f.25.2026.01.06.00.15.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Jan 2026 00:15:20 -0800 (PST) Message-ID: Date: Tue, 6 Jan 2026 09:15:19 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: Neil Armstrong Subject: Re: [PATCH 3/5] drm/panel: mantix: Improve power off sequence To: sebastian.krzyszkowiak@puri.sm, =?UTF-8?Q?Guido_G=C3=BCnther?= , Purism Kernel Team , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260105-mantix-halo-fixes-v1-0-1ebc9b195a34@puri.sm> <20260105-mantix-halo-fixes-v1-3-1ebc9b195a34@puri.sm> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20260105-mantix-halo-fixes-v1-3-1ebc9b195a34@puri.sm> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/5/26 21:24, Sebastian Krzyszkowiak via B4 Relay wrote: > From: Sebastian Krzyszkowiak > > According to the sequence from section 7.3.4 of FT8006P datasheet, > TP_RSTN and RESX should be asserted after disabling AVDD and AVEE and > together with VDDI. > > Also, AVEE power down needs to happen at least 150ms after entering > sleep mode. > > Signed-off-by: Sebastian Krzyszkowiak > --- > drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c | 12 ++++++++---- > 1 file changed, 8 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c b/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c > index bb5489e4d7a9..0e66ee7a727d 100644 > --- a/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c > +++ b/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c > @@ -96,6 +96,9 @@ static int mantix_disable(struct drm_panel *panel) > mipi_dsi_dcs_set_display_off_multi(&dsi_ctx); > mipi_dsi_dcs_enter_sleep_mode_multi(&dsi_ctx); > > + /* T10 */ > + mipi_dsi_msleep(&dsi_ctx, 150); > + > return dsi_ctx.accum_err; > } > > @@ -103,15 +106,16 @@ static int mantix_unprepare(struct drm_panel *panel) > { > struct mantix *ctx = panel_to_mantix(panel); > > - gpiod_set_value_cansleep(ctx->tp_rstn_gpio, 1); > - usleep_range(5000, 6000); > - gpiod_set_value_cansleep(ctx->reset_gpio, 1); > - > regulator_disable(ctx->avee); > regulator_disable(ctx->avdd); > /* T11 */ > usleep_range(5000, 6000); > regulator_disable(ctx->vddi); > + > + gpiod_set_value_cansleep(ctx->tp_rstn_gpio, 1); > + usleep_range(5000, 6000); > + gpiod_set_value_cansleep(ctx->reset_gpio, 1); > + > /* T14 */ > msleep(50); > > Reviewed-by: Neil Armstrong Thanks, Neil