From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75754C6FA83 for ; Wed, 7 Sep 2022 10:56:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229666AbiIGK4d (ORCPT ); Wed, 7 Sep 2022 06:56:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50828 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229472AbiIGK43 (ORCPT ); Wed, 7 Sep 2022 06:56:29 -0400 Received: from smtp.domeneshop.no (smtp.domeneshop.no [IPv6:2a01:5b40:0:3005::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2C94C6745E for ; Wed, 7 Sep 2022 03:56:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tronnes.org ; s=ds202112; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=gfFBxOJICmmqA8f2KuQiBRQs6CbCUqHF+gIu6GKS/YE=; b=krrqg1yCKd+xtRbvYsYmAcLp9g kTJV09HIqnu1jNOY2OQfIj7BOCnuRPd3zyB9/JkqUXWv7+7vikHQFy2sYRt/HgvO8GJTc9ctUPFwc yi+/WL4BhpTNmDf6hxrA9S1NLCuavfdNOn4a/7QhblCcDz0yEIfV4FtG78OdlD1DFEsDZl/2S999l kZCDWbLSSEtG+qx/PW5CnSvPOQic3ra2vMhReX4nUVF5jYKZePMlQ/MfKflVh1jaEjZF5RMMlODbD bVzfNRipnNOJf/6Ou3OnFcfdnpOH6VvJhOdv7SlQtFAAWgKkFs3Gjt9D1P3px/jH+rolm+EeSdDiD EoaKoAgQ==; Received: from [2a01:799:961:d200:cca0:57ac:c55d:a485] (port=52215) by smtp.domeneshop.no with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oVsjI-0000xR-Dw; Wed, 07 Sep 2022 12:56:24 +0200 Message-ID: Date: Wed, 7 Sep 2022 12:56:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH v2 00/41] drm: Analog TV Improvements To: Maxime Ripard Cc: Ben Skeggs , David Airlie , Chen-Yu Tsai , Thomas Zimmermann , Jani Nikula , Lyude Paul , Philipp Zabel , Maarten Lankhorst , Rodrigo Vivi , Tvrtko Ursulin , Jernej Skrabec , Samuel Holland , Karol Herbst , Emma Anholt , Daniel Vetter , Joonas Lahtinen , Dom Cobley , Hans de Goede , linux-arm-kernel@lists.infradead.org, Phil Elwell , intel-gfx@lists.freedesktop.org, Dave Stevenson , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, nouveau@lists.freedesktop.org, linux-sunxi@lists.linux.dev, Mateusz Kwiatkowski , Geert Uytterhoeven , =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= References: <20220728-rpi-analog-tv-properties-v2-0-459522d653a7@cerno.tech> <24e09a29-6d04-3b1e-63ce-cd3c31d350e2@tronnes.org> <020d44e6-884b-a817-8265-3461638cac71@tronnes.org> <20220905145729.ln675jko3aw6sgzs@houat> <74c10e51-4034-a284-1a26-b7ba7fe45fbe@tronnes.org> <20220907095849.5v72atwuedl5iiva@houat> From: =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= In-Reply-To: <20220907095849.5v72atwuedl5iiva@houat> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Den 07.09.2022 11.58, skrev Maxime Ripard: > On Mon, Sep 05, 2022 at 05:17:18PM +0200, Noralf Trønnes wrote: >> Den 05.09.2022 16.57, skrev Maxime Ripard: >>> On Fri, Sep 02, 2022 at 01:28:16PM +0200, Noralf Trønnes wrote: >>>> >>>> >>>> Den 01.09.2022 21.35, skrev Noralf Trønnes: >>>>> >>>>> >>>>> I have finally found a workaround for my kernel hangs. >>>>> >>>>> Dom had a look at my kernel and found that the VideoCore was fine, and >>>>> he said this: >>>>> >>>>>> That suggests cause of lockup was on arm side rather than VC side. >>>>>> >>>>>> But it's hard to diagnose further. Once you've had a peripheral not >>>>>> respond, the AXI bus locks up and no further operations are possible. >>>>>> Usual causes of this are required clocks being stopped or domains >>>>>> disabled and then trying to access the hardware. >>>>>> >>>>> >>>>> So when I got this on my 64-bit build: >>>>> >>>>> [ 166.702171] SError Interrupt on CPU1, code 0x00000000bf000002 -- SError >>>>> [ 166.702187] CPU: 1 PID: 8 Comm: kworker/u8:0 Tainted: G W >>>>> 5.19.0-rc6-00096-gba7973977976-dirty #1 >>>>> [ 166.702200] Hardware name: Raspberry Pi 4 Model B Rev 1.1 (DT) >>>>> [ 166.702206] Workqueue: events_freezable_power_ thermal_zone_device_check >>>>> [ 166.702231] pstate: 200000c5 (nzCv daIF -PAN -UAO -TCO -DIT -SSBS >>>>> BTYPE=--) >>>>> [ 166.702242] pc : regmap_mmio_read32le+0x10/0x28 >>>>> [ 166.702261] lr : regmap_mmio_read+0x44/0x70 >>>>> ... >>>>> [ 166.702606] bcm2711_get_temp+0x58/0xb0 [bcm2711_thermal] >>>>> >>>>> I wondered if that reg read was stalled due to a clock being stopped. >>>>> >>>>> Lo and behold, disabling runtime pm and keeping the vec clock running >>>>> all the time fixed it[1]. >>>>> >>>>> I don't know what the problem is, but at least I can now test this patchset. >>>>> >>>>> [1] https://gist.github.com/notro/23b984e7fa05cfbda2db50a421cac065 >>>>> >>>> >>>> It turns out I didn't have to disable runtime pm: >>>> https://gist.github.com/notro/0adcfcb12460b54e54458afe11dc8ea2 >>> >>> If the bcm2711_thermal IP needs that clock to be enabled, it should grab >>> a reference itself, but it looks like even the device tree binding >>> doesn't ask for one. >>> >> >> The first thing I tried was to unload the bcm2711_thermal module before >> running modeset and it still hung, so I don't think that's the problem. > > Ack. Just to confirm, is this happening on mainline or on the downstream tree? > It's mainline. Noralf.