From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753413AbdC1Nyt (ORCPT ); Tue, 28 Mar 2017 09:54:49 -0400 Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:38909 "EHLO osg.samsung.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752538AbdC1Nyq (ORCPT ); Tue, 28 Mar 2017 09:54:46 -0400 Subject: Re: [PATCH v2] usb: phy: isp1301: Add OF device ID table To: Felipe Balbi , linux-kernel@vger.kernel.org References: <20170315034646.10360-1-javier@osg.samsung.com> <87wpb9frbd.fsf@linux.intel.com> Cc: Greg Kroah-Hartman , linux-usb@vger.kernel.org From: Javier Martinez Canillas Message-ID: Date: Tue, 28 Mar 2017 09:54:23 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <87wpb9frbd.fsf@linux.intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Felipe, On 03/28/2017 09:45 AM, Felipe Balbi wrote: > > Hi, > > Javier Martinez Canillas writes: >> The driver doesn't have a struct of_device_id table but supported devices >> are registered via Device Trees. This is working on the assumption that a >> I2C device registered via OF will always match a legacy I2C device ID and >> that the MODALIAS reported will always be of the form i2c:. >> >> But this could change in the future so the correct approach is to have an >> OF device ID table if the devices are registered via OF. >> >> Signed-off-by: Javier Martinez Canillas > > this is already upstream. Care to send an incremental diff in case we > need this fixed further? > Ah, sorry. I missed that was already picked. Sure, I'll post an incremental diff on top of v1. Thanks! Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America