From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74542C43217 for ; Thu, 1 Dec 2022 08:19:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229630AbiLAIT3 (ORCPT ); Thu, 1 Dec 2022 03:19:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51998 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229671AbiLAITT (ORCPT ); Thu, 1 Dec 2022 03:19:19 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0FDC05EF8E for ; Thu, 1 Dec 2022 00:19:11 -0800 (PST) Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1p0ema-00031o-H9; Thu, 01 Dec 2022 09:19:00 +0100 Message-ID: Date: Thu, 1 Dec 2022 09:18:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v3] crypto: caam: blob_gen.c: warn if key is insecure Content-Language: en-US To: Nikolaus Voss , Horia Geanta , Pankaj Gupta , Gaurav Jain , Herbert Xu , "David S. Miller" , David Gstir , Steffen Trumtrar , Nikolaus Voss Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, Pengutronix Kernel Team References: <20221121141929.2E36427E9@mail.steuer-voss.de> From: Ahmad Fatoum In-Reply-To: <20221121141929.2E36427E9@mail.steuer-voss.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2a0a:edc0:0:900:1d::77 X-SA-Exim-Mail-From: a.fatoum@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21.11.22 15:12, Nikolaus Voss wrote: > If CAAM is not in "trusted" or "secure" state, a fixed non-volatile key > is used instead of the unique device key. This is the default mode of > operation without secure boot (HAB). In this scenario, CAAM encrypted > blobs should be used only for testing but not in a production > environment, so issue a warning. > > Signed-off-by: Nikolaus Voss Reviewed-by: Ahmad Fatoum > > --- > CHANGES > ======= > v2: make warning more verbose, correct register, style fixes > v3: fix sparse warning "dereference of noderef expression" > by using ioread32() to dereference iomem pointer > > drivers/crypto/caam/blob_gen.c | 9 +++++++++ > drivers/crypto/caam/regs.h | 3 +++ > 2 files changed, 12 insertions(+) > > diff --git a/drivers/crypto/caam/blob_gen.c b/drivers/crypto/caam/blob_gen.c > index 6345c7269eb03..1f65df4898478 100644 > --- a/drivers/crypto/caam/blob_gen.c > +++ b/drivers/crypto/caam/blob_gen.c > @@ -6,6 +6,7 @@ > > #define pr_fmt(fmt) "caam blob_gen: " fmt > > +#include > #include > #include > > @@ -61,12 +62,14 @@ static void caam_blob_job_done(struct device *dev, u32 *desc, u32 err, void *con > int caam_process_blob(struct caam_blob_priv *priv, > struct caam_blob_info *info, bool encap) > { > + const struct caam_drv_private *ctrlpriv; > struct caam_blob_job_result testres; > struct device *jrdev = &priv->jrdev; > dma_addr_t dma_in, dma_out; > int op = OP_PCLID_BLOB; > size_t output_len; > u32 *desc; > + u32 moo; > int ret; > > if (info->key_mod_len > CAAM_BLOB_KEYMOD_LENGTH) > @@ -100,6 +103,12 @@ int caam_process_blob(struct caam_blob_priv *priv, > goto out_unmap_in; > } > > + ctrlpriv = dev_get_drvdata(jrdev->parent); > + moo = FIELD_GET(CSTA_MOO, ioread32(&ctrlpriv->ctrl->perfmon.status)); > + if (moo != CSTA_MOO_SECURE && moo != CSTA_MOO_TRUSTED) > + dev_warn(jrdev, > + "using insecure test key, enable HAB to use unique device key!\n"); > + > /* > * A data blob is encrypted using a blob key (BK); a random number. > * The BK is used as an AES-CCM key. The initial block (B0) and the > diff --git a/drivers/crypto/caam/regs.h b/drivers/crypto/caam/regs.h > index 66d6dad841bb2..66928f8a0c4b1 100644 > --- a/drivers/crypto/caam/regs.h > +++ b/drivers/crypto/caam/regs.h > @@ -426,6 +426,9 @@ struct caam_perfmon { > u32 rsvd2; > #define CSTA_PLEND BIT(10) > #define CSTA_ALT_PLEND BIT(18) > +#define CSTA_MOO GENMASK(9, 8) > +#define CSTA_MOO_SECURE 1 > +#define CSTA_MOO_TRUSTED 2 > u32 status; /* CSTA - CAAM Status */ > u64 rsvd3; > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |