From: Markus Elfring <Markus.Elfring@web.de>
To: Florian Fainelli <f.fainelli@gmail.com>,
Xu Wang <vulab@iscas.ac.cn>,
linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Esben Haabendal <esben@geanix.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Jakub Kicinski <kuba@kernel.org>,
Michal Simek <michal.simek@xilinx.com>,
Wei Yongjun <weiyongjun1@huawei.com>
Subject: Re: [PATCH] net: xilinx: fix potential NULL dereference in temac_probe()
Date: Tue, 14 Jul 2020 11:42:32 +0200 [thread overview]
Message-ID: <d0873e01-4e07-ca59-ff6b-64ac6ee6aba4@web.de> (raw)
> If you use devm_ioremap_resource() you can remove the !res check
> entirely which would be equally acceptable as a fix.
Would you like to use the wrapper function “devm_platform_get_and_ioremap_resource” then?
https://elixir.bootlin.com/linux/v5.8-rc4/source/drivers/base/platform.c#L66
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/base/platform.c?id=0dc589da873b58b70f4caf4b070fb0cf70fdd1dc#n66
Regards,
Markus
next reply other threads:[~2020-07-14 9:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-14 9:42 Markus Elfring [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-07-14 2:23 Xu Wang
2020-07-14 2:55 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0873e01-4e07-ca59-ff6b-64ac6ee6aba4@web.de \
--to=markus.elfring@web.de \
--cc=davem@davemloft.net \
--cc=esben@geanix.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=netdev@vger.kernel.org \
--cc=vulab@iscas.ac.cn \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®