mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Jakub Kicinski <kuba@kernel.org>, kernel test robot <lkp@intel.com>
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
	Arnd Bergmann <arnd@kernel.org>
Subject: Re: bnx2x_main.c:undefined reference to `synchronize_net'
Date: Sat, 30 Jan 2021 11:11:01 -0800	[thread overview]
Message-ID: <d087f29f-e9d1-382d-0a5e-50d9a5280a82@infradead.org> (raw)
In-Reply-To: <20210130103104.28a4ed6b@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>

On 1/30/21 10:31 AM, Jakub Kicinski wrote:
> I don't understand how this one happens and don't have a PPC build
> setup :S So many things seem to depend on NET here that "this should
> never happen". Must be some rogue "select" pulling BNX2 without its
> dependencies?

Yes, the problem is overuse of Kconfig "select" in powerpc for the
AKEBONO platform. The Kconfig warnings are listed at the end:

>>
>> Kconfig warnings: (for reference only)
>>    WARNING: unmet direct dependencies detected for NETDEVICES
>>    Depends on NET
>>    Selected by
>>    - AKEBONO && PPC_47x
>>    WARNING: unmet direct dependencies detected for ETHERNET
>>    Depends on NETDEVICES && NET
>>    Selected by
>>    - AKEBONO && PPC_47x
>>    WARNING: unmet direct dependencies detected for HOTPLUG_CPU
>>    Depends on SMP && (PPC_PSERIES || PPC_PMAC || PPC_POWERNV || FSL_SOC_BOOKE
>>    Selected by
>>    - PM_SLEEP_SMP && SMP && (ARCH_SUSPEND_POSSIBLE || ARCH_HIBERNATION_POSSIBLE && PM_SLEEP
>>    WARNING: unmet direct dependencies detected for NET_DEVLINK
>>    Depends on NET
>>    Selected by
>>    - QED && NETDEVICES && ETHERNET && NET_VENDOR_QLOGIC && PCI
>>    WARNING: unmet direct dependencies detected for GRO_CELLS
>>    Depends on NET
>>    Selected by
>>    - MACSEC && NETDEVICES && NET_CORE
>>    WARNING: unmet direct dependencies detected for FAILOVER
>>    Depends on NET
>>    Selected by
>>    - NET_FAILOVER && NETDEVICES

I'm pretty sure that Michael Ellerman (powerpc maintainer) was going to make
some defconfig file changes for AKEBONO, but I'm not so sure that that
change will prevent randconfig build errors. I'm in a wait-and-see mode on that.

Hm, looking back at his reply to my (powerpc, not net:) patch,
I owe him a reply, so I'll look into that.

https://lore.kernel.org/linuxppc-dev/875z3prcwg.fsf@mpe.ellerman.id.au/

-- 
~Randy


      reply	other threads:[~2021-01-30 19:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-30 10:23 kernel test robot
2021-01-30 18:31 ` Jakub Kicinski
2021-01-30 19:11   ` Randy Dunlap [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d087f29f-e9d1-382d-0a5e-50d9a5280a82@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=arnd@kernel.org \
    --cc=kbuild-all@lists.01.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®