From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B7E422F28EB for ; Fri, 12 Sep 2025 11:46:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757677587; cv=none; b=OScUkvM1CnrH/P2g/e9+s9VjlLrOIGTeamFofJSMqXyN4Dp9TnyzV3p6rIcfouVkiJj/k0zbeKXs62njyYXO9U4bQnTVM+PdyypWynxKPoEqtx01qIIw7nzkJQWcHybf+jQ8BYU8GRlKQQYXEWclY03THH5dZswVy9GMb8nByPE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757677587; c=relaxed/simple; bh=sarR2gK1o23su9ij3Nbhg6+aI0jOXkLMOpLRa4ob2jI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=A2OSkCwCa6/n/XeFwZQY8uFX2UwNuyAJfh7ylTx2F7NgTAK8S5uIDCSH76xfOZttmWmRUqVspM4S+uxoiM8j/ta8V4nr80VMlQVfwrvIjeyPhl4n+yoGkgUmJDeBbUy5PyIuXq/jmWWyfDBgHQPf+HAipW5yaYvGR3slFKLerr0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=M9Md+6Sb; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="M9Md+6Sb" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 58C9fJxG014003 for ; Fri, 12 Sep 2025 11:46:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 7bZSPwCaveiNyjpoVwp2JaCT2rjVag5Jy+2B65HThZ8=; b=M9Md+6Sbi3Z5o7Sj 0pPKOLsdok6kNB6liuAecuvU8W3GY9mtrWjlG0q/ItPlQY2xkHSECp2X/TphSiFJ +kS8eRpb/hE0pzK7m2Eg7gLamreGUY/ohLmuXby/H5sof+kVeg5tmxrzlNCye+SC 9WPNPKtRVmYkYJw/gkmim3xTDMaKfi12Cokxf/qZSiHfonaMVD9tNDflDi9kXBHA 1cyMaeGaccb3lQXqd5SPINvOkvYwLQMmiNbvQHTwWdo4/CPOtHujvuawS+b6MTiE HVsaAOcCd9+wp3ydOAsl+7JNPcKyjKu0dJxMnib1ZdKKdtXT/QwR6GVFBvB2/sCN eJoEmA== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 493qphw7h1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 12 Sep 2025 11:46:24 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-329976ff73cso427147a91.1 for ; Fri, 12 Sep 2025 04:46:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757677583; x=1758282383; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=7bZSPwCaveiNyjpoVwp2JaCT2rjVag5Jy+2B65HThZ8=; b=STLMTNnp83KHBnqbKZraPcXLYJ5s8fplt90xnldKyQBXommRAdkN950hqYBI2FIEY3 QApot+0hniFUXeR7K22wIXmFr9GGWGAiMIoclN4vLJBjVJ4QhPYGbzaoRUQMVhOngdyy PiyxY+ARg7qukF4odUqpxws4TjbR22pJNoTa7UQmvStzhc9qUAkLyfMqfCJe/usmDh7S LK0wUYyeGyDCvsgto3LleQUzaT9CCiz3SrdLWLqnqYn1+NfO+2MQl9/Ock+fJ7l42MsN pMZy26kF0RzWFTQUb2ckSqYVIuspQttMdfqrAPrjjJBX6t3B+khphKxckTIfHX+heMV1 Sodw== X-Forwarded-Encrypted: i=1; AJvYcCUs8RlMQD0/j1ukQzGpSh2Vv3ygp5sDGUcgqxryC0LeZ4C7WIrOT2cpODNwwUp3gB1aQRYeB/OwomQIDKk=@vger.kernel.org X-Gm-Message-State: AOJu0YyTNre51evXDTy5ykgkGepZ9uJWLQ/kMT8T4KhIEAXeKSZ5Aa+k w7KENPL7TPwbYXSNqym4v9nhAQV5T+KUHNjjzfgjlE5k3OBBpqvki7INbLwrWKnMqJI7HeIHyhc pyhogqTZaqpJ7nudOzWxGIxzxvoEC1AAo9RJHthtrFTJ4ZM5aVTOCJPqvE6rU0xKFcGs= X-Gm-Gg: ASbGncvmBEfVAGpHezAkPPBdj5hp4HHUhIumUkdXWo0JiHdFKYo76PXgBh9hHaCrIp1 5amyjA8zGbhjJos3zU0OPLQ/9zHTTkzIfirziH5PjNp8zLFsKkGvLZ7EHcG+keYuxLC7qqEtjvY Qj1Cy/kFdQhLDU5aLrBS2S5Tr0KJ+qJ6O9GgjlaUihOtpG1smAj5ckxM9dZNKREi5VZMk5UflZs kn9Rd8VM8rYjIAeMZz0gQHe5WTg6czAL1HTauvmurRvyeVegiQy1r239NWQSEztfwuQs9fBYaTm ia3fZmxLhp+xFewCspgbKSFebZiFnZx5cpzqCScDYtqp8N1R1vYAj/pnQj7IQS7D7yDwT+3phRR JAQaG4vVAEQPxh5ENDIpaD+qziP6F3w== X-Received: by 2002:a17:90b:3b49:b0:32d:ed8d:722b with SMTP id 98e67ed59e1d1-32ded8d7605mr1011419a91.2.1757677583422; Fri, 12 Sep 2025 04:46:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHOO3x9HBu+6RQUyafNlV1VtHCgdpyhgYvQ2Af2AZB8bDMWIdgsW8DZPmtsiC8C+rNUWBKRqA== X-Received: by 2002:a17:90b:3b49:b0:32d:ed8d:722b with SMTP id 98e67ed59e1d1-32ded8d7605mr1011388a91.2.1757677582972; Fri, 12 Sep 2025 04:46:22 -0700 (PDT) Received: from [10.133.33.174] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b54a3aa9234sm4626367a12.54.2025.09.12.04.46.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Sep 2025 04:46:22 -0700 (PDT) Message-ID: Date: Fri, 12 Sep 2025 19:46:13 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 04/13] phy: qcom: qmp-usbc: Add QCS615 DP PHY configuration and init data To: Konrad Dybcio , Dmitry Baryshkov Cc: Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, fange.zhang@oss.qualcomm.com, yongxing.mou@oss.qualcomm.com, li.liu@oss.qualcomm.com, tingwei.zhang@oss.qualcomm.com, Bjorn Andersson , Konrad Dybcio References: <20250911-add-displayport-support-for-qcs615-platform-v4-0-2702bdda14ed@oss.qualcomm.com> <20250911-add-displayport-support-for-qcs615-platform-v4-4-2702bdda14ed@oss.qualcomm.com> <3ihzpsmf3btzeltxggdnbheji6bdeornravua76adw5dhotztu@e3fca2prl45r> <274b27e6-ef43-4597-a7d6-1f948f2e6c5b@oss.qualcomm.com> From: Xiangxu Yin In-Reply-To: <274b27e6-ef43-4597-a7d6-1f948f2e6c5b@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=aPDwqa9m c=1 sm=1 tr=0 ts=68c40810 cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=yJojWOMRYYMA:10 a=EUspDBNiAAAA:8 a=1iQPH-MNloaYeFAjbucA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-GUID: 77bT_ggTh6YA9K5hD7RwxgXLtdogk_H3 X-Proofpoint-ORIG-GUID: 77bT_ggTh6YA9K5hD7RwxgXLtdogk_H3 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwOTExMDA0MCBTYWx0ZWRfX9IISkTmcM2aW VQoSJg0iQrguOlUm+uHz+EK/GrRr0QdxICU3WM9q8kVlGoGu4Dxxrm2gwDGsWbwNF9In+GiKD9R Rk25NKXavCqo7EKdrtOPvkIRX2e75b+qoH5ALVKXjF4EIOei5m/rkyyk4P85UuS4DuJoNaGjdQh if/Nf/3TsbJWf8LF80egXONcM2KsQM1p6UrWexVpP8dJ+17xZCdCV/NlAyIPgiwoGfxGCgh7yg9 zLDH3RZtUAnwys0lHysH75mYg0Jufzw6D5zhiUIEH8SmkMsH3MoCRPAoYFVPXZfn4JVy2yfkhVS z/nGuUpbUDk+cKBq/t6+ExjAIzKOSPu/vTnIQZ1c1Xd+d3+SIz4jH7xumnLIQE1M4Zy+Ao8OU0Y 72ZYIEGX X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1117,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-09-12_04,2025-09-11_02,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 phishscore=0 impostorscore=0 malwarescore=0 bulkscore=0 clxscore=1015 spamscore=0 suspectscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2509110040 On 9/12/2025 4:46 PM, Konrad Dybcio wrote: > On 9/12/25 4:15 AM, Xiangxu Yin wrote: >> On 9/12/2025 9:24 AM, Dmitry Baryshkov wrote: >>> On Thu, Sep 11, 2025 at 10:55:01PM +0800, Xiangxu Yin wrote: >>>> Introduce QCS615 hardware-specific configuration for DP PHY mode, >>>> including register offsets, initialization tables, voltage swing >>>> and pre-emphasis settings. >>>> >>>> Add qcs615-qmp-usb3-dp-phy compatible string to associate QCS615 >>>> platform with its USB/DP switchable PHY configuration. >>> This should be the last patch in the series: once you add the compatible >>> string, it is expected that it works. >>> >>> The patch LGTM. >> >> In v3[12/14], the compatible string was placed in the last, and you remind me >> will trigger unused warnings for the earlier-defined qcs615_usb3dp_phy_cfg. >> So I merged them in v4.  > The intention is that you can do all the preparing first (which doesn't need > to include an assignment to e.g. DP tables, since the code operates on a > pointer if it's non-null), and you can push all the platform additions at the > end (both tables and compatible in one patch) > > Konrad Ok, then merging 04 and 07 with the compatible in the last patch looks appropriate, will update in next patch. >> If move this patch to the end, patch v4[07/13] will hit unused warnings due to >> missing references. Should I squash patches 04 & 07 and move them to the end? >> I'm concerned the resulting patch might be too large. >> >> >>>> Signed-off-by: Xiangxu Yin >>>> --- >>>> drivers/phy/qualcomm/phy-qcom-qmp-usbc.c | 141 +++++++++++++++++++++++++++++++ >>>> 1 file changed, 141 insertions(+) >>>>